From: Ferruh Yigit <ferruh.yigit@amd.com>
To: Ronak Doshi <ronak.doshi@broadcom.com>,
Jochen Behrens <jbehrens@vmware.com>,
Ronak Doshi <doshir@vmware.com>
Cc: dev@dpdk.org, stable@dpdk.org
Subject: Re: [PATCH v3] net/vmxnet3: fix a missing vmxnet3 register command
Date: Fri, 26 Apr 2024 14:51:12 +0100 [thread overview]
Message-ID: <1ea9d816-9add-4844-afa9-71381b7afb72@amd.com> (raw)
In-Reply-To: <20240422181050.9661-1-ronak.doshi@broadcom.com>
On 4/22/2024 7:10 PM, Ronak Doshi wrote:
> Vmxnet3 uses capability registers to advertise the supported
> capabilities of UPT device. It uses DCR0_REG command register
> for this purpose. However, the register command enum misses
> one command which technically is not used by dpdk vmxnet3
> driver yet. This can cause issue for commands added later.
> For example, DCR0_REG and MAX_CAPABILITIES register commands
> when issued will lead to incorrect command being executed in
> the hypervisor. The return values can be unexpected and can
> result in some capabilities being disabled and affect vnics
> requesting Uniform Passthroguh (UPT) mode.
>
> This patch fixes this issue by adding a reserved
> command in its place.
>
> Fixes: 5241d61bd865 ("net/vmxnet3: support capability registers")
> Cc: stable@dpdk.org
>
> Signed-off-by: Ronak Doshi <ronak.doshi@broadcom.com>
>
Applied to dpdk-next-net/main, thanks.
next prev parent reply other threads:[~2024-04-26 13:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-22 18:10 Ronak Doshi
2024-04-26 13:51 ` Ferruh Yigit [this message]
2024-04-26 13:55 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1ea9d816-9add-4844-afa9-71381b7afb72@amd.com \
--to=ferruh.yigit@amd.com \
--cc=dev@dpdk.org \
--cc=doshir@vmware.com \
--cc=jbehrens@vmware.com \
--cc=ronak.doshi@broadcom.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).