From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B217DA04A5 for ; Wed, 9 Feb 2022 18:51:48 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A58B541150; Wed, 9 Feb 2022 18:51:48 +0100 (CET) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id B2C9040140; Wed, 9 Feb 2022 18:51:45 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644429106; x=1675965106; h=message-id:date:subject:from:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=pUShSX1HsHNsQAp7oScGMqzPWRG9XOP63nR3ht/LTno=; b=F+9hw5NFrFNFe8J7dVLVsgrOWesaEhUE2g1lLPR+1YlI3fAaxnlD+5k5 KpobtZbDoJ2l27HBVLudl1tIsLAz0vBC0T/50hhhUl1kGuj+5Tscd590+ uVlj9V7BE9cWb/QZTKwdJpo81imD22yJp3Gr0+nZfyoHeV5O/rsUn8RFs hZt0rgyflYEzHSlfFEZ3nOE4aQxwxFy8QMVq1ms3czvoqwYwgQJ8Bwz7n IVDu/3zxQzJSm2JUFJeYK79vKZJIyLUaSuUSZ71DWOOqpgDSX+4Ya8MC6 ZZMtZZVgRvGQ3MWwgmtAmmGVkUSV5E+056mCJ4hnoRX/EaWYsTAgxXSAc g==; X-IronPort-AV: E=McAfee;i="6200,9189,10252"; a="310020451" X-IronPort-AV: E=Sophos;i="5.88,356,1635231600"; d="scan'208";a="310020451" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Feb 2022 09:51:44 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,356,1635231600"; d="scan'208";a="773571742" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by fmsmga005.fm.intel.com with ESMTP; 09 Feb 2022 09:51:43 -0800 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Wed, 9 Feb 2022 09:51:43 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Wed, 9 Feb 2022 09:51:43 -0800 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.46) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Wed, 9 Feb 2022 09:51:41 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cKJwSBR76y9iqaQK4b9NRMEmrVYR5VmOi5ba0NAba21VMII5Pt7KtRvBqBpNoK2b9b0sIALq50gq4886zr9HPf4NBWOh6hxkeSRtF3EyIo1eLtJzuWFGHAmEHIcfhybae00ebbjYa8PDu3366lxfXccJJpBAlrgLKONt/tjRkmn7HrlBEgGWpBmp6rNoGEktYLl/RrrYvrykFksieGfViEYK4YFQ0NCjYMeUhmNfFiAU7FMyS2QJMOys580/vlcnyuMhaVO2PmnLQbOCxZXgsvcj9LGPPNjYG5OuKVRFr1mN/3lqSoSGb04xhk0B3USm6Vhw4H2sAsUh3vc7pZs3iw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LR/PGvAwZg+i+I3Qti1LifEUboToAN77ZnmQxbVroo8=; b=FxiAbOb+L854Z7tI+SSQnxvj5FBNpt7bC02eBCwPGUpBpx3GKLS88AquVRb6wQFWbTgHQuOLeeH0svxzyuLbgIo8aMhvkCGzbVUAH/y5PCgUiZKuw/e4xIwEXSR7Y1tI3cm97yIP1zlcUmpOpISQ4oQiyAomoLK2rmhuxAKR54TjoMxBRghhM+oOsBwWh9xeLpcGcqcQqe/exD/M7tXm0/eUuUtYBPsqUZK8NIb7AmjZYTS2hvy5ZRGquShypIWrPIYHGKvfROKsyJou3TATJApYwwIDDVZS3gNq1cRJ8fSvtRN1gLa13aH8gw2FTXLeMqMpBxU2EDO4CfnQQZNKwg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by LV2PR11MB6046.namprd11.prod.outlook.com (2603:10b6:408:17a::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.18; Wed, 9 Feb 2022 17:51:40 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::98be:5506:5020:28a2]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::98be:5506:5020:28a2%4]) with mapi id 15.20.4975.011; Wed, 9 Feb 2022 17:51:40 +0000 Message-ID: <1f351896-1cfb-0e15-29a8-206c7f20de27@intel.com> Date: Wed, 9 Feb 2022 17:51:35 +0000 Subject: Re: [PATCH v2] net/memif: remove pointer deference before null check Content-Language: en-US From: Ferruh Yigit To: Weiguo Li , CC: , "stable@dpdk.org" References: <1ab6f6c4-7284-4ee4-8828-7bd9e98baccd@intel.com> X-User: ferruhy In-Reply-To: <1ab6f6c4-7284-4ee4-8828-7bd9e98baccd@intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0298.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:196::15) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a58db588-7092-45c7-302d-08d9ebf4d346 X-MS-TrafficTypeDiagnostic: LV2PR11MB6046:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:411; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: vUCGRbQ+wkfLgGrQIqojhlZs3ZTiURw6wV+42cRUAVQBHDBmOnvhd8pbul3qoEGB2Bp/KctsCsC5fQ2hJ4pnBjfyUAHS+8pMgQin2FH3F5+9lDby8Z/1KkmNYk/XEGTEuLoX9al1k51bCFKda8l4+5lFRzDcYFQxBy4J4NUNV40+J89pmLeMo3dXfulUPd8GCtEK1zdiNEzqbaS93kE/1dvnT7ANKqLAXlJkUWO3h6Z3e97Zf48w5sg0b5ZWSc/PO5u2Blphqtkut7pxmQRmcLJtgHuyl8WUTOtaJryrc/0KwwVyxmoSu77EI2EXJia+OUc8llpfczUnKZMSO8LFLDY0ko4viy67TBuKYcLPcQ0JAtacOVHZb0zzghcf08GJ1VtET2mWaEFy4fgYdsx4NJvbGsEh4EVBzQhLOiKa6+45L7K6BY5He5U4Egf9qCEV6Df6htXy1E6nw4oqW4oO16KIFG+gv35G4c0LFUQR6B9ZIKOsEgpSbc72DGTrV7zIclgPhMPJARcLY9xizOHh42bj0z9jd0o1VmF9Emmv1gvIMQh6eixRtwqT1PRhet8pyDlPx4y7D+jIB9JFCf4PqBa7E1rbxVtaFGe3F8hggPF8kXAdkkoSYbfU5fN33sZTgQc1Sa3K2s/93Mr7E4d42bk1pUlyvmVns+VtcPpTZVEdKT1wSkgq7NHXOGoEhmADSlGWVFGq+WRdzsLIW7iW2aCJbWDWiYX5rhEtqoqYmX0HLdUAWfCnmqWnnf+cSDbE X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(6486002)(86362001)(4326008)(66556008)(38100700002)(66476007)(316002)(66946007)(2616005)(186003)(26005)(36756003)(8676002)(8936002)(31696002)(44832011)(5660300002)(6512007)(6506007)(6666004)(508600001)(55236004)(53546011)(4744005)(82960400001)(31686004)(2906002)(48020200001)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QVc0UVVQTjJMTDUrcU5VTGhvckIvSTNrQ3J6ejJGVnZ4bDBhR1JRdC9rTHQv?= =?utf-8?B?UmZlZWp1aWNvTmdNTnI5ZjdnNGNPQ1hvdnNQWTd5QjkxWG9neUQ1MFBHY3dV?= =?utf-8?B?Ri9QL2dMU2hORWUyOFFXRENWd0dnaTUxWUphaFpzcVMzN1FIcytXZjhIRkow?= =?utf-8?B?d3BFUDdYQ25zK3orRWt3VXExcHU1OE9LakE5UmtYNUtuRDRRUmtjK01KcDhW?= =?utf-8?B?NXFaRHloU1IzczRlaGVyZEFRQWhGMVNXT0s2WnpBNWhkQXh6TEhDU0lFUTkw?= =?utf-8?B?eXRodTVMTkF3d2RXQmhxWDJnMXZOODdsT2EvYXIwNEhyR2g1L25aUGJ1NFBo?= =?utf-8?B?eXR3VDBsREV5Y0FnbDRZUG9YMUdDN0ZrYmp1aDk4cFdIbmVBTGwzZEo2aGZF?= =?utf-8?B?L0JVZTdzVU8wemJBOW5KbXEzTSttQVloQUJVY3VuYWFML1RqV013aDNKWkFW?= =?utf-8?B?RkVHb2xTalRPeHRMdzd2WnF6cGtmTjA5R1lHSDhqYmJNVzBrbW1BTytGT3Jq?= =?utf-8?B?K0tnb0FsUWhJUzBBa3ExM2lKRWQ0OFJWa2lyNXRIdlN4NGRnRXBNV3F2bzY4?= =?utf-8?B?bWZaUC9TU2ZJMlFxZTJFMitPQTZDR1F1dHBFcXVjY1ZJTklWVGw1ZkZJL2l2?= =?utf-8?B?dm1UT1RwNytlc0JyNTMrTkJTbXV2VU1HTnByeXA2MTEyRGVoQzM0OFJLdkRr?= =?utf-8?B?c25VajBQbmlTVG82Y1VuMGI5c0tidHNQNUdMZ2txQmFUWG8yZ1dJN3VObTly?= =?utf-8?B?MHNaemR6aURwS0p4dFVaOFI3aGh6U3RPRmZOWmc1RHIzejh3eWZ5TDc5NGE3?= =?utf-8?B?K3puZmdTektud1lEOXYyN1RIcmlkMjNweGwyTUlOajdkS05nKy9najlWbWFD?= =?utf-8?B?dmVUOW9ybzV6Qk12SXhHTWhWVzhPd1JyMUhhT0E5MXMzQk9IMVdtWG9oU0F4?= =?utf-8?B?R0xZU2ttZ0d2aXl4Mzk1bE9Odkt3U29lLzlTT2dJaTVxN0JjWTRMV0ZoVmpl?= =?utf-8?B?ZWxOZ2krRjk1bjRLeWQvOXJWWU1jVzV5QmFkT1dScU9pWjY2V3RHOGhYdlF4?= =?utf-8?B?MWRmSm4zUHh6OGRad3BOamo0eTk2UjF1QS9rdlNhdGpTZHVWNUtzSkhidUFp?= =?utf-8?B?OEZHaGI0ZGJOS0crVVZUMXI3a0tlUXIxcnk1M1RCOFpXMFljNXM5MkE5T3Qr?= =?utf-8?B?NjRhTmRUQ3QzenE1QW5FK2RGaDlVVEVOcXcvM1ZzcFpKdE1jRW91U1luRTZI?= =?utf-8?B?Wmg0bE5ZRVBPbWpQbmlzeXJKTHJNb1lvRUhZcjRZSHRPazlTTUpsWmRCVC80?= =?utf-8?B?ZXFUbjNFZUdSMTVVQ2loWkM4Q1ZKc3RpcDhwWlplRFllSGU3WVMrNG5NYzF5?= =?utf-8?B?Z2FpcmtyYXduSG5pRHoyT3N1UlB5RjVuTHdEVCtuL3FuNUptYTJQbkpWMC9u?= =?utf-8?B?RDlsZ2pLZkdCVXY4VVRwQncvK1RvSXhKQWM5RGNuVEZjZXhZbXhsQXI4aXUx?= =?utf-8?B?aS9VU0tDN0lldS95MjZ5RktpMmYxdVB5N205bk0yT2dHOEFRZFIzMU9PZTdH?= =?utf-8?B?Vm81K2tYa1FwVGJFN3F3R1R0bVBMNHFxSEt1ZklLTVpRUEdLd2R4OTZkWEh4?= =?utf-8?B?OUg5OXdLK3ozaTYzSzdjcnVnOEJQYXVVM0orenhya0x4Q2xpRU9McDFPM3E5?= =?utf-8?B?ajZvcFhJYWhJOWJmSWtscm1lbTZMZHlZWHdMelAxTXdKa1o5eDNSTG10T1JM?= =?utf-8?B?ZVZnU0R5N2RSak5MeXRTTGo5S0k5TjJJUG5WTmIyUkFLS2diM0Fwekg1QzA3?= =?utf-8?B?UzRkQmlYTHBpd1RvT1MwcUFRVHp0Y25XOVpsMEVublB1MGd3Qit5Y1NUU3JR?= =?utf-8?B?b252cStNT0p1a2l0YlBzOWZPaHlMVzJjZUg0cnA1S21ZSldwaG5ISlpiREpS?= =?utf-8?B?R1dZYVNTYmZjdHp6aDBNMmRFZFRuV3ZHejJmNkFtdUhONmFLeVFkbkNDVU1D?= =?utf-8?B?TW9MYVdBcUQvejZOUVV4ZGJZd2VrZHdHQmNjTWRNT3hUVnZ4WVh2djRCamRM?= =?utf-8?B?Um50aGNhWWFUemZzd1VNQjR1U3dWNE5ndmNhQ1JpZW5yVWc1NVhRdlZuZWlU?= =?utf-8?B?UXY3Vm84QmE0WmZyTWlnMUxnczFMTTZiNm5ib1RIMnhSS0FMTnVwdWQrVlNX?= =?utf-8?Q?yoQ2MxWfAINbDUXceYrsHK8=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: a58db588-7092-45c7-302d-08d9ebf4d346 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2022 17:51:40.1587 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: kQyiq+g3205J6zkB9gouOanZwiRWzu59+51bXjaPIGE4FZV4icaBiZ9cbBs8IN6oGgBzHcy3E2gVTAepG7XfzQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV2PR11MB6046 X-OriginatorOrg: intel.com X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On 2/9/2022 1:56 PM, Ferruh Yigit wrote: > On 2/9/2022 7:39 AM, Weiguo Li wrote: >> There are duplicates of assignment here, the one before null check >> may cause a null pointer deference, so remove the previous one. >> >> Fixes: 09c7e63a71f9 ("net/memif: introduce memory interface PMD") >> > > Cc: stable@dpdk.org > >> Signed-off-by: Weiguo Li > > Reviewed-by: Ferruh Yigit Applied to dpdk-next-net/main, thanks.