From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D6C6D424A3 for ; Fri, 27 Jan 2023 16:37:28 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CA5FA406B4; Fri, 27 Jan 2023 16:37:28 +0100 (CET) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2059.outbound.protection.outlook.com [40.107.223.59]) by mails.dpdk.org (Postfix) with ESMTP id 4D2FD40146; Fri, 27 Jan 2023 16:37:26 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aHsmIwMGgmSS0CovHR6XA8WAw/FFDPHqB0s/0YoolEuUm47/4lEAVCBe16YZX/CPfY2li/doPejBaJ5sasRY1bnXu4jFcj02vAwFreYXbdns0eNojkrPoStOdInx7OpI8VdCtt9C4U2sxSa2EDYYxW9PFiydaN71vSF7nqAa4pQjH2qnPqqP5oisBD/T5lY5KXfr0SSAyUiVj4TyIsMqaNCVIF7b8Mic3mY13oneJm33OiuC+m4ndmA0R4BbJasNoiF6fblnWf12XEdid4/PXAlUWe7ArhrX0Bg8z0gcPdUPvJyqdWutHJsEwSq1idejCW1Rr042JJGnNqnHp9Xbig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mpMPbwrjOSEiXpvCTGK+1gDT30r1zHOxrfasHxiT9/A=; b=QD68DeOG+QZDHnWC8Yd20R1vV6NIQCsBVhzFTQANWREcbbVRXNePvahPu7VWWaOk6h5uKfLB5NjlmneZCPQbWMs+xN4f9VbC2b/lkDyDrKPL6qfzQTbGgzGxLNTtYBClDxOmUY/lmKj2vv93vlsILEndLfXIP6jBe7l3kOV2G/LwwRWvQxAmWx+wGGYSapidccFpKY548hALYCT5wgLc2/TGWZpxOZEkePKQValg0GDnQHNsiPJIrf/FxjCuzLQ7QyUTy5TDhVUE9Je50nxFrpv66JJHKOcfBdF3yf0DFwWiv2HnnAGeFFSFMsMeordwmMz2DHEq74Q6Q9z0oEX0wA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mpMPbwrjOSEiXpvCTGK+1gDT30r1zHOxrfasHxiT9/A=; b=CXrTZcTqVz+oDuU5vh7/pZ1hJC+AlYCdkhIBAKeXvRSkM6HBv8CuodljtGgQg9fhGKO5FC3Ug/Q2ezSvnPAc8e2mvZ9OccNnvyOEqu5l9kpCLIkuzwA/uxBPjpaWbmQagCt7beTGglj7EExZsZqkEO7YIMD0+73qsb56AzE/fbs= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by MN2PR12MB4125.namprd12.prod.outlook.com (2603:10b6:208:1d9::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.23; Fri, 27 Jan 2023 15:37:24 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::4807:1f44:5e04:e05a]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::4807:1f44:5e04:e05a%8]) with mapi id 15.20.6043.022; Fri, 27 Jan 2023 15:37:24 +0000 Message-ID: <1f825130-2263-13f9-89b2-476056c11803@amd.com> Date: Fri, 27 Jan 2023 15:37:19 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Content-Language: en-US To: Jiawen Wu , dev@dpdk.org Cc: stable@dpdk.org References: <20230118060039.3074016-1-jiawenwu@trustnetic.com> <20230118060039.3074016-5-jiawenwu@trustnetic.com> From: Ferruh Yigit Subject: Re: [PATCH 4/8] net/ngbe: fix packet type to parse from offload flags In-Reply-To: <20230118060039.3074016-5-jiawenwu@trustnetic.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO6P123CA0004.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:338::11) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|MN2PR12MB4125:EE_ X-MS-Office365-Filtering-Correlation-Id: 0b6aa411-0b8f-443d-6c85-08db007c635a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3vs3NEyHBAvlGceGxUfwIXFiW5D0W02N9gXr3x+TB1fGeyiKc0nOou4j8RIZk3QyNeUaEswIw9PuZAI0T+fAE7l3XNHFfRisFj1aLSN30WaIeWwBf/n1nmXMjqos7AqQGzy3+YnEovGfI2rNPmYNG+rGf4l965hR/G3ej6gQfSka+ayNvfJns7rYNdZmARWORm1BeJn7EF/GRNWbzbOCrU/1I7k9Y6NJa5evGTZq4igvH0h3t9cWreJPcrgXgkdB+3IubfeYijIAJKSMGU/hQ2FjvlakZF+cLib406hyq/Yf3J7Tp9WkyL97tK84snZRFOTJHUc5dFaplgL2ZcwUuonxLuQqeOAMtflzHEyuK5m5H/a5G6f6S3WaqU/+TJU0z5YFXtINP7pJZpGmalPTfVn3zs9dTk3RCyvVDmyjJJRaHmzRvBsHY/WZjdGTrz147HV/8C0lJrwbCocVmZ0RUM+wilcthOSj1FoLg6zHEG+R9F3WimopimLQNk5l9WSy+hSQeDQcJNjg3yKoTUb7mTvV5DtBcAaF6YMOxHoRRaOpF1W4q+34dhZynReF+CVXjQxY+QFAkHwmoRQNk9q5MRUu/7vL5w1oQb0FG53DTk3X67riCJaHAenByqMbY3xaa3YR5tpbf+k7Vo4cewK6ANGccjNYT8Qr/F54QYSLFPB1KNC8bnBeDYMvsWvf6CYcUxhJQHrfdSO8q1GTgdrZHgMH7GxwEcQCsgOfQ7/bbco= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(136003)(396003)(366004)(376002)(346002)(39860400002)(451199018)(41300700001)(8936002)(4744005)(6666004)(5660300002)(38100700002)(86362001)(31696002)(316002)(36756003)(66556008)(66476007)(66946007)(6512007)(8676002)(4326008)(26005)(186003)(2616005)(6486002)(478600001)(53546011)(6506007)(31686004)(44832011)(2906002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MDdsL3BxMmIyMU5QaWUvU1lIbVdocVBaQllTL2w2V2IwVnJRTXhHYmxsVU9C?= =?utf-8?B?dk85aVI1NmJDaTM5azVyRnhDaGxHZ3dRbENsUXV1Z0VGODhrMCtPTitNYjNC?= =?utf-8?B?dmRCZzhrWWpFMWRHbkxxOE56S3M3eDM2ZHJwL2prY0w5Y2xjU2FrU25jTWhG?= =?utf-8?B?Sk1PV3NzbHZMN2NPRXIwVGRvWFU3eS9qQSs1WE96czNobzJYckk0ajgzaVF1?= =?utf-8?B?Q3FUSmVNV3UrY0VkZllrUm5YaXBOV1NmbFBRSXJxbFh1eno0aS8yMkVlZm1t?= =?utf-8?B?U2J2UGZRRGpiQXhOMkU5M3gxK3cyYS9JVXE2YjI5TzN5S05md05kSjQranlm?= =?utf-8?B?WCtBdlg5Yld4ajFZajNIR2NJdER1WXFKcGV3L09YSUxWMVFOWks1TVpGbHUx?= =?utf-8?B?WC9xVWFQMmpERGJwSzdSQnZnNndkL29VUUUwaTRxTGVWaFBHT2dLejVGK01I?= =?utf-8?B?SlRrMjVGOXRGTGMwN1BONVNDYXIrMDNjYldrRzdhK0Q2RVVUZ3AzZGwySno3?= =?utf-8?B?TzYwTFMzY0JTVUwyQnpSbDgySURaYzBvSTFEMWRxUlNwSEZOQXRmUmlTN2gr?= =?utf-8?B?YjUwUU9xaDVmUkw0OFlEWk5JUUR4OUtGNk4zbzVMeXU3QzBhZW5iSkpPSkhQ?= =?utf-8?B?eWlrZnFCbVRUbDJEYndWdmtqelZmeXQ5YzBaMTBFd0VPSlhObVBlZUZOdzFC?= =?utf-8?B?UlVCT1BMaThnYUdhL3dBZjh5OUNxTlVLSWNIWFNTYkFmaWFzVDk4OGZjamM3?= =?utf-8?B?cWJqWGxXVXdJOWEzVkNMYUNoa1hQNlRVc1JQTS9NMjdTalN4TnVRVUVPWjRT?= =?utf-8?B?RldPais3cWtycjBrdXh0cVhCWm9hNVUwNkJiL2poNW5Sbm1LZWJ6c09BUU5U?= =?utf-8?B?NnZkYTAwZkk5NnBzeEQ4cHZRc2g5WTVHL2Vld1BxdDh2Yi9wQWJna1dBVWY4?= =?utf-8?B?bXBJYXJlV3E3aGFIVVArVy9XRzRzbGpWSUZrTmpoVEVhS3NsL0NzdVp6bEl4?= =?utf-8?B?dUZISU5JK0xpUkVNYmVEdERuQjAyc0FQd0trSkJvaDArN0gvSDgraHZSZUV0?= =?utf-8?B?L2daaGszWlNNaFdoZ2NDdC8zTG1iVThONUtETXhCZHJoM1UyL1ZRRG1XMWRO?= =?utf-8?B?WTNqcDdySk14ZmtEUUU1akVCQ1h3SDZpdnZ1UW9JOE5GellpT3MyMmtvN3E4?= =?utf-8?B?TnBHQXpoMlJzWEZzd01VaDU4YTd5YW5EY0xYMU41YW1RUVRNZ01hNno0bUdO?= =?utf-8?B?VndJVzV1cjZWR3dYbXRKMjFYTDZZUkFqUkdwY1JiOWhyeUU1WnZvK0FmQnNh?= =?utf-8?B?WGk0bjRkWStzbVFTWk5JV2hrNUFqNE5HWDFvcFBzTk5CS3FSbWVPTEY3YVZ1?= =?utf-8?B?M00wS0VaQUFlazhxOGg3aVEvRndCc0xpQm5LYlhTaEpubUVnUnpGMjVvUzho?= =?utf-8?B?L3lhMkhvazh0TktTSDZyU2Uydm5aRFJXUFV6SGFwcDVJNVhCcnlwRnRhTkJU?= =?utf-8?B?dnY5SU9RS0RudTVWUmxYZUhQV25OZmxtYnNrQlNnMGVwckdqdmtQc2FoU3lG?= =?utf-8?B?SkhFSkcwVlBURmhsSTdCSUNsN1NBbnVNcDBQeWRqQ3FkNXlCNThmY0ZsYnJp?= =?utf-8?B?TzhSY0pHZ0ZBUGtnRG9qSjFlaG5GQnhIaWQ1Mm5EcUdRNjdWM2JKdVA0Qmpv?= =?utf-8?B?aHZCSjZiLzRYUk5IZTl0dkhxdy9McnVJTlRna2ZIWUFhK2NScytVRGJBcVpE?= =?utf-8?B?NVIwdy90eHorS0lzVjhVcGdXUDlyTWdoK2tHWjJaWEZaWlVyM3BEbmZYKzVV?= =?utf-8?B?NFF1OTZFNmtrVFdPbkRpbzVXTkZyVG9hWEw5d085YzB2QlFoa3pFL3RXclhW?= =?utf-8?B?ZHl6VzEzVFVrZlhEWUJ5OENBNmFkVUxMWCtscWtHeFZBV1R2Yyt6b1dMaEtF?= =?utf-8?B?dnpvSi9CLyt5Qjh2UzJ6dWlNYy9QTE5WZi9pT0I5UUJOZmVxdGdmb1F4emhW?= =?utf-8?B?NHZGSUZXakdXTjdtVlhUVlZwd0xlWGlwKytFL3B4UzBhWCsrVWZpaU9VUm0v?= =?utf-8?B?WWc5VGU4bHBJYVNPVTIza1M3WE9LMnJScTNpQXJISHBqTXlUaFVjcHhZRE5S?= =?utf-8?Q?qqe21aRFpYTo5Q165CTY0GjxN?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0b6aa411-0b8f-443d-6c85-08db007c635a X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jan 2023 15:37:24.7291 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: g9Ot2IfsJM08tzf/5Wkwv42Rhr1LP3UqEu7MMDiw37e6etXk2TJjICiHfnk8N72V X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4125 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On 1/18/2023 6:00 AM, Jiawen Wu wrote: > In some external applications, developers may fill in wrong packet_type > in rte_mbuf for transmission. It will result in Tx ring hang when Tx > checksum offload is on. So change it to parse from ol_flags. And remove > redundant tunnel type since the NIC does not support it. > > Fixes: 9f3206140274 ("net/ngbe: support TSO") > Cc: stable@dpdk.org > Similar comments with txgbe version of this patch, Can you please explain more what cause problem on setting mbuf packet_type for Tx path? And in 'tx_desc_ol_flags_to_ptid()', 'ptype' parameter is overwritten before it is used and parameter is useless.