patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Luca Boccassi <bluca@debian.org>
To: David Marchand <david.marchand@redhat.com>,
	Thomas Monjalon <thomas@monjalon.net>
Cc: dev <dev@dpdk.org>, dpdk stable <stable@dpdk.org>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] doc: prefer https when pointing to dpdk.org
Date: Thu, 19 Mar 2020 18:52:31 +0000	[thread overview]
Message-ID: <1fcf605c0b28ab8f34ab1d576e3729be0b3f13d9.camel@debian.org> (raw)
In-Reply-To: <CAJFAV8w_8K3rjnSXjqGQ1KYWzeu3uZXXMsdKoyLvUWJxsUa2xg@mail.gmail.com>

On Thu, 2020-03-19 at 16:40 +0100, David Marchand wrote:
> On Thu, Mar 19, 2020 at 10:01 AM Thomas Monjalon <thomas@monjalon.net
> > wrote:
> > 19/03/2020 09:28, David Marchand:
> > > for file in $(git grep -l http://.*dpdk.org doc/); do
> > >   sed -i -e 's#http://\(.*dpdk.org\)#https://\1#g' $file;
> > > done
> > > 
> > > Cc: stable@dpdk.org
> > > 
> > > Signed-off-by: David Marchand <david.marchand@redhat.com>
> > > ---
> > > +     # links must prefer https over http
> > > +     awk -v FOLDERS='doc' \
> > > +             -v EXPRESSIONS='http://.*dpdk.org' \
> > > +             -v RET_ON_FAIL=1 \
> > > +             -v MESSAGE='Using non https link to dpdk.org' \
> > > +             -f $(dirname $(readlink -f $0))/check-forbidden-
> > > tokens.awk \
> > > +             "$1" || res=1
> > 
> > Interesting policy.
> > When no authentication is required, I was trying to use simple
> > http,
> > in the hope of making access faster.
> > What is the benefit of https for documentation? Avoid man-in-the-
> > middle?
> 
> People probably don't notice the little extra time required to load a
> page via https.
> 
> Trying to go to dpdk.org with simple http: gets you redirected to
> https:.
> Then you browse down to the documentation with https, and finally you
> find some links in https.
> This is odd, but not a problem, I agree.
> 
> All in all, I prefer a simple policy that works in most cases rather
> than this rule that we must be aware of when reviewing doc patches.

The main benefit of using https everywhere is that it generates a lot
of noise - so when it actually matters, encrypted traffic doesn't stand
out as an exception easy to flag and store for later decryption

-- 
Kind regards,
Luca Boccassi

  reply	other threads:[~2020-03-19 18:52 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-19  8:28 [dpdk-stable] " David Marchand
2020-03-19  9:00 ` Thomas Monjalon
2020-03-19 15:40   ` David Marchand
2020-03-19 18:52     ` Luca Boccassi [this message]
2020-03-19 10:46 ` Kevin Traynor
2020-05-24 21:44   ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1fcf605c0b28ab8f34ab1d576e3729be0b3f13d9.camel@debian.org \
    --to=bluca@debian.org \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=stable@dpdk.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).