From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DEDABA0583 for ; Thu, 19 Mar 2020 19:52:36 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B89B41C0AA; Thu, 19 Mar 2020 19:52:36 +0100 (CET) Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by dpdk.org (Postfix) with ESMTP id 9D8671C05C; Thu, 19 Mar 2020 19:52:33 +0100 (CET) Received: by mail-wr1-f66.google.com with SMTP id h9so4469971wrc.8; Thu, 19 Mar 2020 11:52:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=t9wr2i2E8nEBN2ZpOKtAZWC6zXIAupdTZFbh37pQDqA=; b=UwZHIDtIgTeNNMp2YhJLLY3CmC58yICiT9HnZVEtZpaJko2QdUD77OqonMl3rv/Loh dEpqnTYP91nFdVYa9AMcQ6w+qESbjlmGHbuYR57AkiAUGbGWxZa65OtknmnhOJYCpJ0e 2aWTaW+hCRpNxdKpGuHwh5zRjrj3V5oFwA5XJp1zadVk8/BgSroL4yGzBwC/7RJUqWMe gXNgNA+Osn038yxkDsLSeUPszEKDnWCKB/pKBds6kYcX7BvMH7wGmCOk/YmfDi6yYTct byCl3b3OiFHG5ilo32TsWG89S3vwjx31w0S5NRgzVonLKB9iFWhH7c5NxPcnvL8ZX/ht Vd6Q== X-Gm-Message-State: ANhLgQ03vCZKYTvPUnkqIzBoxWemM2WgEz+U2m0mL7DyP+GdRM0mxaED KvbEbiVlU0nAHRSfP49AetU= X-Google-Smtp-Source: ADFU+vtztBxFvTsaILWokoagCkQt8dJPlE2kMOyHn9t3QZkJYUxE53cP0zkCV3GEAwrDhqllG8v8vA== X-Received: by 2002:a5d:4c87:: with SMTP id z7mr6381075wrs.39.1584643953508; Thu, 19 Mar 2020 11:52:33 -0700 (PDT) Received: from localhost ([2a01:4b00:f419:6f00:7a8e:ed70:5c52:ea3]) by smtp.gmail.com with ESMTPSA id 9sm4232726wmx.32.2020.03.19.11.52.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Mar 2020 11:52:32 -0700 (PDT) Message-ID: <1fcf605c0b28ab8f34ab1d576e3729be0b3f13d9.camel@debian.org> From: Luca Boccassi To: David Marchand , Thomas Monjalon Cc: dev , dpdk stable Date: Thu, 19 Mar 2020 18:52:31 +0000 In-Reply-To: References: <20200319082859.7162-1-david.marchand@redhat.com> <60947579.3F2A3RajZp@xps> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] doc: prefer https when pointing to dpdk.org X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Thu, 2020-03-19 at 16:40 +0100, David Marchand wrote: > On Thu, Mar 19, 2020 at 10:01 AM Thomas Monjalon > wrote: > > 19/03/2020 09:28, David Marchand: > > > for file in $(git grep -l http://.*dpdk.org doc/); do > > > sed -i -e 's#http://\(.*dpdk.org\)#https://\1#g' $file; > > > done > > >=20 > > > Cc: stable@dpdk.org > > >=20 > > > Signed-off-by: David Marchand > > > --- > > > + # links must prefer https over http > > > + awk -v FOLDERS=3D'doc' \ > > > + -v EXPRESSIONS=3D'http://.*dpdk.org' \ > > > + -v RET_ON_FAIL=3D1 \ > > > + -v MESSAGE=3D'Using non https link to dpdk.org' \ > > > + -f $(dirname $(readlink -f $0))/check-forbidden- > > > tokens.awk \ > > > + "$1" || res=3D1 > >=20 > > Interesting policy. > > When no authentication is required, I was trying to use simple > > http, > > in the hope of making access faster. > > What is the benefit of https for documentation? Avoid man-in-the- > > middle? >=20 > People probably don't notice the little extra time required to load a > page via https. >=20 > Trying to go to dpdk.org with simple http: gets you redirected to > https:. > Then you browse down to the documentation with https, and finally you > find some links in https. > This is odd, but not a problem, I agree. >=20 > All in all, I prefer a simple policy that works in most cases rather > than this rule that we must be aware of when reviewing doc patches. The main benefit of using https everywhere is that it generates a lot of noise - so when it actually matters, encrypted traffic doesn't stand out as an exception easy to flag and store for later decryption --=20 Kind regards, Luca Boccassi