From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: "Zhang, AlvinX" <alvinx.zhang@intel.com>,
"Xing, Beilei" <beilei.xing@intel.com>,
"Guo, Junfeng" <junfeng.guo@intel.com>,
"ktraynor@redhat.com" <ktraynor@redhat.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH v3] net/i40e: fix Rx packet statistics
Date: Fri, 8 Oct 2021 06:17:36 +0000 [thread overview]
Message-ID: <1fef42b9d2ab4d8d829f010013dd957b@intel.com> (raw)
In-Reply-To: <20210930051957.12628-1-alvinx.zhang@intel.com>
> -----Original Message-----
> From: Zhang, AlvinX <alvinx.zhang@intel.com>
> Sent: Thursday, September 30, 2021 1:20 PM
> To: Xing, Beilei <beilei.xing@intel.com>; Guo, Junfeng
> <junfeng.guo@intel.com>; ktraynor@redhat.com; Zhang, Qi Z
> <qi.z.zhang@intel.com>
> Cc: dev@dpdk.org; Zhang, AlvinX <alvinx.zhang@intel.com>; stable@dpdk.org
> Subject: [PATCH v3] net/i40e: fix Rx packet statistics
>
> Some packets are discarded by the NIC because they are larger than the MTU,
> these packets should be counted as "RX error" instead of "RX packet", for
> example:
>
> pkt1 = Ether()/IP()/Raw('x' * 1400)
> pkt2 = Ether()/IP()/Raw('x' * 1500)
>
> ---------------- Forward statistics for port 0 -----------------
> RX-packets: 2 RX-dropped: 0 RX-total: 2
> TX-packets: 1 TX-dropped: 0 TX-total: 1
> ----------------------------------------------------------------
>
> Here the packet pkt2 has been discarded, but still was counted
> by "RX-packets"
>
> The register 'GL_RXERR1' can count above discarded packets.
> This patch adds reading and calculation of the 'GL_RXERR1' counter when
> reporting DPDK statistics.
>
> Fixes: f4a91c38b4ad ("i40e: add extended stats")
> Cc: stable@dpdk.org
>
> Signed-off-by: Alvin Zhang <alvinx.zhang@intel.com>
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
Applied to dpdk-next-net-intel.
Thanks
Qi
prev parent reply other threads:[~2021-10-08 6:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-26 7:57 [dpdk-stable] [PATCH] " Alvin Zhang
2021-09-27 16:00 ` [dpdk-stable] [dpdk-dev] " Kevin Traynor
2021-09-28 2:12 ` Zhang, AlvinX
2021-09-28 8:53 ` Kevin Traynor
2021-09-28 3:21 ` [dpdk-stable] [PATCH v2] " Alvin Zhang
2021-09-28 3:22 ` Alvin Zhang
2021-09-28 11:16 ` [dpdk-stable] [dpdk-dev] " Zhang, Qi Z
2021-09-29 1:33 ` Zhang, AlvinX
2021-09-30 5:19 ` [dpdk-stable] [PATCH v3] " Alvin Zhang
2021-10-08 6:17 ` Zhang, Qi Z [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1fef42b9d2ab4d8d829f010013dd957b@intel.com \
--to=qi.z.zhang@intel.com \
--cc=alvinx.zhang@intel.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=junfeng.guo@intel.com \
--cc=ktraynor@redhat.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).