From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: Jim Harris <james.r.harris@intel.com>,
stable@dpdk.org, "Mcnamara, John" <john.mcnamara@intel.com>,
Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>,
Daniel Verkamp <daniel.verkamp@intel.com>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v2] contigmem: zero all pages during mmap
Date: Mon, 26 Sep 2016 16:12:17 +0800 [thread overview]
Message-ID: <20160926081217.GM23158@yliu-dev.sh.intel.com> (raw)
In-Reply-To: <4904186.gj4j9rRC36@xps13>
On Mon, Aug 22, 2016 at 10:58:46PM +0200, Thomas Monjalon wrote:
> 2016-08-16 15:46, Jim Harris:
> > On Linux, all huge pages are zeroed by the kernel before
> > first access by the DPDK application. But on FreeBSD,
> > the contigmem driver would only zero the contiguous
> > memory regions during initial driver load.
> >
> > DPDK commit b78c91751 eliminated the explicit memset()
> > operation for rte_zmalloc(), which was OK on Linux
> > because the kernel zeroes the pages during app start,
> > but this broke FreeBSD. So this patch explicitly
> > zeroes the pages before they are mmap'd, to ensure
> > equivalent behavior to Linux
>
> Added precision that the bug is seen "when restarting app".
>
> > Fixes: b78c9175118f ("mem: do not zero out memory on zmalloc")
> >
> > Reported-by: Daniel Verkamp <daniel.verkamp@intel.com>
> > Tested-by: Daniel Verkamp <daniel.verkamp@intel.com>
> > Acked-by: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>
> > Signed-off-by: Jim Harris <james.r.harris@intel.com>
>
> Applied, thanks
>
> CC stable@, please pick this important fix in 16.07.
FYI, this patch has been applied to stable branch v16.07.
It hasn't been pushed to http://dpdk.org/browse/dpdk-stable/ yet.
It will be pushed if I get no objections in around TWO days. So
please shutout if you have objections.
Thanks.
--yliu
prev parent reply other threads:[~2016-09-26 8:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20160816224646.1982.50720.stgit@jrharri1-mac>
2016-08-22 20:58 ` Thomas Monjalon
2016-09-26 8:12 ` Yuanhan Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160926081217.GM23158@yliu-dev.sh.intel.com \
--to=yuanhan.liu@linux.intel.com \
--cc=daniel.verkamp@intel.com \
--cc=james.r.harris@intel.com \
--cc=john.mcnamara@intel.com \
--cc=sergio.gonzalez.monroy@intel.com \
--cc=stable@dpdk.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).