From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <yuanhan.liu@linux.intel.com>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by dpdk.org (Postfix) with ESMTP id E2EDF475E
 for <stable@dpdk.org>; Mon, 26 Sep 2016 10:11:53 +0200 (CEST)
Received: from fmsmga006.fm.intel.com ([10.253.24.20])
 by fmsmga104.fm.intel.com with ESMTP; 26 Sep 2016 01:11:50 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.30,398,1470726000"; d="scan'208";a="13185161"
Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.67.162])
 by fmsmga006.fm.intel.com with ESMTP; 26 Sep 2016 01:11:48 -0700
Date: Mon, 26 Sep 2016 16:12:17 +0800
From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: Jim Harris <james.r.harris@intel.com>, stable@dpdk.org,
 "Mcnamara, John" <john.mcnamara@intel.com>,
 Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>,
 Daniel Verkamp <daniel.verkamp@intel.com>
Message-ID: <20160926081217.GM23158@yliu-dev.sh.intel.com>
References: <20160816224646.1982.50720.stgit@jrharri1-mac>
 <4904186.gj4j9rRC36@xps13>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4904186.gj4j9rRC36@xps13>
User-Agent: Mutt/1.5.23 (2014-03-12)
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v2] contigmem: zero all pages
	during mmap
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches for stable branches <stable.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/stable>,
 <mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/stable>,
 <mailto:stable-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 26 Sep 2016 08:11:54 -0000

On Mon, Aug 22, 2016 at 10:58:46PM +0200, Thomas Monjalon wrote:
> 2016-08-16 15:46, Jim Harris:
> > On Linux, all huge pages are zeroed by the kernel before
> > first access by the DPDK application.  But on FreeBSD,
> > the contigmem driver would only zero the contiguous
> > memory regions during initial driver load.
> > 
> > DPDK commit b78c91751 eliminated the explicit memset()
> > operation for rte_zmalloc(), which was OK on Linux
> > because the kernel zeroes the pages during app start,
> > but this broke FreeBSD.  So this patch explicitly
> > zeroes the pages before they are mmap'd, to ensure
> > equivalent behavior to Linux
> 
> Added precision that the bug is seen "when restarting app".
> 
> > Fixes: b78c9175118f ("mem: do not zero out memory on zmalloc")
> > 
> > Reported-by: Daniel Verkamp <daniel.verkamp@intel.com>
> > Tested-by: Daniel Verkamp <daniel.verkamp@intel.com>
> > Acked-by: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>
> > Signed-off-by: Jim Harris <james.r.harris@intel.com>
> 
> Applied, thanks
> 
> CC stable@, please pick this important fix in 16.07.

FYI, this patch has been applied to stable branch v16.07.

It hasn't been pushed to http://dpdk.org/browse/dpdk-stable/ yet.
It will be pushed if I get no objections in around TWO days. So 
please shutout if you have objections.

Thanks.

	--yliu