Re: [dpdk-stable] [dpdk-dev] [PATCH] kni: fix crash for KNI interface remove

[Yuanhan Liu <yuanhan.liu@linux.intel.com>]

On Mon, Sep 26, 2016 at 04:34:07PM +0800, Yuanhan Liu wrote:
> On Fri, Sep 09, 2016 at 03:46:01PM +0200, Thomas Monjalon wrote:
> > 2016-08-31 14:06, Ferruh Yigit:
> > > Removing KNI interface that has no PCI driver for ethtool support cause
> > > kernel crash.
> > > 
> > > Fixes: 109febfe58f9 ("net/igb: move PCI device IDs from EAL")
> > > Fixes: 221fba3b987c ("net/ixgbe: move PCI device IDs from EAL")
> > > 
> > > Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> > 
> > Applied, thanks
> 
> FYI, this patch has been applied to stable branch v16.07.
> 
> It hasn't been pushed to http://dpdk.org/browse/dpdk-stable/ yet.
> It will be pushed if I get no objections in around TWO days. So 
> please shutout if you have objections.

Nah, firstly, it has conflicts. Secondly, it breaks the build even
if I fixed the conflicts.

    lib/librte_eal/linuxapp/kni/kni_misc.c: In function ‘kni_dev_remove’:
    lib/librte_eal/linuxapp/kni/kni_misc.c:370:20: error: ‘ixgbe_pci_tbl’ undeclared (first use in this function)
       if (pci_match_id(ixgbe_pci_tbl, dev->pci_dev))
                        ^
    lib/librte_eal/linuxapp/kni/kni_misc.c:370:20: note: each undeclared identifier is reported only once for each function it appears in
    lib/librte_eal/linuxapp/kni/kni_misc.c:372:25: error: ‘igb_pci_tbl’ undeclared (first use in this function)
       else if (pci_match_id(igb_pci_tbl, dev->pci_dev))
                             ^
    make[10]: *** [lib/librte_eal/linuxapp/kni/kni_misc.o] Error 1
    make[9]: *** [_module_lib/librte_eal/linuxapp/kni] Error 2
    make[8]: *** [sub-make] Error 2
    make[7]: *** [rte_kni.ko] Error 2
    make[6]: *** [kni] Error 2
    make[5]: *** [linuxapp] Error 2
    make[4]: *** [librte_eal] Error 2
    make[3]: *** [lib] Error 2
    make[2]: *** [all] Error 2
    make[1]: *** [pre_install] Error 2
    make: *** [install] Error 2
    

Ferruh, I may need your help here. If you think this patch is a good
candidate for v16.07 stable release, would you mind to back port it?

BTW, I saw quite few KNI fixes have already been applied to master. Would
you help to check which are good for applying them to stable release and
which are not?

    2016-09-22 15:48 Ferruh Yigit       kni: fix large stack frame size
    2016-08-25 12:30 Ferruh Yigit       kni: remove continuous memory restriction
    2016-09-11 17:59 Yangchao Zhou      kni: fix error rollback kernel crash
    2016-09-08 19:32 Ferruh Yigit       kni: fix build with kernel 4.8
    2016-09-16 17:09 Ferruh Yigit       kni: fix build with kernel < 3.0
    2016-09-16 22:01 Pablo de Lara      kni: support RHEL 7.3
    2016-09-15 13:06 Ferruh Yigit       kni: fix debug build
    2016-09-02 18:23 Vincent Guo        kni: fix module init/exit
    2016-08-31 15:49 Ferruh Yigit       kni: support RHEL 6.8
    2016-08-31 14:06 Ferruh Yigit       kni: fix crash when removing interface

So far, I will drop this one temporarily.

	--yliu