From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <yuanhan.liu@linux.intel.com>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by dpdk.org (Postfix) with ESMTP id C02073238
 for <stable@dpdk.org>; Mon, 26 Sep 2016 14:14:50 +0200 (CEST)
Received: from fmsmga005.fm.intel.com ([10.253.24.32])
 by fmsmga104.fm.intel.com with ESMTP; 26 Sep 2016 05:14:50 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.30,399,1470726000"; d="scan'208";a="13303632"
Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.67.162])
 by fmsmga005.fm.intel.com with ESMTP; 26 Sep 2016 05:14:49 -0700
Date: Mon, 26 Sep 2016 20:15:20 +0800
From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dpdk stable <stable@dpdk.org>
Message-ID: <20160926121520.GD20278@yliu-dev.sh.intel.com>
References: <1472648786-32404-1-git-send-email-ferruh.yigit@intel.com>
 <6154238.UfqKImgbgb@xps13>
 <20160926083407.GA20278@yliu-dev.sh.intel.com>
 <2d1d852b-f124-e939-3b2a-7979fcc5f79e@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <2d1d852b-f124-e939-3b2a-7979fcc5f79e@intel.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] kni: fix crash for KNI
	interface remove
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches for stable branches <stable.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/stable>,
 <mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/stable>,
 <mailto:stable-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 26 Sep 2016 12:14:51 -0000

On Mon, Sep 26, 2016 at 10:21:12AM +0100, Ferruh Yigit wrote:
> On 9/26/2016 9:34 AM, Yuanhan Liu wrote:
> > On Fri, Sep 09, 2016 at 03:46:01PM +0200, Thomas Monjalon wrote:
> >> 2016-08-31 14:06, Ferruh Yigit:
> >>> Removing KNI interface that has no PCI driver for ethtool support cause
> >>> kernel crash.
> >>>
> >>> Fixes: 109febfe58f9 ("net/igb: move PCI device IDs from EAL")
> >>> Fixes: 221fba3b987c ("net/ixgbe: move PCI device IDs from EAL")
> >>>
> >>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> >>
> >> Applied, thanks
> > 
> > FYI, this patch has been applied to stable branch v16.07.
> > 
> > It hasn't been pushed to http://dpdk.org/browse/dpdk-stable/ yet.
> > It will be pushed if I get no objections in around TWO days. So 
> > please shutout if you have objections.
> 
> If the patches mentioned in Fixes line applied to stable branch, this
> one also should be applied.

Thanks for the response.

It might address the conflict issue, but with a simple glimpse, the
build issue might still remain. Say, commit 109febfe58f9 ("net/igb: move
PCI device IDs from EAL") will not be applied (as there is no fixline),
but it is required by commit 5544a453b4ac ("kni: fix crash when removing
interface"), if I'm not mistaken.

Or, I'm wrong?

	--yliu