From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 246122BA6 for ; Tue, 27 Sep 2016 08:28:12 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga105.fm.intel.com with ESMTP; 26 Sep 2016 23:28:11 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,403,1470726000"; d="scan'208";a="1036979087" Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.67.162]) by orsmga001.jf.intel.com with ESMTP; 26 Sep 2016 23:28:10 -0700 Date: Tue, 27 Sep 2016 14:28:38 +0800 From: Yuanhan Liu To: Gowrishankar Cc: dpdk stable , Chao Zhu , Cristian Dumitrescu , Pradeep Message-ID: <20160927062838.GF25823@yliu-dev.sh.intel.com> References: <1ba7bc01d7083769a7b1bd1417efdf6b94b8ae5b.1473349652.git.gowrishankar.m@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1ba7bc01d7083769a7b1bd1417efdf6b94b8ae5b.1473349652.git.gowrishankar.m@linux.vnet.ibm.com> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v7 8/9] ip_pipeline: fix lcore mapping for varying SMT threads as in ppc64 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Sep 2016 06:28:13 -0000 On Thu, Sep 08, 2016 at 10:18:10PM +0530, Gowrishankar wrote: > From: Gowrishankar Muthukrishnan > > This patch fixes ip_pipeline panic in app_init_core_map while preparing cpu > core map in powerpc with SMT off. cpu_core_map_compute_linux currently prepares > core mapping based on file existence in sysfs ie. > > /sys/devices/system/cpu/cpu/topology/physical_package_id > /sys/devices/system/cpu/cpu/topology/core_id > > These files do not exist for lcores which are offline for any reason (as in > powerpc, while SMT is off). In this situation, this function should further > continue preparing map for other online lcores instead of returning with -1 > for a first unavailable lcore. > > Also, in SMT=off scenario for powerpc, lcore ids can not be always indexed from > 0 upto 'number of cores present' (/sys/devices/system/cpu/present). For eg, for > an online lcore 32, core_id returned in sysfs is 112 where online lcores are > 10 (as in one configuration), hence sysfs lcore id can not be checked with > indexing lcore number before positioning lcore map array. > > Signed-off-by: Gowrishankar Muthukrishnan > Acked by: Cristian Dumitrescu > Acked-by: Chao Zhu FYI, this patch has been applied to stable branch v16.07. It hasn't been pushed to http://dpdk.org/browse/dpdk-stable/ yet. It will be pushed if I get no objections in around TWO days. So please shutout if you have objections. Thanks. --yliu