From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 86F292BA6 for ; Tue, 27 Sep 2016 08:30:24 +0200 (CEST) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga104.fm.intel.com with ESMTP; 26 Sep 2016 23:30:25 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,403,1470726000"; d="scan'208";a="14082789" Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.67.162]) by orsmga004.jf.intel.com with ESMTP; 26 Sep 2016 23:30:22 -0700 Date: Tue, 27 Sep 2016 14:30:50 +0800 From: Yuanhan Liu To: Weiliang Luo Cc: dpdk stable , Olivier Matz Message-ID: <20160927063050.GG25823@yliu-dev.sh.intel.com> References: <1473348597-11904-1-git-send-email-droidluo@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1473348597-11904-1-git-send-email-droidluo@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] mempool: fix corruption due to invalid handler X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Sep 2016 06:30:24 -0000 On Thu, Sep 08, 2016 at 10:29:57AM -0500, Weiliang Luo wrote: > When using rte_mempool_create(), the mempool handler is selected > depending on the flags given by the user: > - multi-consumer / multi-producer > - multi-consumer / single-producer > - single-consumer / multi-producer > - single-consumer / single-producer > > The flags were not properly tested, resulting in the selection of sc/sp > handler if sc/mp or mc/sp was asked. This can lead to corruption or > crashes because the get/put operations are not atomic. > > Fixes: 449c49b93a6b ("mempool: support handler operations") > > Signed-off-by: Weiliang Luo > Acked-by: Olivier Matz FYI, this patch has been applied to stable branch v16.07. It hasn't been pushed to http://dpdk.org/browse/dpdk-stable/ yet. It will be pushed if I get no objections in around TWO days. So please shutout if you have objections. Thanks. --yliu