patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: Christian Ehrhardt <christian.ehrhardt@canonical.com>
Cc: "Mcnamara, John" <john.mcnamara@intel.com>,
	"stable@dpdk.org" <stable@dpdk.org>,
	Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [dpdk-stable] Release note for the stable/lts releases
Date: Mon, 10 Oct 2016 15:52:29 +0800	[thread overview]
Message-ID: <20161010075229.GJ10323@yliu-dev.sh.intel.com> (raw)
In-Reply-To: <CAATJJ0KLqcr=RBRipNRetxisEhMZqSTYdA9S7Sw9C=PzO=ffDw@mail.gmail.com>

On Thu, Sep 29, 2016 at 07:29:58PM +0200, Christian Ehrhardt wrote:
> 
> On Thu, Sep 29, 2016 at 6:39 PM, Mcnamara, John <john.mcnamara@intel.com>
> wrote:
> 
>     Does that seem okay to everyone?
> 
> 
> Seems ok to me at least :-)

+1

> Out of backport experience sometimes it is almost more interesting to cover
> which ones where not applied and a one liner why.
> So if some patch made it to qualify to be looked at, but then be rejected it
> would be great to show up in a list:
> 
>     The following fixes were NOT applied in DPDK 16.07.01 Stable Release:
> 
>     * examples: fix very-very-unusual-interpreter; Reason: too unusual to
> happen

Hmm, is it an example to show rejected patches only? Or, do you actually
mean we should not apply it to stable branch? If so, I'm just wondering
why haven't you stated that while I sent out for comments before.

> 
> Also I'd pretty much like to get a commit id of the original patch in that
> list, so
>     * kni: fix crash when removing interface
> would be
>     * [5544a453] kni: fix crash when removing interface
> 
> What about these suggestions?

Does that matter? I mean, why we should put it in the release note?

OTOH, I have included the original commit info while cherry-pick it from
upstream. For example,

---
commit 6f55e57db50b1729c33a011eafc7704753cb8860
Author: Ferruh Yigit <ferruh.yigit@intel.com>
Date:   Wed Aug 31 17:48:48 2016 +0100

    app/testpmd: fix help of MTU set commmand

    [ upstream commit b2fbb98789d4e7311a415052897d98b6850861de ]

    Fixes: ae03d0d18adf ("app/testpmd: command to configure MTU")

    Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
    Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>

diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index f90befc..17d238f 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -1367,7 +1367,7 @@ cmdline_parse_token_num_t cmd_config_mtu_value =
 cmdline_parse_inst_t cmd_config_mtu = {
        .f = cmd_config_mtu_parsed,
        .data = NULL,
-       .help_str = "port config mtu value",
+       .help_str = "port config mtu port_id value",
        .tokens = {
                (void *)&cmd_config_mtu_port,
                (void *)&cmd_config_mtu_keyword,


	--yliu

  reply	other threads:[~2016-10-10  7:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-29 16:39 Mcnamara, John
2016-09-29 17:29 ` Christian Ehrhardt
2016-10-10  7:52   ` Yuanhan Liu [this message]
2016-10-10  8:27     ` Christian Ehrhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161010075229.GJ10323@yliu-dev.sh.intel.com \
    --to=yuanhan.liu@linux.intel.com \
    --cc=christian.ehrhardt@canonical.com \
    --cc=john.mcnamara@intel.com \
    --cc=stable@dpdk.org \
    --cc=thomas.monjalon@6wind.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).