* [dpdk-stable] Reviewing currently queued patches @ 2016-10-12 8:13 Christian Ehrhardt 2016-10-12 10:24 ` Yuanhan Liu 0 siblings, 1 reply; 5+ messages in thread From: Christian Ehrhardt @ 2016-10-12 8:13 UTC (permalink / raw) To: stable, Yuanhan Liu Hi Yliu, First of all thanks for your work on the stable Tree! I usually flag patches that come by and I find interesting for backporting for myself. Since the "new" stable-tree was announced I replied on some of those threads to stable@dpdk.org to be considered. I did not at all try to have a complete list, but wanted to track the few I had. Since your mails today appeared to me to be the complete list of your first batch of stable patches I checked it vs my list. That way I found a few that I wanted to inquire about. The first category are patches that likely are already considered by you. Those patches already got the "this is enqueued for stable" reply onto their patch submission mail thread. But the deadline you set back then expired and they are not yet in the stable tree so I at least wanted to ask. 24427bb914a6375f29635897d23a3192d85b2127 app/testpmd: fix crash when mempool allocation fails e15922d75a8226a0a5af97d39a9f15a2e6163e9d mempool: fix corruption due to invalid handler The second type are fixes that have a "fixes" statement matching code that is in 16.07 and might be missing in your current list: c00ae961ff8dbc036322fdb41137a7dedac005c9 mem: fix crash on hugepage mapping error 6edfa69ba6fe86e9f59c76d0bb3732c558aeedc9 pci: fix memory leak when detaching device 7b3c4f351708a4bf5d311266d9f8c32e5704701f sched: fix releasing enqueued packets 33a290899dd2b6e2e26e8e5c33d08979f8315d18 net/virtio_user: fix first queue pair without multiqueue It would be nice if you could let us know if they are intentionally not included, just not processed yet or whatever else that had not made them part of your batch submission today. To some extend that was why I asked before for a list of "intentionally not included fixes along with the reason", but for now the diff is small enough that you can just reply here on those 4 (6) patches. Kind Regards, -- Christian Ehrhardt Software Engineer, Ubuntu Server Canonical Ltd ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-stable] Reviewing currently queued patches 2016-10-12 8:13 [dpdk-stable] Reviewing currently queued patches Christian Ehrhardt @ 2016-10-12 10:24 ` Yuanhan Liu 2016-10-12 10:56 ` Yuanhan Liu 0 siblings, 1 reply; 5+ messages in thread From: Yuanhan Liu @ 2016-10-12 10:24 UTC (permalink / raw) To: Christian Ehrhardt; +Cc: stable On Wed, Oct 12, 2016 at 10:13:24AM +0200, Christian Ehrhardt wrote: > Hi Yliu, > > First of all thanks for your work on the stable Tree! > > I usually flag patches that come by and I find interesting for backporting for > myself. I also did some flags, but it's hard to be complete. The way I do it now is to look all commits in the master branch, and pick some that looks good to be picked for stable release. I would hope more and more people would add "Cc: <stable@dpdk.org>" inside the commit log in future. With that, most of them could be automated by some simple. scripts. It's just a first trial, a lot people are still not aware of that. But I'm sure we will get better and better as time move forwards. > Since the "new" stable-tree was announced I replied on some of those threads to > stable@dpdk.org to be considered. I did not at all try to have a complete list, > but wanted to track the few I had. Thanks for doing that! Yes, I could be mistaken somewhere. It would be great if you could spend some time to some more checkings. Appreciate that! > Since your mails today appeared to me to be the complete list of your first > batch of stable patches I checked it vs my list. Yes, that should be final list for the first stable release. And I plan to make a review-announce this Friday, for aksing reviews and testing. After that, v16.07.1 will be released. > That way I found a few that I > wanted to inquire about. > > The first category are patches that likely are already considered by you. > Those patches already got the "this is enqueued for stable" reply onto their > patch submission mail thread. But the deadline you set back then expired and > they are not yet in the stable tree so I at least wanted to ask. My bad, and apologize again that I was late. I was on vacation. I pushed them after the vacation. You can find them here: http://dpdk.org/browse/dpdk-stable/log/?h=16.07 For this round, I'm sure I will do it in time: before the end of this Friday. > > 24427bb914a6375f29635897d23a3192d85b2127 app/testpmd: fix crash when mempool > allocation fails > e15922d75a8226a0a5af97d39a9f15a2e6163e9d mempool: fix corruption due to invalid > handler They are there; already pushed. > > The second type are fixes that have a "fixes" statement matching code that is > in 16.07 and might be missing in your current list: > c00ae961ff8dbc036322fdb41137a7dedac005c9 mem: fix crash on hugepage mapping > error > 6edfa69ba6fe86e9f59c76d0bb3732c558aeedc9 pci: fix memory leak when detaching > device > 7b3c4f351708a4bf5d311266d9f8c32e5704701f sched: fix releasing enqueued packets > 33a290899dd2b6e2e26e8e5c33d08979f8315d18 net/virtio_user: fix first queue pair > without multiqueue Besides the the 3rd one (sched: fix releasing ...), all others are actually included in this list I sent out today. You failed to get those mail notifications? FYI, I got them. BTW, thanks for the good catch! I will include the missing one soon. --yliu > It would be nice if you could let us know if they are intentionally not > included, just not processed yet or whatever else that had not made them part > of your batch submission today. > > To some extend that was why I asked before for a list of "intentionally not > included fixes along with the reason", but for now the diff is small enough > that you can just reply here on those 4 (6) patches. > > Kind Regards, > > -- > Christian Ehrhardt > Software Engineer, Ubuntu Server > Canonical Ltd ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-stable] Reviewing currently queued patches 2016-10-12 10:24 ` Yuanhan Liu @ 2016-10-12 10:56 ` Yuanhan Liu 2016-10-12 11:37 ` Christian Ehrhardt 0 siblings, 1 reply; 5+ messages in thread From: Yuanhan Liu @ 2016-10-12 10:56 UTC (permalink / raw) To: Christian Ehrhardt; +Cc: stable On Wed, Oct 12, 2016 at 06:24:42PM +0800, Yuanhan Liu wrote: > > The second type are fixes that have a "fixes" statement matching code that is > > in 16.07 and might be missing in your current list: > > c00ae961ff8dbc036322fdb41137a7dedac005c9 mem: fix crash on hugepage mapping > > error > > 6edfa69ba6fe86e9f59c76d0bb3732c558aeedc9 pci: fix memory leak when detaching > > device > > 7b3c4f351708a4bf5d311266d9f8c32e5704701f sched: fix releasing enqueued packets > > 33a290899dd2b6e2e26e8e5c33d08979f8315d18 net/virtio_user: fix first queue pair > > without multiqueue > > Besides the the 3rd one (sched: fix releasing ...), all others are > actually included in this list I sent out today. You failed to get > those mail notifications? FYI, I got them. > > BTW, thanks for the good catch! I will include the missing one soon. FYI, here is the list I got for v16.07.1 release (excluding the first batch): [yliu@yliu-dev ~/stable]$ QUILT_PATCHES=16.07.1 quilt series | nl 1 16.07.1/0001-sched-fix-releasing-enqueued-packets.patch 2 16.07.1/0001-crypto-fix-build-with-icc.patch 3 16.07.1/0001-app-test-fix-verification-of-digest-for-GCM.patch 4 16.07.1/0001-crypto-qat-fix-FreeBSD-build.patch 5 16.07.1/0001-crypto-null-fix-key-size-increment-value.patch 6 16.07.1/0001-mem-fix-build-with-O1.patch 7 16.07.1/0001-net-ixgbe-base-fix-skipping-PHY-config.patch 8 16.07.1/0001-net-ixgbe-base-fix-possible-corruption-of-shadow-RAM.patch 9 16.07.1/0001-net-ixgbe-base-fix-check-for-NACK.patch 10 16.07.1/0001-net-ixgbe-base-fix-pointer-check.patch 11 16.07.1/0001-net-enic-fix-freeing-memory-for-descriptor-ring.patch 12 16.07.1/0001-net-i40e-base-fix-UDP-packet-header.patch 13 16.07.1/0001-net-i40e-fix-parsing-QinQ-packets-type.patch 14 16.07.1/0001-net-i40e-fix-null-pointer-dereferences-when-using-VM.patch 15 16.07.1/0001-net-ixgbe-fix-VF-reset-to-apply-to-correct-VF.patch 16 16.07.1/0001-net-i40e-fix-dropping-packets-with-ethertype-0x88A8.patch 17 16.07.1/0001-net-enic-fix-bad-L4-checksum-flag-on-ICMP-packets.patch 18 16.07.1/0001-net-fm10k-fix-MAC-address-removal-from-switch.patch 19 16.07.1/0001-net-pcap-fix-memory-leak-in-jumbo-frames.patch 20 16.07.1/0001-net-nfp-fix-copying-MAC-address.patch 21 16.07.1/0001-net-mlx-fix-debug-build-with-gcc-6.1.patch 22 16.07.1/0001-net-e1000-fix-returned-number-of-available-Rx-descri.patch 23 16.07.1/0001-net-i40e-fix-mbuf-leak-during-Rx-queue-release.patch 24 16.07.1/0001-net-ixgbe-fix-mbuf-leak-during-Rx-queue-release.patch 25 16.07.1/0001-mbuf-fix-error-handling-on-pool-creation.patch 26 16.07.1/0001-timer-fix-lag-delay.patch 27 16.07.1/0001-net-virtio_user-fix-error-management-during-init.patch 28 16.07.1/0001-net-virtio_user-fix-wrong-sequence-of-messages.patch 29 16.07.1/0001-net-virtio_user-fix-first-queue-pair-without-multiqu.patch 30 16.07.1/0001-tools-fix-virtio-interface-name-when-binding.patch 31 16.07.1/0001-net-virtio-fix-xstats-name.patch 32 16.07.1/0001-tools-fix-json-output-of-pmdinfo.patch 33 16.07.1/0001-pmdinfogen-fix-clang-build.patch 34 16.07.1/0001-pci-fix-memory-leak-when-detaching-device.patch 35 16.07.1/0001-mem-fix-crash-on-hugepage-mapping-error.patch 36 16.07.1/0001-hash-fix-false-zero-signature-key-hit-lookup.patch 37 16.07.1/0001-hash-fix-ring-size.patch Please shut if you find something are missing (including those you failed to receive). Thanks. --yliu ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-stable] Reviewing currently queued patches 2016-10-12 10:56 ` Yuanhan Liu @ 2016-10-12 11:37 ` Christian Ehrhardt 2016-10-12 11:54 ` Yuanhan Liu 0 siblings, 1 reply; 5+ messages in thread From: Christian Ehrhardt @ 2016-10-12 11:37 UTC (permalink / raw) To: Yuanhan Liu; +Cc: stable Thanks, I think I'm good for now. One more thing - since they are all "0001" from the format patch that id is rather meaningless. Having the 8 char original patch hash there would make that list awesome. For a super bonus it could be abcdef12-fixes-21fedcba-text-title.patch But if not things are fine as well. On Wed, Oct 12, 2016 at 12:56 PM, Yuanhan Liu <yuanhan.liu@linux.intel.com> wrote: > Please shut if you find something > ok ok - I shut (up) now :-P -- Christian Ehrhardt Software Engineer, Ubuntu Server Canonical Ltd ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-stable] Reviewing currently queued patches 2016-10-12 11:37 ` Christian Ehrhardt @ 2016-10-12 11:54 ` Yuanhan Liu 0 siblings, 0 replies; 5+ messages in thread From: Yuanhan Liu @ 2016-10-12 11:54 UTC (permalink / raw) To: Christian Ehrhardt; +Cc: stable On Wed, Oct 12, 2016 at 01:37:02PM +0200, Christian Ehrhardt wrote: > Thanks, > I think I'm good for now. Great! > One more thing - since they are all "0001" from the format patch that id is > rather meaningless. Yes, but they are just local in my system. You won't see that in the email notification. > Having the 8 char original patch hash there would make that list awesome. > For a super bonus it could be abcdef12-fixes-21fedcba-text-title.patch Again, it's just a local list. I don't think it matter how it looks like. Besides that, one patch could have serveal fixlines, in such case, abcdef12-fixes-21fedcba-31fedcba-... would be ugly, don't you think? The final list sent out for review would be basically a run of "git shortlog", something like: --- Alejandro Lucero (1): net/nfp: fix copying MAC address Aleksey Katargin (1): table: fix symbol exports Alex Zelezniak (1): net/ixgbe: fix VF reset to apply to correct VF Ali Volkan Atli (1): net/e1000: fix returned number of available Rx descriptors Arek Kusztal (1): app/test: fix verification of digest for GCM Beilei Xing (2): net/i40e: fix dropping packets with ethertype 0x88A8 net/i40e: fix parsing QinQ packets type Bruce Richardson (1): net/mlx: fix debug build with gcc 6.1 Christian Ehrhardt (1): examples/ip_pipeline: fix Python interpreter Deepak Kumar Jain (2): crypto/null: fix key size increment value crypto/qat: fix FreeBSD build Dror Birkman (1): net/pcap: fix memory leak in jumbo frames Ferruh Yigit (2): app/testpmd: fix help of MTU set commmand pmdinfogen: fix clang build Gary Mussar (1): tools: fix virtio interface name when binding Gowrishankar Muthukrishnan (1): examples/ip_pipeline: fix lcore mapping for ppc64 Hiroyuki Mikita (1): sched: fix releasing enqueued packets James Poole (1): app/testpmd: fix timeout in Rx queue flushing Jianfeng Tan (3): net/virtio_user: fix first queue pair without multiqueue net/virtio_user: fix wrong sequence of messages net/virtio_user: fix error management during init Jim Harris (1): contigmem: zero all pages during mmap John Daley (1): net/enic: fix bad L4 checksum flag on ICMP packets Karmarkar Suyash (1): timer: fix lag delay Maciej Czekaj (1): mem: fix crash on hugepage mapping error Nelson Escobar (1): net/enic: fix freeing memory for descriptor ring Olivier Matz (4): app/testpmd: fix crash when mempool allocation fails tools: fix json output of pmdinfo mbuf: fix error handling on pool creation mem: fix build with -O1 Pablo de Lara (3): hash: fix ring size hash: fix false zero signature key hit lookup crypto: fix build with icc Qi Zhang (1): net/i40e/base: fix UDP packet header Rich Lane (1): net/i40e: fix null pointer dereferences when using VMDq+RSS Weiliang Luo (1): mempool: fix corruption due to invalid handler Xiao Wang (5): net/fm10k: fix MAC address removal from switch net/ixgbe/base: fix pointer check net/ixgbe/base: fix check for NACK net/ixgbe/base: fix possible corruption of shadow RAM net/ixgbe/base: fix skipping PHY config Yangchao Zhou (1): pci: fix memory leak when detaching device Yury Kylulin (2): net/ixgbe: fix mbuf leak during Rx queue release net/i40e: fix mbuf leak during Rx queue release Zhiyong Yang (1): net/virtio: fix xstats name It still doesn't include the commit info though. > But if not things are fine as well. > > On Wed, Oct 12, 2016 at 12:56 PM, Yuanhan Liu <yuanhan.liu@linux.intel.com> > wrote: > > Please shut if you find something > > > ok ok - I shut (up) now :-P Oops... sorry, I meant "shout" ... :( --yliu ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-10-12 11:53 UTC | newest] Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2016-10-12 8:13 [dpdk-stable] Reviewing currently queued patches Christian Ehrhardt 2016-10-12 10:24 ` Yuanhan Liu 2016-10-12 10:56 ` Yuanhan Liu 2016-10-12 11:37 ` Christian Ehrhardt 2016-10-12 11:54 ` Yuanhan Liu
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).