From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id B60056CC3; Wed, 19 Oct 2016 11:55:29 +0200 (CEST) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga101.fm.intel.com with ESMTP; 19 Oct 2016 02:55:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,514,1473145200"; d="scan'208";a="21161338" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.210.138]) by fmsmga006.fm.intel.com with SMTP; 19 Oct 2016 02:55:26 -0700 Received: by (sSMTP sendmail emulation); Wed, 19 Oct 2016 10:55:25 +0100 Date: Wed, 19 Oct 2016 10:55:25 +0100 From: Bruce Richardson To: Declan Doherty Cc: Ilya Maximets , dev@dpdk.org, Heetae Ahn , Yuanhan Liu , Eric Kinzie , Bernard Iremonger , stable@dpdk.org Message-ID: <20161019095525.GK27816@bricha3-MOBL3.ger.corp.intel.com> References: <1473251290-22053-1-git-send-email-i.maximets@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?= =?iso-8859-1?Q?opment?= Ireland Ltd. User-Agent: Mutt/1.7.1 (2016-10-04) Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] Revert "bonding: use existing enslaved device queues" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Oct 2016 09:55:30 -0000 On Thu, Oct 06, 2016 at 03:32:36PM +0100, Declan Doherty wrote: > On 07/09/16 13:28, Ilya Maximets wrote: > > This reverts commit 5b7bb2bda5519b7800f814df64d4e015282140e5. > > > > It is necessary to reconfigure all queues every time because configuration > > can be changed. > > > > Hey Ilya, this makes sense. I guess this was my original intention but I > missed this case in my review of the change. > > > For example, if we're reconfiguring bonding device with new memory pool, > > already configured queues will still use the old one. And if the old > > mempool be freed, application likely will panic in attempt to use > > freed mempool. > > > > This happens when we use the bonding device with OVS 2.6 while MTU > > reconfiguration: > > > > PANIC in rte_mempool_get_ops(): > > assert "(ops_index >= 0) && (ops_index < RTE_MEMPOOL_MAX_OPS_IDX)" failed > > > > Cc: > > Signed-off-by: Ilya Maximets > > --- > > Acked-by: Declan Doherty Applied to dpdk-next-net/rel_16_11 /Bruce