From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 9E92D12A8 for ; Thu, 24 Nov 2016 05:32:57 +0100 (CET) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga105.fm.intel.com with ESMTP; 23 Nov 2016 20:32:56 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,690,1473145200"; d="scan'208";a="35082881" Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.67.162]) by fmsmga006.fm.intel.com with ESMTP; 23 Nov 2016 20:32:55 -0800 Date: Thu, 24 Nov 2016 12:33:43 +0800 From: Yuanhan Liu To: Qiming Yang Cc: stable@dpdk.org Message-ID: <20161124043343.GN16151@yliu-dev.sh.intel.com> References: <1479950918-59595-1-git-send-email-qiming.yang@intel.com> <1479950918-59595-2-git-send-email-qiming.yang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1479950918-59595-2-git-send-email-qiming.yang@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-stable] [PATCH v2 2/2] net/i40e: fix VF bonded device link down X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Nov 2016 04:32:58 -0000 On Thu, Nov 24, 2016 at 09:28:38AM +0800, Qiming Yang wrote: > [ backported from upstream commit bb6722fb5c0eae07ab3a6566298df2d6028e1cf9 ] > > If VF device is used as slave of a bond device, it will be polled > periodically through alarm. Interrupt is involved here. And then > VF will send I40E_VIRTCHNL_OP_GET_LINK_STAT message to > PF to query the status. The response is handled by interrupt > callback. Interrupt is involved here again. That's why bond > device cannot bring up. > > This patch removes I40E_VIRTCHNL_OP_GET_LINK_STAT > message. Link status in VF driver will be updated when PF driver > notify it, and VF stores this link status locally. VF driver just > returns the local status when being required. > > Fixes: 4861cde46116 ("i40e: new poll mode driver") > > Signed-off-by: Qiming Yang > --- > v2 changes: > * fixed the build error That's still not right. I have said that I have already applied your two patches, that you should send the fix __only__ on top of the 16.07 __branch__ of the stable tree. I compared with this patch and the one I have applied, here I got the diff: --- diff --git a/drivers/net/i40e/i40e_pf.c b/drivers/net/i40e/i40e_pf.c index 350f6a0..92c91b4 100644 --- a/drivers/net/i40e/i40e_pf.c +++ b/drivers/net/i40e/i40e_pf.c @@ -904,9 +904,9 @@ i40e_notify_vf_link_status(struct rte_eth_dev *dev, struct i40e_pf_vf *vf) event.event = I40E_VIRTCHNL_EVENT_LINK_CHANGE; event.event_data.link_event.link_status = - dev->data->dev_link.link_status; + dev->data->dev_link.link_status; event.event_data.link_event.link_speed = - dev->data->dev_link.link_speed; + (enum i40e_aq_link_speed)dev->data->dev_link.link_speed; i40e_pf_host_send_msg_to_vf(vf, I40E_VIRTCHNL_OP_EVENT, I40E_SUCCESS, (uint8_t *)&event, sizeof(event)); } That's the patch you need to send out. One more comment: it's obvious that you have backported the patch is a wrong way: we should not be able to see above two changes with a proper backport. --yliu