From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f53.google.com (mail-wm0-f53.google.com [74.125.82.53]) by dpdk.org (Postfix) with ESMTP id 33ABFF919 for ; Thu, 5 Jan 2017 17:52:31 +0100 (CET) Received: by mail-wm0-f53.google.com with SMTP id c85so253651000wmi.1 for ; Thu, 05 Jan 2017 08:52:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=hL0eTrkIr+mNRFOtOc3RZ3n6zumJO/ppWJaR0QiNZ68=; b=aaZHpM/JrFHXvrgJKQ/885VUiX31jfHqNDHFGDIx9Q+u9THkHpBdSzuP9SY+gbTTvk AxHt5RgdmNcrfBKTcENzAtW2VMMK57gJtC3JQcxM2GUoLsZ6l/DzibTkhP4xC+O4OJ/H bdNvVpmutMO678r2owuegkpZ2opsJNbqaUzI0O+F9Wnft2RxMO5HfDwavpvSTys+tIGR iHd8yLdfxvBSdYpvrR/t1FVy31PtifkhqBWTsmWC/aY61bIKnMFesis1MhcM9GoEMFcR kCOv06xoiWPOKXyVeG05wLeRwvbHhsuGtqbKSx/Ue6bVC2q1sarWoD38p2ZnwRlwvDuM lJJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=hL0eTrkIr+mNRFOtOc3RZ3n6zumJO/ppWJaR0QiNZ68=; b=i89TayOmjFeQ7i21eScIf45RQ5cR3aiu5RBiVExUtUtYvc2WtYrp76z9g2fOgC/5k2 5ZCe8n3wNpv+Msm122iEauEXho6khyM/T1lc4Ger24Vsj1Fcj7pWeHUxT+gUlne/M0pJ +4WkfY1sL0HmTfWYNV7gqWc6E10aDr2FEx0yrQuUIhSQ+uNM/MLw8LfWH2F9cjROFHoU sgOoW7IQUEm672xJFdqI+OCG4+agdSa5qvGuFE9F+yc5UrGkVhYSCPsaibEgh1YjX7Sa 3bn61F8+1eLkGAVfFZbsO+YsGRAayCktilnKHPc55wd1yaV0MVE1hU8hPwyp01+NqHg/ wojA== X-Gm-Message-State: AIkVDXKftZv/3vSrqDXoaJHeT757MI+XMKAnmidt2b4qPyCHq/krR9wPrGZ4vemJaXUR8dA9 X-Received: by 10.28.145.2 with SMTP id t2mr55061212wmd.23.1483635150788; Thu, 05 Jan 2017 08:52:30 -0800 (PST) Received: from 6wind.com (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by smtp.gmail.com with ESMTPSA id l74sm100994341wmg.2.2017.01.05.08.52.29 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 05 Jan 2017 08:52:29 -0800 (PST) Date: Thu, 5 Jan 2017 17:52:23 +0100 From: Adrien Mazarguil To: Ferruh Yigit Cc: Nelio Laranjeiro , dev@dpdk.org, stable@dpdk.org Message-ID: <20170105165223.GQ12822@6wind.com> References: <1481290078-4530-1-git-send-email-nelio.laranjeiro@6wind.com> <2da35386-f774-a1ca-c4f2-cc77f74f6e2c@intel.com> <20170105163226.GP12822@6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170105163226.GP12822@6wind.com> Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] net/mlx5: fix Tx doorbell X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Jan 2017 16:52:31 -0000 On Thu, Jan 05, 2017 at 05:32:26PM +0100, Adrien Mazarguil wrote: > Hi Ferruh, > > On Thu, Jan 05, 2017 at 03:19:35PM +0000, Ferruh Yigit wrote: > > On 12/9/2016 1:27 PM, Nelio Laranjeiro wrote: > > > Too much data is uselessly written to the Tx doorbell. > > > > > > Fixes: 1d88ba171942 ("net/mlx5: refactor Tx data path") > > > > > > Signed-off-by: Nelio Laranjeiro > > > Acked-by: Adrien Mazarguil > > > > > > > Applied to dpdk-next-net/master, thanks. > > > > Is not CC'ing stable intentional, since this patch depends on a patch > > introduced in this release? If not intentional, please CC stable. > > I intended to update the commit message for this patch as in the meantime we > discovered it addresses a significant regression introduced in v16.11. > > CC'ing stable now. > > If possible, can you amend the commit log with: > > --- > > net/mlx5: fix Tx doorbell > > Too much data is uselessly written to the Tx doorbell, which since v16.11 > may also cause Tx queues to behave erratically and crash applications. > > This regression was seen on VF devices when the BlueFlame buffer size is > zero (txq->cqe_n == 0) due to the following change: > > - cqe = &(*txq->cqes)[ci & (txq->cqe_n - 1)].cqe64; > + cqe = &(*txq->cqes)[ci & ((1 << txq->cqe_n) - 1)]; > > Fixes: 1d88ba171942 ("net/mlx5: refactor Tx data path") > Fixes: e2f116ee3cac ("net/mlx5: reduce memory overhead for CQE handling") > > Signed-off-by: Nelio Laranjeiro > Acked-by: Adrien Mazarguil > Cc: stable@dpdk.org > > --- I mixed the commit that introduced the regression with a similar looking yet harmless one, here is the proper message to use, sorry for the noise: --- net/mlx5: fix Tx doorbell Too much data is uselessly written to the Tx doorbell, which since v16.11 may also cause Tx queues to behave erratically and crash applications. This regression was seen on VF devices when the BlueFlame buffer size is zero (txq->bf_buf_size) due to the following change: - txq->bf_offset ^= txq->bf_buf_size; + txq->bf_offset ^= (1 << txq->bf_buf_size); Fixes: 1d88ba171942 ("net/mlx5: refactor Tx data path") Fixes: d5793daefec8 ("net/mlx5: reduce memory overhead for BF handling") Signed-off-by: Nelio Laranjeiro Acked-by: Adrien Mazarguil Cc: stable@dpdk.org --- -- Adrien Mazarguil 6WIND