From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 3267A152A; Mon, 9 Jan 2017 06:17:35 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga104.fm.intel.com with ESMTP; 08 Jan 2017 21:17:34 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,339,1477983600"; d="scan'208";a="806613276" Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.67.162]) by FMSMGA003.fm.intel.com with ESMTP; 08 Jan 2017 21:17:33 -0800 Date: Mon, 9 Jan 2017 13:19:19 +0800 From: Yuanhan Liu To: Stephen Hemminger Cc: dev@dpdk.org, stable@dpdk.org, "Xu, Qian Q" , "Liu, Yong" Message-ID: <20170109051919.GB21228@yliu-dev.sh.intel.com> References: <1482922962-21036-1-git-send-email-yuanhan.liu@linux.intel.com> <1483697780-12088-1-git-send-email-yuanhan.liu@linux.intel.com> <1483697780-12088-3-git-send-email-yuanhan.liu@linux.intel.com> <20170108151500.3272484c@xeon-e3> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170108151500.3272484c@xeon-e3> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v3 2/6] net/virtio: fix wrong Rx/Tx method for secondary process X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Jan 2017 05:17:36 -0000 On Sun, Jan 08, 2017 at 03:15:00PM -0800, Stephen Hemminger wrote: > On Fri, 6 Jan 2017 18:16:16 +0800 > Yuanhan Liu wrote: > > > If the primary enables the vector Rx/Tx path, the current code would > > let the secondary always choose the non vector Rx/Tx path. This results > > to a Rx/Tx method mismatch between primary and secondary process. Werid > > errors then may happen, something like: > > > > PMD: virtio_xmit_pkts() tx: virtqueue_enqueue error: -14 > > > > Fix it by choosing the correct Rx/Tx callbacks for the secondary process. > > That is, use vector path if it's given. > > > > Fixes: 8d8393fb1861 ("virtio: pick simple Rx/Tx") > > > > Cc: stable@dpdk.org > > Signed-off-by: Yuanhan Liu > > This is failing on intel compile tests. > > > http://dpdk.org/patch/18975 Thanks, but it looks like a false alarm to me, for reasons below. > Failed Build #2: > OS: RHEL7.2_64 > Target: x86_64-native-linuxapp-gcc > MKRES test_resource_c.res.o /home/patchWorkOrg/compilation/x86_64-native-linuxapp-gcc/lib/librte_ethdev.a(rte_ethdev.o): In function `rte_eth_dev_pci_probe': > rte_ethdev.c:(.text+0x9c4): undefined reference to `eth_dev_attach_secondary' > collect2: error: ld returned 1 exit status - eth_dev_attach_secondary is not defined in this patch, it's defined (and used) in the first patch. - eth_dev_attach_secondary is actually defined; The report even shows it fails to build with gcc: the gcc build passes on my dev box. Honestly, I seldom trusted the build reports from STV. --yliu