From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-BN3-obe.outbound.protection.outlook.com (mail-bn3nam01on0041.outbound.protection.outlook.com [104.47.33.41]) by dpdk.org (Postfix) with ESMTP id 434D52C4F; Fri, 13 Jan 2017 04:22:21 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=7aZUifMGiUZCEvbr6MxVZp9hiJvdAIrf7aK5pNBwymE=; b=eheMpK3UmjRfMnQa/JtnVUuqVng7SUcGPx8/sslQc04pbI4636bBvlMcBCnYwzqbS7/dMTqnzjTKo1I+NAUXZe0e4ikucE9+aTpJTufXpkGFHPNKaxObztNvPDDZjkhkroKcCwf6hGVofvAyjXUPrxV+1SihL/AlWfL3JTThcPg= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.Jacob@cavium.com; Received: from localhost.localdomain (171.61.97.114) by BY1PR0701MB1724.namprd07.prod.outlook.com (10.162.111.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.817.10; Fri, 13 Jan 2017 03:22:16 +0000 Date: Fri, 13 Jan 2017 08:51:56 +0530 From: Jerin Jacob To: Ferruh Yigit CC: Thomas Monjalon , , Message-ID: <20170113032155.GA31838@localhost.localdomain> References: <1484207214-13638-1-git-send-email-jerin.jacob@caviumnetworks.com> <1733289.GsZYjJJTCP@xps13> <20170112135830.GA11208@localhost.localdomain> <6167bd74-c515-fc12-744d-9168a633c646@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <6167bd74-c515-fc12-744d-9168a633c646@intel.com> User-Agent: Mutt/1.7.1 (2016-10-04) X-Originating-IP: [171.61.97.114] X-ClientProxiedBy: MAXPR01CA0046.INDPRD01.PROD.OUTLOOK.COM (10.164.146.146) To BY1PR0701MB1724.namprd07.prod.outlook.com (10.162.111.143) X-MS-Office365-Filtering-Correlation-Id: 95a09ca8-4d84-46b4-a8c2-08d43b636187 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001); SRVR:BY1PR0701MB1724; X-Microsoft-Exchange-Diagnostics: 1; BY1PR0701MB1724; 3:3l5Oj9IFUotNXcsmLOLxtEhsanVOtpejg7kaVDds3cD/teYn4uzgmPYjg7R5zWckgKHoCMzXMo0JnThyVNsQjBL06y8i03UdZfzNlVWGGnbKLsIecGUfrBhvv6hFB+hsz0TAEoIHzncHv1BRmA+LW6RGqQ8WUl9I2GpRAFIkjxgxgCG9NLOian44nZxIRfUCulORfR1iZTqMkfPZtjFxQh54onf6NjioQ5jErdhr8RdboQRPchGp6HZRbWsJic3kshPLZ9WB0VFaR9egd3ofUA==; 25:d229cLvfWoXER4jC/eSYfkZtjjDleIpl5jalFIffTZ8kMLZI7CIzJAi2PStTVMpWTby8cgBdmGryLYBzyxvLgyYLUDn3EQbi+DxMXfqrkGNaYshSs/r4xV7CPZbLvOpXKtd01D0/dvldlMTBNV2H1qCpN7R8wl4izrKsklw9b6O0sPaN00g8FR+54HC7AFSBgiTTu5kR1MMrVlzEoEiJt4202R+0kNMxEbwN71XsCexA+ZQEIZgwpnk43SFDTncq4kKOe4GoFgKobk6W24ojeeBC9CHuP0iSh0nDYt73iS/0LM9ZEN977M0q0ZaXSriva6lft/IlXcI8R/zQGl9tzvuAKhFwNOiVt5HuC8k+96c2tDlY4/UEo5NRUolWYpluY9gbwmXel+EQWo0fQ/wu3Sei0UqSqrA5hMDsUopt138G5b9kLZFewTwmsMms9l104ThCkYs10R4Mhij/JTS8Eg== X-Microsoft-Exchange-Diagnostics: 1; BY1PR0701MB1724; 31:JlzT2pZnfbLcHFin2qE5L33eJuWqXjCIOTItuRiiuRYDHrKegEn6A2krm0RU8s2zchDNN1mMJPXt6roWVZdLGkBLNJArbI6bCBWvDT+sykTxxp2ondi+NB4ff8DA/doDBSeBs1zqT7xblziH1z/mh3vZstbDHpCssCFcmBdtd9bmRvIF0q2qgQGQPKCtNRdkEMrdoWZYOZ62CVz5ni82HOPrvgN+feUV24+Ir9Et9FMoKv5eBXYScVYT9NLo9IIxDBVUkIEPEdVOAlzDzNckBJUKSyVX3Uh1TWmHROHWLao=; 20:azDe+tl2Intpn7/L7q7HCzHIS0qWX54Zo4Fs+g+NwAF0fRvkr/Hkf8u5rZE/a7nf0GAIok/uADNjvZqSI0gsjCppQcucrlv3Ksp34e+nUuP9yj3AZDvkNmy85oz8JzXVqmtYVXG4/CTos7PMFGPW7ofEZuC8R1z38qn315UQEw2ec+U4PxWZvfJGRJPAooBRc6btfUMvpXrUNQQVgmjV/Shx1gC1hAsWYCAzKG45PAIXa2jiHOzst4OWqYyDr+Ts+y2KHnvEoShG3GBE79MVJhmsoUNnq4hcxLz7c091SqUs8UDr54hlge9gbuBtpE7oqlXhWLTcsYvX6W2cwYJh06NtoPQC4t6AbGHXsYJRkIMdBJByK7p8p8sKVDjlHFi8PVnSjRWeU1uGkcI63E3Us3K7iKtTzZTHMMHTIB9IgbafIU48q6oh1KtjjpoA5+2ZXwLru73KdUTbwAzkqdYqpius2769SfDffQ71y/K5+sGub475KRu1/rJhvO7hxuUcd9HxuHBHhA4gL/VdVOtPHyyqDPvbRkS6iXQbF3bd7nBgZ0KhdGIoEyRIRIWkL5evSYSFPxk5R19mndF4tk/X2ogEyV6+GxBev6mpStTyBU4= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040375)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6041248)(20161123562025)(20161123555025)(20161123564025)(20161123560025)(6072148); SRVR:BY1PR0701MB1724; BCL:0; PCL:0; RULEID:; SRVR:BY1PR0701MB1724; X-Microsoft-Exchange-Diagnostics: 1; BY1PR0701MB1724; 4:+pLmQCtFUfMp5e/hol9pweV5nL0oo3sHPyUld1735e36sSE0wyDQFWzcpjDX4ZEfE1o1lbUTDRN6HFnocvDADQDCmAESfs3aUhDaI24bT84pgU1w//5Y3rpwJ3nDowlsBJmO9941QURyADMVdhUnPBHJT62qNHJyopWpCzG54HSLwPbyK4Vef+76tmjWFuiL1JhRc1E+cQUnwBwPlNnC122zNMkzFazvnB2N6vWmqv3EQwWOekOnBYKjotokpCnxqj6gYF9D3dUDXOFDKVhqxoH9t9hJmwgTmZGExnsF9AMWCjoKpOf/2J8gmKzD8dtt5TATyW3CyoHFAV5XJpyS9Gtr2BIK3RWPE79EZnDptAcjRYmjyyFX26F2g9kpNt/fLbbzP4CRkv2g5iAdWLIIIRSgM9NaRoExoWbd3i8VVTHKbrj2wEnCiA7UMt9bbUAEnTRYRgrSLQUaEX+a8jUBN9c/5Ro6WB37/q49RVklc42xUs3uUq/8m7W52hFAGUUg87zF8Z3ANBj3ZyxllD8Pan9yOMsgBuH5ES7sKT7qeBh/HK7DS9TTRxgnxuIgELXoXioCUP8dZkAO7jsfjp8U7w== X-Forefront-PRVS: 018632C080 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6069001)(6009001)(7916002)(39450400003)(199003)(189002)(24454002)(377454003)(377424004)(68736007)(47776003)(55016002)(46406003)(7736002)(25786008)(189998001)(33656002)(2906002)(97756001)(4001350100001)(105586002)(97736004)(50986999)(76176999)(4326007)(54356999)(305945005)(5660300001)(101416001)(106356001)(42186005)(92566002)(110136003)(81166006)(93886004)(81156014)(229853002)(66066001)(50466002)(1076002)(2950100002)(42882006)(6916009)(6666003)(8676002)(3846002)(61506002)(23726003)(6116002)(83506001)(6506006)(38730400001)(54906002)(9686003)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:BY1PR0701MB1724; H:localhost.localdomain; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BY1PR0701MB1724; 23:gF/QknvpZjBm2LzvxMm2Nth2ocv6N2sB1ImbjFz?= =?us-ascii?Q?6PxKSyRdiedCmVJkJi/diYX/swiVHDlEUiRDZDb7UWHYFaOoA2FX1jVk08mF?= =?us-ascii?Q?+6C1TAlzbx/HSoP1od7+9sAj9xGw+cH7x8QjXgS0ja4d4Fmg7VIQX3/apPnz?= =?us-ascii?Q?iEOU5J6akSLDzHPDXfnEwuvLcloc9bumlD0t9FtKy/4g1TmR/U3TLIgE1rLF?= =?us-ascii?Q?anygkNBg5f5yxV+eWWyJlYbgJX58HkXr5SH/nlxCDNu3wf6M1aZSCwmoFJJl?= =?us-ascii?Q?iszXpw8tmm79laOtGtuQzQKfLfey8p35/fVwtUELnyYifeF4t2zltpzAbU66?= =?us-ascii?Q?GWZE9lk6opMbga58XKza3YgISE8kpJcKsJmdx65gWu4xTYr3wEYUbGFrnjOE?= =?us-ascii?Q?Aa2QQLOujfeVMVtOOoKAgbpa7yHrgTSzInrqRRMw7ZP95tydCndhU6OK3pkc?= =?us-ascii?Q?PzZ+GOBgf03t8IenjLLp2YvRIoGELH9qNCuT76i0imtc/fiQMiuEC/yAXmna?= =?us-ascii?Q?EKwMjDO0SSuQ7LQpDs9Hi8kSPxCTOp2EU+wTC6M/72cLLzPE2QQt/oMInjHg?= =?us-ascii?Q?McPq5eYlfETMrMFx/RooS95poKpQkpuVcivIxlL+4s+lgL8s+tp5nT4ni4Qa?= =?us-ascii?Q?VL022ZmfZIg6pgtd71a7Qbd/SZJqZchy2jJ+5W2Z6Ozsikc8TaA1Gd2nWvDI?= =?us-ascii?Q?Mwuwnd2OfBPEbNYMM/wHiZpZpIkm928RrdAt9H+IyQadtrvC7XFARaTszpH/?= =?us-ascii?Q?YdiwXea6KITHUMJgCS4OnsvutshFl8AgWDQ7Pu63fCXfxLOrQdBVSc0U57OL?= =?us-ascii?Q?8MR0k6L0CQg/5oPVuG/NKtLWRmBClBFUuwXAVEXqaaEpkd1dPM0+mUeClMSs?= =?us-ascii?Q?QI8g+qs5vwDIFeLQWNLUWIwGChw4NiAv8Hyx6qzyqqRb1AtMNhd4nSYLTkYi?= =?us-ascii?Q?ks2D2uMWHL93MP88b19M18Mj8vIKeyMYN0CA4UtkCKAd0NCciIJWbx9NmbTq?= =?us-ascii?Q?PwWyadIv9X8aiFwORItnZFsFCvkS2xzAW0HWa9wHEX9w49g1X987R5u3Fr8q?= =?us-ascii?Q?m7CXbULKWqWdYRwCAnV+HKkKxPHNVS5+CdkBjzPZmayRkWlUw7K1vEF+XZuy?= =?us-ascii?Q?7FXsxd+WSIRZAcu3RJ8bHBIsGpDAAKeKmPRHvho2Yn1NH9rMqFqzr1o2j67v?= =?us-ascii?Q?3uRPVFvEahdfJQCAwkquPBTnzXZOTUj9ph2CRDbVZzMhooWKtlh5DWZpAVcV?= =?us-ascii?Q?7H/VB8oUmOZzNP6Po/a1uxaO6bUHQ3ZOFkElql2voQJZeBRFduvYBd9c/quT?= =?us-ascii?Q?qVDqm1ypYOsEYFOhVYChGolexPCUuGDekFudtbsjwizrq?= X-Microsoft-Exchange-Diagnostics: 1; BY1PR0701MB1724; 6:VQQ+57B1anX1DdC6MHYrKQklecmyE8GxrEEsEJPvsdqDWKdlClLcN/AzEkC3pgm7wWNpO4XorJlPaxCWUZiQXegU/3jei0rDEeLu+y+X2QS7UOefFC8SDxxDQ8u3gqvp+DK+ktScAcOdvc23Eg4Hv81BQ2hBT1VbKzq5nU46YRnO0mgeLDGt5a3V4Lc/jWkH8jiFho6NiuKrfXr5L87lDzL1jomOdb+ElJq4v0xWpLxdj6H4ICKcOcQIJpfRn8TUAyNkIa+ZMKK1K3ECxQVZbI1hj6B3LX1MlKsT8fK480id+vTgIpAB3Xc1jGWOdz7NtCokBDv0IU2ImfDUIlyB9qPidAqTZoaKgUVr7t6CVy6UALpGIJlGcXMUUYTfXcj/LaWBp8+rKP56aYOiwEPzw+VQ0BHpzTW8Xg1VTA9usTM=; 5:ryaAS7DVqcSGgopgAsRPgFa7TCWx9UIctJZLpBSfIICOWbJnUQzZsElQoXxxkkMrWpzKfiYqo0Rl1Ne2yaT172ifQorWZGoWmc90GbDDmil2LGp8Y30dvdRyjk2DczgYVzOqPqDADxFuqUM7OihWeal2fdhJPhkXCSw0UnZ6In4=; 24:xEtZsp9haAJc1CL/Mb9m41ixiqRgDUWE00lSQuxozdNJo8VgVq8mhM22yRY3eTjA5SH3JMYOSiHpcS3qI+QPgDEAR+4T/G7RnbBF89WQ1yQ= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BY1PR0701MB1724; 7:BLYuMmPjf+zKVp12ZwYxjRU82GxFsK9GzUA/7QR0fhCQcZGtQk58hGfdAcnwgYj2eHic4rUcI4xyZZ8R0Im4bbPdnaNeqJUclUaP1fzmv/GQko5HVrUIRhEFeXWScJBTDRckyeiEfboWyDWHnAtaS2JmKrGx3Mfi3fMU2dXEoYdNYjq9rZEZzjdHKKWDxrYQev4pJG+5H624Cw/sw/Qr7csUBvN72vWLAo2eZSOfcM5q5qE8xZYvUMpB9gFtMN2xH3JTlHH5N1RXyQk0zGVX6u7MQNkVHbygsKicOBUTVLUPBowRr/UDlwITgvVL4Sa7FGDjqF5Ti9xKX4dKGCNH+x7u9j1UL7SxmZiv56O4hH4k9aVnQVYcRIVZspOyR45IOMws/tsfMNH1Z5OQwgSr7Zd9+b1k/Y8593zJDR9++XpP+JBf+T29xrPI4k+tDCrFuHl//D/QSb7BtKxzOqrc+Q== X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jan 2017 03:22:16.4663 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR0701MB1724 Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] app/testpmd: fix static build link ordering X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Jan 2017 03:22:21 -0000 On Thu, Jan 12, 2017 at 03:27:30PM +0000, Ferruh Yigit wrote: > On 1/12/2017 1:58 PM, Jerin Jacob wrote: > > On Thu, Jan 12, 2017 at 10:26:08AM +0100, Thomas Monjalon wrote: > >> 2017-01-12 13:16, Jerin Jacob: > >>> +ifeq ($(CONFIG_RTE_BUILD_SHARED_LIB),y) > >>> _LDLIBS-$(CONFIG_RTE_LIBRTE_IXGBE_PMD) += -lrte_pmd_ixgbe > >>> +endif > >> > >> _LDLIBS is an internal variable of rte.app.mk. > >> Please could you check that there is no issue when using LDLIBS instead > >> of _LDLIBS? > > > > Tested it. Suggested change has issue in shared lib configuration. > > > > [dpdk-master] $ git diff > > diff --git a/app/test-pmd/Makefile b/app/test-pmd/Makefile > > index 050663a..27cadd5 100644 > > --- a/app/test-pmd/Makefile > > +++ b/app/test-pmd/Makefile > > @@ -59,9 +59,7 @@ SRCS-y += csumonly.c > > SRCS-y += icmpecho.c > > SRCS-$(CONFIG_RTE_LIBRTE_IEEE1588) += ieee1588fwd.c > > > > -ifeq ($(CONFIG_RTE_BUILD_SHARED_LIB),y) > > -_LDLIBS-$(CONFIG_RTE_LIBRTE_IXGBE_PMD) += -lrte_pmd_ixgbe > > -endif > > +LDLIBS-$(CONFIG_RTE_LIBRTE_IXGBE_PMD) += -lrte_pmd_ixgbe > > It is LDLIBS instead of LDLIBS-y, following may work: LDLIBS is not helping the situation as LDLIBS comes before the _LDLIBS-y mk/rte.app.mk:LDLIBS += $(_LDLIBS-y) $(CPU_LDLIBS) $(EXTRA_LDLIBS) But moving to EXTRA_LDLIBS looks OK.But it has to be under CONFIG_RTE_LIBRTE_IXGBE_PMD Thomas, Ferruh Let me know if you have any objection on below mentioned diff [master] $ git diff app/test-pmd/Makefile diff --git a/app/test-pmd/Makefile b/app/test-pmd/Makefile index 050663a..2be8c50 100644 --- a/app/test-pmd/Makefile +++ b/app/test-pmd/Makefile @@ -59,8 +59,8 @@ SRCS-y += csumonly.c SRCS-y += icmpecho.c SRCS-$(CONFIG_RTE_LIBRTE_IEEE1588) += ieee1588fwd.c -ifeq ($(CONFIG_RTE_BUILD_SHARED_LIB),y) -_LDLIBS-$(CONFIG_RTE_LIBRTE_IXGBE_PMD) += -lrte_pmd_ixgbe +ifeq ($(CONFIG_RTE_LIBRTE_IXGBE_PMD),y) +EXTRA_LDLIBS += -lrte_pmd_ixgbe endif CFLAGS_cmdline.o := -D_GNU_SOURCE > > -_LDLIBS-$(CONFIG_RTE_LIBRTE_IXGBE_PMD) += -lrte_pmd_ixgbe > +ifeq ($(CONFIG_RTE_BUILD_SHARED_LIB),y) > +ifeq ($(CONFIG_RTE_LIBRTE_IXGBE_PMD),y) > +LDLIBS += -lrte_pmd_ixgbe > +endif > +endif > > > Also using EXTRA_LDLIBS instead of LDLIBS may remove the requirement of > the SHARED_LIB check, because of where it is located, but this seems > just coincidental. > > >