From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-CY1-obe.outbound.protection.outlook.com (mail-cys01nam02on0058.outbound.protection.outlook.com [104.47.37.58]) by dpdk.org (Postfix) with ESMTP id 9D4F02C6B; Fri, 13 Jan 2017 17:01:53 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=vQ0ENETTmvz5AHc6zqy6gXefGupFI7V8Qo1z8WiwmiI=; b=oOJSm0REztHNj+JSc81vZemmXqwIPLVAKrWNfuhGYtFQPpbpPE/sv6nt7NKSoLqPxGONnTbYiD6Xn7fXMp5aniiM9HmivEPV4Us4oU//Am0kSruVJa8AwrWf2ZjFM19Lj1n7BinXTW3u9VMNSNGhX5yRwHjhiVajqt035rjzrc8= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.Jacob@cavium.com; Received: from localhost.localdomain (171.61.97.114) by BY1PR0701MB1724.namprd07.prod.outlook.com (10.162.111.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.817.10; Fri, 13 Jan 2017 16:01:48 +0000 Date: Fri, 13 Jan 2017 21:31:26 +0530 From: Jerin Jacob To: Ferruh Yigit CC: Thomas Monjalon , , Message-ID: <20170113160124.GA17956@localhost.localdomain> References: <1484207214-13638-1-git-send-email-jerin.jacob@caviumnetworks.com> <6167bd74-c515-fc12-744d-9168a633c646@intel.com> <20170113032155.GA31838@localhost.localdomain> <2563842.f8ghPspXGG@xps13> <55b009ac-8186-12fe-43b2-b937dc32b8eb@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <55b009ac-8186-12fe-43b2-b937dc32b8eb@intel.com> User-Agent: Mutt/1.7.1 (2016-10-04) X-Originating-IP: [171.61.97.114] X-ClientProxiedBy: MA1PR01CA0034.INDPRD01.PROD.OUTLOOK.COM (10.164.117.41) To BY1PR0701MB1724.namprd07.prod.outlook.com (10.162.111.143) X-MS-Office365-Filtering-Correlation-Id: af304c30-5f84-43af-b183-08d43bcd7cab X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001); SRVR:BY1PR0701MB1724; X-Microsoft-Exchange-Diagnostics: 1; BY1PR0701MB1724; 3:5+5a3mN1UtjGOG85Sast5e/v4Fs/RZOPPbtKvVSfoATaDNrCurur2xeHmc0fP0BWjjtfppGxgwFLQmgV5VFsNsfOZb+nwZXnHarPmXICdO3RhUMyneTCJqOCUuTjA9cbtUtOAOtyfpIM0rq3CEPeuF26PYTq6EYBGtHXhtR+S/B4BpjnK43uoIep2lSBeXqGbhUTMfEp3TyzCgZhtoogWIlTGumTSiJFOQxDXzVGoBrCm4nV7P+7Qb17dakJENL+lHmPX+CRzc66BXm7jyHmBw==; 25:dwTgpoNHEwZUXZlTnTDX80gpWFvxWGVG/kH/GJlW8YCRJ71jYadYRs7V6DaWU2FTnaloJq5RIl+8yvTQa2BP+0M88hDaFCc6WfsK6SgGdfpFYPrLW+OKbx1ZRp5NufCKswB+BSuzUVHWZG67jvJR+M41Pub2DZV3GT5Ua5/6uJBJgycQUVCAGy5R3wIrazHW20Vyf897nzLXHpkZyCoJEpK30Ns3sj6BW4Mm3IH1n1cEWYxGQdB3fPqdRfxlXqW6REHt6RXMCBtHSdEtfJyJo1oWstMYYU6UJNf8qRiAiohSrMCEb0ignAbBya8d7XDfkYy7x+wUEI1c5ZgDfg/8HfD5VSoDpnqWJW/SkfZRiCIpH8hvZ5ZOPSw1ayBu6cmJh4Xs18GzpSm5D88gYgv8q+imFINoFHOb+hTzR4HfC40RwkNO2GZnQgf5s4chWKrJKOfHlTs6zXdqFKi58/drqA== X-Microsoft-Exchange-Diagnostics: 1; BY1PR0701MB1724; 31:6dGvKAznXndvi3V/ZlmVK0k0zJkv7kl6PWyl/kxSecKKLN/2rU+Zz+vATYuVbderCGcesnhBaM5hf0hHPh9RAj8Triom0BdPdBnN3P5PC3fyt27R2qR02IYJbfEU7M6fThZStcM0R82r3RWna/Nl4sAM+ckJK4KGRdWx8VQKG54QtgsXxbwzqHLMh9Eb/etXFxYJbWUB2l+ZkgjLtOx9BLvUd5CnPJsA8/lHu3ULNtfXEpILIGIA/nfXmiei24ZqBVLiKhkLrJcDyRtQCNUg4/7PvnICF+c09o52m7uJlTI=; 20:J+8TLKQRd+zdF15JEjJVzQXmwVgBIpeW060bwm1KvsUrjd4P8NMbSoe6YuNRT9JbSBdaUeS+PcfRaZH5h21MJ+kdU201aAvlpGe9L7HEYcaC2Vq0ghHbIsQIGTS9OoX7EJZzwlFIF8oFmv+4vDtd1q/Mu0dUhl4+Zf9dX0OWpEi9cQ3K9SDevdG/yk9wGAWGsQWCTXEcU8AEsLSitj6RvUKsFwA42G/s2J/wAxSActv33pIlMZtIeRuXFtLGrHKDggSx1VSXAKZJnEKRkhluvrD/R/EFawp7tT/6iKp4YOyORus6sFGvBbuIkoUoQW9GyfVmSGV6w9h7pyUCR5enyQ8NdXITlR7V/m1khUJqAccX8HZ2mpUR5AzeduXrDCf7HkOsX6PUy373Hsd4RVjNIH9buc92fP7rTb1czJbrJK0pDO4wTkDpwrGNCr+Hl2/XgiH86hCZdRuX6WqwJGzGP4JMT0HENBNZgSPVULV0WqgzEieQiA/T5NVjukNr4NpEHQt6S+V5Pweln+afl6WmpY0K9TfbVANWopyKNCxp3MOfQvs++X/P8RxvUqLihH3Y0uPgiqqeSqCRv+DrACLBTyoVtn230TDrbX/FWwJ4M3M= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040375)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6041248)(20161123562025)(20161123555025)(20161123564025)(20161123560025)(6072148); SRVR:BY1PR0701MB1724; BCL:0; PCL:0; RULEID:; SRVR:BY1PR0701MB1724; X-Microsoft-Exchange-Diagnostics: 1; BY1PR0701MB1724; 4:KSTh9s1GVcCUv7sLdRlEMd9hPxikgs3mmW/stEMdPoW8noj1pI0y/pEvhOxOKAdvRgo0CoRMNUV5xrOSIpIt+IO3SJVUApW2BmSqXB1EfDxpmfudz2hZwoabwcM6zxrjaxZEVPy2UHnrzsHNUed3Vas51nGM5h8lBTSt9K5wILEJ+0lLvUwF9KkYtFBrOEAefz6QE9fjoOwZE/PDbtv2b/3IzAVvEWf85KOQH2GAps06z6OnjYKwr4HDiUQjMsda+n/otHhA/1+2qxv/e+rXmcDuaCgxcV8vg3NoYtIYWJOCgsjxV1YgXEh3cYe4nVTp7FNYmDEKJqQ3GCgALMU5cENAPUXw5npz27vfg60DkwJRzS8heRLT0ykEQlOPCql1X2dhYS/oAtsfER1aNVNAoXtNwGlELue4F2ff3Ee9aYEy6Oy1yPhnK7sKcgxmwTuEWUt68w9RICr2OHLX3e9ZNQdGzxlhwJxqtQmOIkP+OTexxFRhBCiv/MU2Po747loZJGCMzutEWWam2yFOQNmDR9tkKEouKhw6SvRIdNyMUOLAxtcm9wKAGG+M1g16Hb8mTYuD4CeI/LT6UyZa59Em/Q== X-Forefront-PRVS: 018632C080 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6009001)(6069001)(7916002)(39450400003)(24454002)(377454003)(377424004)(52314003)(189002)(199003)(1076002)(50466002)(6666003)(66066001)(3846002)(93886004)(6916009)(42882006)(2950100002)(81156014)(61506002)(229853002)(110136003)(81166006)(8676002)(6506006)(38730400001)(54906002)(9686003)(83506001)(23726003)(6116002)(33656002)(2906002)(97756001)(47776003)(46406003)(7736002)(68736007)(561944003)(55016002)(189998001)(25786008)(305945005)(5660300001)(101416001)(92566002)(42186005)(106356001)(50986999)(105586002)(4001350100001)(97736004)(54356999)(4326007)(76176999)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:BY1PR0701MB1724; H:localhost.localdomain; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BY1PR0701MB1724; 23:69Kb6EpLiKCp+BQvz1DzFgsceJ/aqLgOYgWnjJF?= =?us-ascii?Q?K7FOjhNvQK3gUDPNO0MMI2AVemENeuqALJgSd4cE316UqVm8n4UVWNTLyi6B?= =?us-ascii?Q?1yOXcp6z8DiXNlUEq0FNOm1gUzSkNBnBAZ8aSvqj6oEZQAf4I0NzCzk83xK4?= =?us-ascii?Q?rlG95x30b65+byba7YIUkNCf+YXjdyb0P0EDbRRadM65P7PZ2RLWiWRQo15L?= =?us-ascii?Q?roPX1Nhp82s5oCuWu+7biMOmTpI25xFcEk6SxBXVqd6jxIdkgqOMEdSaaIwm?= =?us-ascii?Q?YdDdhHAevc6Xk+cm8JvTkAFJdC5JBwkdTiOjSkIn/65NDZj9ZRInxqwCVW26?= =?us-ascii?Q?3r61YJc61NoHKNkXm7IqPjJ6T5s7CgESIPAnuZF1ygpqk1J9OBo5Fntn1lUd?= =?us-ascii?Q?yzl6sd2HzfZjv15IsLWNBhdLRlQh8PNtyQaYNQpZfVAnlLL2tJLtUC8skXD5?= =?us-ascii?Q?xZ3thncbZl5SJAHLtARbl7qOY8QXZQlO+grWvqZSS4hwh+jYdC0Aa5Bjo4S2?= =?us-ascii?Q?tnvcT31prt6ECRa8TU3+Ah+U+1iD1sQrfQyrnAyOr1wtublJ1l59nl8J16Aw?= =?us-ascii?Q?71KKHeFIaN6OtPRxVFgyAMlAaTfftg4iTTfcO0sxCw8Cnqe8wut4ZLEBM+V4?= =?us-ascii?Q?nQezXBfOMNRRiY/JidXJKzJW967R/l4d6aoCa4L+gzu5UMpxp1+CXROHx3AV?= =?us-ascii?Q?jWea7rFWq3VP+QFVqD4zEgJvK03BsQusZOdUh2qZIoMUNJ4sj86aK2nIqqO4?= =?us-ascii?Q?9KcakFtm/F2671tjPMl9QkaVmgnJsh1xBj5qtbDxC0fg8IDgKQ5p+Ado1pV+?= =?us-ascii?Q?Yti7UDyzmHp1FtXz3G53h7k4eUXd4zPQymBk0LrBsa5dhOZQA7rzkQyWXEff?= =?us-ascii?Q?zs36q7QkxW6Sg769kFANy2Nr0LWNVd4Si8CMnBCMNpuEwl6jhrZ7Y+p5nixT?= =?us-ascii?Q?izzo+1Sy8JN7P6SrEf0FyDEW2ySxY+c81VcGlgFy26S4pwXULgreTlmANljT?= =?us-ascii?Q?XhDu7HtvYDK1x9qsnMdAl6sm9lWfVNQPtloreN0VCgsnVin9y2qbPDZNKUE4?= =?us-ascii?Q?7A/huaDSsR3Jk4+asF138ZVbqS03z8JMN/+DtSM3p3cQ4m1ig2QUTr3AF2Q8?= =?us-ascii?Q?MRDr82X+PuubJDbzS+rIYqnIWLjB95jOQhsdvGsPJ7axPbqGndvY+avdfFUP?= =?us-ascii?Q?rnYr90AOecWDU0GMwzEosIjXFog3YBhDMJjQweMkNMmVeQg1MH8+atgg7wo3?= =?us-ascii?Q?Ht9kAtp3A2uFNXXhuCNPTx2b7DpnbUaq86N6/MSfng5WCjxmNTsIi3tqw/6P?= =?us-ascii?Q?+ELng6I28Ji+75Rtngf87mNGKBHA6e98ebKE1gpa74MlDHNb0lthldg+/mDp?= =?us-ascii?Q?vx5GgyzzLdbzzyWcv/UkNP7lGSOY=3D?= X-Microsoft-Exchange-Diagnostics: 1; BY1PR0701MB1724; 6:LOYGGJjA9x/7qQprba3iEY42FvwJtNEgvnJ6QtCTiCco3PRH1HPpqFssZYjmGVsAS+SV2njRi5WTazPeT+0hlHgrUGXoKy7SEk/cF5FEzC2o1O6jHi7i8MUYebDUEN0sgWXtRPYz8sIiKhyGoJzi2Om4IseYaLvW/TWz2gr7iCJS1PtZmegPNsiFUQ0Hcc5Q5y4rOwrnWcSVd2voyFYyArPCVB6COt+CJERpAaC1tuPC+V3MGEujPnMYpnkZtsHz6/deOUdDhVQiBW76MZ9PLAaKxH2GdrvRAeFL3Tf3vQF7M4fYJt9pttn35ciqqDekwJMctu6YIrIrY59zQhNgL56CvTINHOohn0qr9SmtbJlWF/KF+g/x3WYHRc26j02DWFfoZnZpk6yb+vIMWTD0vpCJkxJpo9M9nCy+lHFlAxI=; 5:VbRwyEN2FqhwW4mpBkV9YMXGZT7rz7Ceifvq4sarGDejO/4MxMCzLuc5/I4bgGC1BIA4hpQOnelomWuVAjXT5rRzwyjoNmhij7pUP1dQhtQohyd0q87Abhg2jMMO1zNTD01iZ44BipqRfHgkrrgVP2Kac8B71y5zGUWYJ5UiLMk=; 24:mncVxizkKprYlaZlwmF859Qhiihgxzh2xS1GjvT4iA2y++KXJwLJEo14Oq+/7bpcRhVxDCe4SiudP/oe/Wa191i0WgqsA/x/CF63v95eVM0= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BY1PR0701MB1724; 7:MUtQ4vBC4Hs2UrK/bOg/aSGSAknWyh48hE0d+6BSi78AuGmvRKXMXtFj4sOxZDrrxk4YvFlq2P7grIgy9L7zKV+urJrYxEiIekOW3O5kfindJNqMgumFIGcRVuQkk+rQJ2pYHVezUaw+qEmIQ1s9MIGb6hU5ln4nrIqjz8yT3eOl5hfrQxH2lrTjrj6cvnn1/shDkWtgXoZD5JgDii7iZt/ruIrG8fECQcC+RT5TsrulG+XnvtpC0O5rY9BN0CI7T9B9uz/U0LsjKWKn75lCsqcJR12DLNm29UCtT3AfmNlq7z+7KSmY+jVS6Y5Ge1qxF7bF2SShgGUfYLlYvhlsi3F0+ucZQDPtAVnT/ifXW/NaPYjzFzUQPB5o9N9vZhKn03ZpS05+hKeLUNFyR7Oi0hYoxUHvHOJgB7O48f9dXIkQgA2uIl8lGUXBCAV3LH5EPKWZBa8oJa/CXPq/eDbGmA== X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jan 2017 16:01:48.9735 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR0701MB1724 Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] app/testpmd: fix static build link ordering X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Jan 2017 16:01:54 -0000 On Fri, Jan 13, 2017 at 03:57:59PM +0000, Ferruh Yigit wrote: > On 1/13/2017 3:53 PM, Thomas Monjalon wrote: > > 2017-01-13 08:51, Jerin Jacob: > >> On Thu, Jan 12, 2017 at 03:27:30PM +0000, Ferruh Yigit wrote: > >>> On 1/12/2017 1:58 PM, Jerin Jacob wrote: > >>>> On Thu, Jan 12, 2017 at 10:26:08AM +0100, Thomas Monjalon wrote: > >>>>> 2017-01-12 13:16, Jerin Jacob: > >>>>>> +ifeq ($(CONFIG_RTE_BUILD_SHARED_LIB),y) > >>>>>> _LDLIBS-$(CONFIG_RTE_LIBRTE_IXGBE_PMD) += -lrte_pmd_ixgbe > >>>>>> +endif > >>>>> > >>>>> _LDLIBS is an internal variable of rte.app.mk. > >>>>> Please could you check that there is no issue when using LDLIBS instead > >>>>> of _LDLIBS? > >>>> > >> LDLIBS is not helping the situation as LDLIBS comes before the _LDLIBS-y > >> mk/rte.app.mk:LDLIBS += $(_LDLIBS-y) $(CPU_LDLIBS) $(EXTRA_LDLIBS) > >> > >> But moving to EXTRA_LDLIBS looks OK.But it has to be under CONFIG_RTE_LIBRTE_IXGBE_PMD > >> > >> Thomas, Ferruh > >> Let me know if you have any objection on below mentioned diff > >> > >> -ifeq ($(CONFIG_RTE_BUILD_SHARED_LIB),y) > >> -_LDLIBS-$(CONFIG_RTE_LIBRTE_IXGBE_PMD) += -lrte_pmd_ixgbe > >> +ifeq ($(CONFIG_RTE_LIBRTE_IXGBE_PMD),y) > >> +EXTRA_LDLIBS += -lrte_pmd_ixgbe > >> endif > > > > You need to keep the shared lib check. > > Anyway, EXTRA_LDLIBS should be reserved to users and not used in a Makefile. > > I prefer your initial patch using _LDLIBS. > > > > Any objection to merge initial proposal? > > > > LDLIBS should be OK, as long as wrapped with SHARED check. Is following > not working: No, due to the following line mk/rte.app.mk:LDLIBS += $(_LDLIBS-y) $(CPU_LDLIBS) $(EXTRA_LDLIBS) Again -lrte_pmd_ixgbe comes first. > > -_LDLIBS-$(CONFIG_RTE_LIBRTE_IXGBE_PMD) += -lrte_pmd_ixgbe > +ifeq ($(CONFIG_RTE_BUILD_SHARED_LIB),y) > +ifeq ($(CONFIG_RTE_LIBRTE_IXGBE_PMD),y) > +LDLIBS += -lrte_pmd_ixgbe > +endif > +endif