From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-eopbgr730071.outbound.protection.outlook.com [40.107.73.71]) by dpdk.org (Postfix) with ESMTP id 6751414EC; Fri, 13 Jan 2017 17:03:11 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=8MlBLjmEv0Xn9ggKTt0Sn2k37F8f8oRieHZ40zcl6EQ=; b=n0qapjrgadYSinjxHkVyvPil5dTPpJgtKrbnrtUCeC4xYRRewupsTCbUSsRbpu5DL5dojNmNnm7TY9dREmxj3dHxREiVRInDnjfP9FI2TxwCCDs9HXwA5sn2DDl1ddtghc/bilFCPR2DFQ5tE2I+Pf0SE9WOkrhdJz7kCOllSP4= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.Jacob@cavium.com; Received: from localhost.localdomain (171.61.97.114) by BLUPR0701MB1714.namprd07.prod.outlook.com (10.163.85.140) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.845.12; Fri, 13 Jan 2017 16:03:07 +0000 Date: Fri, 13 Jan 2017 21:32:51 +0530 From: Jerin Jacob To: Thomas Monjalon CC: Ferruh Yigit , , Message-ID: <20170113160250.GB17956@localhost.localdomain> References: <1484207214-13638-1-git-send-email-jerin.jacob@caviumnetworks.com> <6167bd74-c515-fc12-744d-9168a633c646@intel.com> <20170113032155.GA31838@localhost.localdomain> <2563842.f8ghPspXGG@xps13> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <2563842.f8ghPspXGG@xps13> User-Agent: Mutt/1.7.1 (2016-10-04) X-Originating-IP: [171.61.97.114] X-ClientProxiedBy: MA1PR01CA0009.INDPRD01.PROD.OUTLOOK.COM (10.164.117.16) To BLUPR0701MB1714.namprd07.prod.outlook.com (10.163.85.140) X-MS-Office365-Filtering-Correlation-Id: 7c860eb2-6b66-429f-7238-08d43bcdab49 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001); SRVR:BLUPR0701MB1714; X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1714; 3:1NYsP2Vc/dS9rc8dUsTb3qUEzUnEetS7AfRGJBstNKTjMSJMITJa9SgPAYA31bnvvhAaXkygiEHxPabnwHD8/2GL3Xl7EZliF74wU4Ynm+fqcgjsA3QeXYMpgNnrQCYYGySBr7cCDc4p388ZqnOAKyqjUT/hsFCMYnqDlj3E8fwg1rt89q0f+9uwapWyOzSi+wI6wkPeQcIwUSzE/7TwWn8sTgkILBiGggH6gYmIoIRmMsSef/DE/2J1C4E4oDnaYJK0iM/t9M1fw9408FNADg== X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1714; 25:hibmY1BEVlWp6g35Vm5ejxRyXwYC1JJlf60NkvDhUDX8bSd9Z/Qp3CuPb17OseHUhgo6GLEZfAmVAUhVI+Rm8QV+b5G4SvtxIa4ssB0FDeIATUKDRCLdKbC1QuO5Tj+50tNqFxF3NvefAYQxKSx35n86HrTbKCXV7mc1SDb0E8bAeZWcOcsSCDBa73lWKvTH6aPakN6PTEeIqS2GWy3NTgu5gm4z5IsrdYX4HSLJ9GOnp+YbtCU/EH10ycWu+/WpTIUejzBk25Y6Qu7oXYFxHVKzA1UKN/WVVHcUP9AXFemEyZ7OTUPjqmmiDKhziG9udMym4FlUsOpabEylaiYwt+CZlaSATm5kETBNSab6psGRXWDLgMITWUZEdRFE61LClhG/WS6Ah0CMlubzOFC7Al/ua4FjESkqQkAVn0R4d/DdQBU/DHd2zFM3zygibhjjhzxlcNusRSsX60EZwzke80LoJvh81kQEjdpPppgJB2D8oUbzWvFzOQ/Sad0zSyYAzUE5edRdekngE8Cx03q1TYHOkg5HbVyCOUSAVnR/rjFIZlCHbE9mdrMkyfFXflyr3HAx35k4k275Ldm7VVAedGJQfNSugH1KMgKWwMNRI4mis2j4xoRoQvi0WJNppERi0ekoNzqSCmIj1U43IiMSpN6KShnb1gmCE1ZHOUXkDgEcbNoE9ZXU0IOSbeK/Wk7DErvwTlmjPu2KCMViTY2NXJVSsZFZj8dfkCSITHOxi/38+Cb0+vfWKII392UpQRf0RoDYfolXsy5azKtMg0HAAQ== X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1714; 31:UH4YcBZc4lwdEtnAZrUsMsydslv7/2Cd0+VxIdsq+7xRnOoky6NlJDrriQnk3C8PSeQqy+AB4juNWAedr3xBpP4c284wYUcoukJtEMHdKBCDruGMBxRcjelP2V0iVtMl/YPxMFKwH1/wMbrLDf45MgpKGrcfbq39oUz8OlDkCS+1h9alVA7pG+pBjs6a6nQ2B5OjdAvGilgpBGhYYUrS+vjdn68msvRY4lj+TEWOgFFSRtAYOXJmEGqGihz8b5S2oz/VB2XeNzTg3fv5JBKq0tl0sisPr6zkVKAgKlSBe4E=; 20:Q+b6Vf+I3amhcLtNnc8kW3stj5852zjXYwH/0BjZ5p3pNd4izWqn/bvRhD3+ttyq7GK2bIe1K9LlXYpnJMTbSp2HwQlpFsZ1dsiymWg0my5FumByMliBdLIyq3rpIl5RFUkAjJFjjuooa9Ae5soDfM2Wfl4ag1//Hh9QQFm9Psu5ZahNbmQ9U3E+v40Yv39YFSaGpU1bK091BfeL16iKv11FZ0X/w8VIU5XnPAyyYeIx0gGJOMrUTCbbbeZjF6y4+PUBD77q27FiR6Jh//uqXF7f1BNxJ47oIFmygesOHIK7GN5GY+gj0VFAg7wCpBs9ZBy3II9BoRWW5+5SHyOhALbfmWiq0UysoVHn3ZKSbkx2nOLG9YifoaKMKtgdcOxDO68H5IX4mf9dpFABLFnBQhzJ+aa6HeLid+ZLQ9yO3bLjPqXUCST7yo/jwQzghX25sFAWOv+hjno0Kq9oBYMnDdIm86oKBPCjfsVFVuJSk5TCOxbvsBYM+5580WBiQv7GsSvupTq0sdBBvzT+RIsBMraZ5y47PkHOusIp04ODSYlKpEq/mP9ksbjFLi37jMR5Q6LCg3HQ49u1En4a9lGMXKKTGzpz7VcW2ltLiqbePQo= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040375)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6041248)(20161123562025)(20161123555025)(20161123564025)(20161123560025)(6072148); SRVR:BLUPR0701MB1714; BCL:0; PCL:0; RULEID:; SRVR:BLUPR0701MB1714; X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1714; 4:UDyL+S6DBB9UICtAHsZUj9XemdnS3iZq6B5v5ymMPVebCfjao3pJ/cO8pcpfFiJMuvIonBu1cv4+2qeyh0UOPPe7/boOUNBH9uaSnH1bxdBai2r5gYU046QsweZAFkuSx82qC5apIxYKbTE0HIP/lKzzw3UaFanVdoyGobIqsq2O113Yk5pJdZTzBFYVPgB26xvssnk93gMv5qnkuEzfMVbK6M95siITgK9yeBwJJSKIlvzPikrzuAoBcyrO7kFxD4L93pWxLVBYpnqchuTHfBKSqC6mIebfX9jZ4w58euRvReXDotMHCdIllTgFHSVqeWeoG14SYO/na6u4VWMieW0tP5JdyjIv6tYX8fjVlE5wsH2wU/vKHX2K3zTQUPV38YpMEKXkfdsNpeDj8Fb5H7xWii515PMZED+5s+EUJIQyQNQehYVjBzEy0r8T1ZTtS4pFH9lRZLgQ80psp8I6Ic4R0wE2N/l78yIIYhSvaxaJ8Hk1TFtbWp7Ws0T/Hdeebvuun1FtqKxVUuzYK2cqfCPLwgpovzZ7DBE8pgqQVOTyWg7bVu1WWD+MW55pTLsSBol3gzbQ8refTAYvuPgpvQ== X-Forefront-PRVS: 018632C080 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6069001)(6009001)(7916002)(39450400003)(377424004)(52314003)(199003)(377454003)(189002)(24454002)(25786008)(68736007)(92566002)(229853002)(38730400001)(6506006)(189998001)(55016002)(81156014)(61506002)(47776003)(66066001)(81166006)(6666003)(8676002)(50986999)(76176999)(54356999)(105586002)(7736002)(5660300001)(4001350100001)(6116002)(42882006)(2950100002)(6916009)(97736004)(83506001)(106356001)(42186005)(93886004)(3846002)(54906002)(33656002)(9686003)(561944003)(110136003)(305945005)(23726003)(4326007)(50466002)(2906002)(97756001)(46406003)(101416001)(1076002)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:BLUPR0701MB1714; H:localhost.localdomain; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BLUPR0701MB1714; 23:DgfYWtOUdUjQj7tia1xA5NhAPAjvxBN7qQ7uLsi?= =?us-ascii?Q?tSzYzm/TkKvvi6h/sYGuIzNZRmj5Je9uPNvhxzv+Oi2Cc5Ax7Pl2IOciJ5OY?= =?us-ascii?Q?jZjP6BWUTOlXnPsv121iy8AVmsdEsWUMGv8JNatrwfJfFrORWwPgpIcUBrEC?= =?us-ascii?Q?ujr4CnQfwhArUgItB/leh7o0W1UtlnYGqjIbW1AxskOKZPNBpSelCDP+I/HT?= =?us-ascii?Q?l8F0PVAIxW53zsKEinkvQnOKH2kH6W1kn45T+7nvBpI3bnIzowHM18Phqwfq?= =?us-ascii?Q?4UeLLwdgwQF6vWzyis8z9XcWVtTUBtzp+WFMjp18D8ZWM+lRU936OC6jQjf+?= =?us-ascii?Q?gk+OQzlc53gW3dAD/k7G/q9LRnaX5tZTlySHEybKPNUyP9kH9K1047ZV0MX9?= =?us-ascii?Q?rLyyTUTChzDv55uAspzVf/NtDyKqu7IPPaxXU4Dz4G6T9FCKER+r2lCzBgW3?= =?us-ascii?Q?WANyPKAjHy3rIMqJwuSkEDUZ5zCzGA/rCg/VtFl+GhK8mpdXKUjQ1XwMduW/?= =?us-ascii?Q?No5depJh/jct6YLrXzrKzOgs1sWMNQlDUozpgjJPlO5HTseOe/xL+UOL+0x+?= =?us-ascii?Q?C3Mr/IVTMkBdHeruEXmWmAGi91Jvax+g1j3D3aTQUpuzNLq2fa3LaS2vTIT5?= =?us-ascii?Q?535QJVjeAVXwPUCaWz+kVEZvvvQ1bV7RyaBKZS/Xl9mClHLH4UjgcRRF38/i?= =?us-ascii?Q?TWu/UcknJOVGf4xTNWN6WQn//qjoVQAH0pm8GA5OC6FJ3zd1pCOA/EoPT1An?= =?us-ascii?Q?+o+ZEzb/dkN5w+hR1TNh5XdGQtzmyEzoQ4yBbX+tgxHuBXf/DGygURLzD3Lf?= =?us-ascii?Q?ARePOfb89aaPvU0pNyUXvfWv6JcawG+YGtbaorwYGnhoCG0vIuf7+7ru+djX?= =?us-ascii?Q?4QanM/3d2oMewfzl7qE9w5a0t8h6/V1lAtY1Sro8yUR5GlNL1zzSW2qYWQaE?= =?us-ascii?Q?YtJg0IFyrPbjYpPcVo5e10Xk3KAANj5imBxn9PKCpmP4rSCrq2I4rxj94P1F?= =?us-ascii?Q?esi8VU8lSve8EzdAOwRhu+EFc3qB2HOp/+DOCu50tKD3XfWLAvLHNZhme1zC?= =?us-ascii?Q?liJAqyU+wVTVVgtr4KGz9/YaEZTD7nmldLTkKnlSbaPh6x0CXYQyHiOj1uoA?= =?us-ascii?Q?M1INn0rvXHA0/7+v0asw9T+DUoLUATq1SRFxcSGiig57mEIbGfkrC59ZV9az?= =?us-ascii?Q?awmskhJ9buDVZudzN40mZViss0s8sXel2uPEBQI0WXXO7J3HvhoK4GD0VBRs?= =?us-ascii?Q?qQV/KUkOBtSlT+oEYtq/YOf7rZih/kZUg3sdWiuvtDsTHH8MBGmMOkCtY9r3?= =?us-ascii?Q?jJYTV9ISp28a805Ss+c+7SItipJedt+7eSmfRBpbo0MRLpwjgLuYLgfxjyNc?= =?us-ascii?Q?96V9FbnEe9bgli0Tb4NYQSPLVMmQ=3D?= X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1714; 6:qUNQn+rk2mJViblPEW5Y42m8oaagY2AfpjeaX8Kd9rRUVLFgHCRz8n1y7j/ukRyOnvsu72L1TWGwCn9MdfqNUk/3WygjSRkz2v2cimqLE4OHQKqUXo9A1NeP1nNBbPZd0YaxcJs1qWKioBgqPaw3kSvtYDMg8eXsf5/iLcteoe+U3QfmoZNcL/xUVw7vg8GkMdOMeg0JLq76J+5MbB20rDJY8+qq4fg+3L/unOJOmzYO2NVBSmSohjvcfb8l7UZn7sraY5VQxswmh5A/4O7e09H4U3K7I93MT5Lsy0tvOo5QaUAkKxoRVQCOeaRvRGeJ4ekxF9V6P10EogHvoOiXzPOl2d8NZ1shYWWON7eFf+c+LHNPWcfGFcNv4twz5oolI8EoEbR5caD2RSUzt83AlUnvJezbHU9zhGMGqI9xaNY=; 5:o41VgHkGsazMyp6ZlwUeVnYbEB0hbeE6T5t6rt7JglEHVIivjV2gCwqSsonwy2Xm7xIat0C8EmavFCUAOOUQHe3qE1vvKWk24FNNlkROikNsseBQdLzmEEDR8KsJ2TA2i844c3MagOzS4tnvIbYmzaR9649YtACdVCrdjEUQL7o=; 24:O2LbNkxAGdrD5ht0PDu6GclofT/oFrh308sa7254DinLKtkSRPwu4Q8xtesbjINemDhnqlK3jomw4+WgWycZw6QSXJ4oDA/m+T/FYpc4fyQ= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1714; 7:D+Jp6vlaEOw2yTU3xRbDX9DjHgpMkffcyU+TuvFZcoyNaXskCb24eb33JrkYeduHxtkx6YsarenxkC6/2l8C44c9cLdMZVqQSWIrRkbVB1ml4RaGEFC/6NvbCEZ2AgsvqCVCrHcGIv33zoOr6BN6gr6M72tOv19PoJS2EXBs/96O0PlXAYwllnn44RgFw2c+0kmbykuVNk9zZ68l5NtRwFSF+Q0kWJp2tiSuZIpyTKDu/da3queRdfl24Lnn1wV3Tw/RxlCodFj4qMqMSdEwUZDU0srHFgM2YOfo2SlQ4fhgQutmM702Nnc5ASJUnOePE4vp7VcdQZ4CUXLxm0HQgQmK5UVa0vTxPd7nvvf9VkXt9cP1SZVxXNP/iLw1a8lrJ3e+97ckRKrd4AQcIJOSoK62aEYRjF6zniKKMcwGH/dk69BXLuddK0YM/rzJhtp1n2LocC1puWxYxmJUaZxo7g== X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jan 2017 16:03:07.5007 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR0701MB1714 Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] app/testpmd: fix static build link ordering X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Jan 2017 16:03:11 -0000 On Fri, Jan 13, 2017 at 04:53:46PM +0100, Thomas Monjalon wrote: > 2017-01-13 08:51, Jerin Jacob: > > On Thu, Jan 12, 2017 at 03:27:30PM +0000, Ferruh Yigit wrote: > > > On 1/12/2017 1:58 PM, Jerin Jacob wrote: > > > > On Thu, Jan 12, 2017 at 10:26:08AM +0100, Thomas Monjalon wrote: > > > >> 2017-01-12 13:16, Jerin Jacob: > > > >>> +ifeq ($(CONFIG_RTE_BUILD_SHARED_LIB),y) > > > >>> _LDLIBS-$(CONFIG_RTE_LIBRTE_IXGBE_PMD) += -lrte_pmd_ixgbe > > > >>> +endif > > > >> > > > >> _LDLIBS is an internal variable of rte.app.mk. > > > >> Please could you check that there is no issue when using LDLIBS instead > > > >> of _LDLIBS? > > > > > > LDLIBS is not helping the situation as LDLIBS comes before the _LDLIBS-y > > mk/rte.app.mk:LDLIBS += $(_LDLIBS-y) $(CPU_LDLIBS) $(EXTRA_LDLIBS) > > > > But moving to EXTRA_LDLIBS looks OK.But it has to be under CONFIG_RTE_LIBRTE_IXGBE_PMD > > > > Thomas, Ferruh > > Let me know if you have any objection on below mentioned diff > > > > -ifeq ($(CONFIG_RTE_BUILD_SHARED_LIB),y) > > -_LDLIBS-$(CONFIG_RTE_LIBRTE_IXGBE_PMD) += -lrte_pmd_ixgbe > > +ifeq ($(CONFIG_RTE_LIBRTE_IXGBE_PMD),y) > > +EXTRA_LDLIBS += -lrte_pmd_ixgbe > > endif > > You need to keep the shared lib check. > Anyway, EXTRA_LDLIBS should be reserved to users and not used in a Makefile. > I prefer your initial patch using _LDLIBS. > > Any objection to merge initial proposal? from my side, No