From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on0077.outbound.protection.outlook.com [104.47.0.77]) by dpdk.org (Postfix) with ESMTP id 9DC3114EC for ; Fri, 13 Jan 2017 20:45:56 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=zjPTkcTm7rAe87daF5z6fiMwO5S2IlkF09fgFDniF3Y=; b=yWdyJAJ2hXT2qOfRjouHDNVt9ErR6lqkF24AzzKmIgS3Yd0zgg546fMOApve+PPE7wh7ER3dWzcx5xPFp5zCW+cuzLmsb0ezw32e3boGc/y0WY4PqDJTUFbl9+aZmJVe0r/qEoYaiLCft78n6Us2iVtNq2NDL99WSE4RJ0abBh8= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; Received: from mellanox.com (12.250.235.110) by VI1PR0501MB2464.eurprd05.prod.outlook.com (10.168.136.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.829.7; Fri, 13 Jan 2017 19:45:51 +0000 From: Yongseok Koh To: CC: , , , , Yongseok Koh , Date: Fri, 13 Jan 2017 11:45:37 -0800 Message-ID: <20170113194537.19364-1-yskoh@mellanox.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [12.250.235.110] X-ClientProxiedBy: CY1PR0801CA0072.namprd08.prod.outlook.com (10.166.203.40) To VI1PR0501MB2464.eurprd05.prod.outlook.com (10.168.136.15) X-MS-Office365-Filtering-Correlation-Id: 52f438da-d0f0-4507-cdb7-08d43becc8e6 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001); SRVR:VI1PR0501MB2464; X-Microsoft-Exchange-Diagnostics: 1; VI1PR0501MB2464; 3:4mQn/Cx+aAW91B8DJlzM6DqFebxrw7+mWw3VMRWUul1Vbflhiloy3j6/N9zPx7kSAgAsJS/TxNacND14KYX2M+ROdBZwTQL2eTPvxKzMhhqfkeV1S3Yk3tXheS6YpxNStKhmzYHDIkOEQwMq1EJq/IAVmI92Qjdq26mRjoE3OHjmmcBYDSM5Zoq93ryBTJ2I2y9hl/mzryJAWGueLy2+NY+BojIBndEq97Dpjf8zWyRDdpu0ZVcZ3QeJ78b+XRJEMD9dko5EVhXdM+lAEqQZkA== X-Microsoft-Exchange-Diagnostics: 1; VI1PR0501MB2464; 25:7dtY98wABi8X6rHaB1fAGoZ8W9hZJMQ3EtRzXvYWjCaj5eo9+9IXHgPkY+AAQ1tayRkHIMUILzbvvHK2CU6Cxt+3q+LQsvgMWiDvdWBpTE1R3q/2ff5+qVva51ARtm/B0ssqa+0VpuSJOBj7TI85799mNfyVsWtU6f3mV89s/+dydh/dUM6V7N2ssAe0QZUw5TQJwvbqNGR+5FtJGcyVgY1P35LBfdyfGHzKi1bRUzWS7MskkzgK5cIY6wxdkZSrS4tb2PdG68nj1nmg+XJOv+P8La69ZBCSBwuMQCofk47yfHU4L0MXLiVwWn7XKLMLLka34tK3N53pZpqtRKqsEmOWTI4vHYWXiDUN5xgicA9zZON+A14Zv7VCM/CeQDRX4GSIg8q268qhcnMsvB8lMCn2uynS7HdbJvG5Lapac1gAWvY/RFYZWdZSHRMWy1+Rq40oR2AlqtWNkWIdgTXln/PO30m8VR7UYSkHMLvyKFv2i1oRJLNpxlNH9poYdutDeSGNYdRZwXlX2kdBKh9ZM+5OiTHhCg/r7UxAX1sVKVFiPcFnl+ybCVllbNCMrR00nbi1zQ4aj1rGCDcn89Ptb6uYwmOOsgaTO3Vyj7ypUnl+8AnoHttOe5EwAqGEQ/4THOO1yg2kXtbdoymMiYgonwj88eRlRGaUQ2IqX2kughOdfHEQblcZrmB2We1j35kgY3R9XEl8vk0AAfKiME2ny5tcyHq56iZ5LY0FqOV3OmZx28oHT/A0jru7k/EeoX1o X-LD-Processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr X-Microsoft-Exchange-Diagnostics: 1; VI1PR0501MB2464; 31:LV585dq5yR49PKWpznGhO7KjZN/ZTYJA69um7PXBuSgmuQnhJMsIop/ZJbfcwwAr23/2lmTUiPuWaEmTNMlyVst6MLoS2k+4tEok8jx4SB/vzURwsw2ZKcYXAVZ3evFiLq2qiYFR7H+D971Au2B5HhC2UZqe+zFAIw+3D5VynRGp4jEZyBIrTnPDBA8uX78bp03AkSah0HoY3yzCSu0qpLT7mDwjregM/i3CSRdq5dESV9mLQyEE/UX9n5ijk2bF; 20:2NQq2ws1abi5PTR2mp+G5oMQGoW/Cwc1Nit6Pdq9NSr/JlytjxRZypLxGWNHZHteC3Jdn1D7yNkbjJSf/o7A1SlbKO1FNjavDSIgq8OcSUZY66ICEg1ZJ9QfvMxKuBrkx8dR3GRmtBDrqehEcBuhu2/eMIuJZ6yOAvxW0r7I1DKk23WNFh3WJ0HnZrN7sfRDY6H93QizjuhCCn4Z4jvQaP0SfynUEpM291gRVlBNiecZBh3atEqYDIi3MzufFrjGpW64ScqtCZMVTQzZlRu32HJ+DoYvCvlfRszG8bBV1IvYDQYsyxUpIuuZ/yFP88VVaqbwHOtJiOabxJrYkKaOWInM6N5oF/rA7K3Ux/jN5O/500m0FagHEky/joOxDO/RVumFavkd/FXBMWkRQ2kNTIkPEVHNdhj/Uhjwe1ML4cM0RdBdnYSSqOj6R4UPtdYaaTMjaZXTME7isECh5abiu2VMt6d2N/Xi8HVUF9w0lLuOOC+M6Nz3iB4iHLEkamTy X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040375)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001)(6055026)(6041248)(20161123555025)(20161123560025)(20161123564025)(20161123562025)(6072148); SRVR:VI1PR0501MB2464; BCL:0; PCL:0; RULEID:; SRVR:VI1PR0501MB2464; X-Microsoft-Exchange-Diagnostics: 1; VI1PR0501MB2464; 4:wQMDCbxa0Z98V7w6U4MW4fWZYWl7LlHweW8wWpYZ9XWNaBjZLBAWQzY9oRzZ2DeqzKOasUbFIsVaYPzEfpakrVJtzhLqyxEy9e8LSJbwPyhXnFFcfYCoeV92pSpbBcN2OqlstkZDOCSrKKG2kxeN54/C3cN4LvG2TdfxE6MVRLXXKQ4Yyx0SjlBVzxcosJO0aVqQSVVtmy6Ji7ORutb2s1pDHagRSe+rjt3oiTnFlAEgKQ268U/7NVaooM9zyxy1TePo1dXHjHnqadCADjgelCdQYMZ1fedJXKiMrDi1SJj7Y2xB/jEQNguaG65Jy3vzipQ3OcXp5BwaJgQqZTDSBW3+B1Oq1JxJxv0I4h9xILrcv77ixuKABTKwQ53gf5niRf3xNSTlpj7yqT9WjH5BNZ81JwW6ntoTzgIUMytnXYUM7mBCUOjnp8/0CTAGV7OLe4smmhwjiSBu2y3w26U5kdwu5TZhAn97aTNv3xnfuKJMxYmP29A1L09ByxVm3I99B+zDqRg2v/Lerb6GrDADx+gxuWR9OSgrzQKQec4XelQgrcmDfHNg4airisoV+xCGxBb/EHsZ+awTEdN06d842Q== X-Forefront-PRVS: 018632C080 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6009001)(7916002)(39850400002)(39410400002)(39450400003)(39860400002)(39840400002)(189002)(199003)(81156014)(105586002)(6116002)(38730400001)(42186005)(33026002)(25786008)(86362001)(5003940100001)(92566002)(106356001)(101416001)(21086003)(2906002)(33646002)(50986999)(81166006)(27001)(189998001)(54906002)(55016002)(5660300001)(97736004)(47776003)(7736002)(50226002)(3846002)(6666003)(36756003)(110136003)(305945005)(2351001)(66066001)(68736007)(1076002)(4326007)(69596002)(8676002)(50466002)(6916009)(48376002); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR0501MB2464; H:mellanox.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; VI1PR0501MB2464; 23:dpaWq+83vfky+Tn4G7NvNiJ2DOh+W3Id+6P9cs3?= =?us-ascii?Q?w0Et80PC5AUnqwJD4GuwIMgRzrCA6FNUcR5aczSUeveayTS9wUQGY+qkD8du?= =?us-ascii?Q?NFZjwZvTVX6lKYIGlQWhQseZlE4lCHEjY5H4H0wOt1wSFrN6T0Th6/0N0kPH?= =?us-ascii?Q?+Z3kT4TB+f/F+OiPDFiYEZix7m2PPn2nFuQ8OiwB5VhXPchIkbxI1zzsnYn0?= =?us-ascii?Q?uKSUPqjHog6BYE7LHpEVcdVwqzr7ntH6JwPq2ctX5BFkycuUvK/MwFj78pKG?= =?us-ascii?Q?sRS7BDcP5aZ/+zpNfj3Gdy81HE7l36vfRhCfyVtnRgWNJuT5C1V2sHr4lGtz?= =?us-ascii?Q?ZErn/XSqNzMbMxvbYWtwCjAByj7sOMQcbVqCC4w67evSfp6Fi+JHgJZzbpHO?= =?us-ascii?Q?oZb75mk/Q7yB5mEBdut51kDCfy/1jsDVmZ0apg9tX0lQJWjPu3HQwCsgBr6C?= =?us-ascii?Q?HU4/qNF8ijGx6lNFCkxj/ph7SJvbs6qJlzcRF/d3N1urIYbDZw9GFBsrsd+F?= =?us-ascii?Q?v8ORPeetOJX8ipcwuX35KwcNRb/rb8d4vrDPARS+4ysufge3q1pjOB9jbADa?= =?us-ascii?Q?pAd4mwxuOsWefO00TMmRxSaVwHtccPbpCMniJs9BUGB4tMbGBz84tsvn/DFy?= =?us-ascii?Q?nODGLHT6hR1haLLPRXFyo3B+XfvKIlui2jpMUeapydYlOLNnzoUmHW1AzP1+?= =?us-ascii?Q?UJG+mgrBcTOhUhqUlIuEbERZ5ZLtOjPlPB476PGkylgFigHCZBkxtPuZ4LfC?= =?us-ascii?Q?4hJjScj53D1VKEHl9i+zeqFKquIqFV8cL2zQkJ1UzPXE2ymJMPBBIDn5SLa3?= =?us-ascii?Q?Ohl38pJYupCXUHjjJxstJMCykEgr/64TLmJVQsXcm2xMmGhEDlzZhjTj6+lu?= =?us-ascii?Q?4i447yyYoHzHY2mTa01aJ1NXDCSsDC4HECcXIKa1Oduj4M9cefmzsHH8yzKH?= =?us-ascii?Q?lR/YIskh3hAx7mVrxOLPWIfdnJgHsVH9mD1n0Ahj8eZXeh/WyiCloLEVaNXE?= =?us-ascii?Q?lkd8T3cM+t6c/X2n2jqXtRfSWgCTZtlvUoSDVYDIqRnbg5amlhbThlgLaKHw?= =?us-ascii?Q?bm/66OLIYs8vj1/jJqW10lgcJtFXlbqJbwSwvTclS5ZA1ytuopHAcWagSnZ1?= =?us-ascii?Q?yi1+qep0klwk841LrNHZqwvGWUweWAYm5znALgGhifG5oqV3OcNPKxrcGoxo?= =?us-ascii?Q?xHuaWqVfreZEm4cXRwS03N4JcJDIF2TRyru7juAIaIt5m2gKHvFbJmdjZNFK?= =?us-ascii?Q?BLJiF4wWeFXFQMFaQQVE=3D?= X-Microsoft-Exchange-Diagnostics: 1; VI1PR0501MB2464; 6:bLavB4lLvRmzc7OlqUbmtE4f++a4tdJKc8TiVu5ym4d34SaKSb4CiziPFvjDebvO0hPf980e1j5CJIapyC/Kyj5dLkUnSit/ZG02qQO5ESTi+TcDeKkSedM3X3QjKDwe5KLQIssXKcSve9arXxLoAHKJZ72sVYW1iHM1h6qb/NH54pzpUEdzNSHln1MLS2URAWnkh8TQPhQ+1ULj6DxvDMIZqyZ/Purl5dD+gYHIsLXQU+6Q41bZjSD77QP2VDtTSQBI1laZ5hr6MgJOeS3fVIqA2NpmWbBvDNjS1PWnYsD7nLmHI20ZJeSIrH9quoSEXaGTLkYrr7rPdCNSUgxAy8JPBqDSAW6g8RAr64B6EjP4Z0GnJaEmHUuQJKKHZ0Sh8rnTK/oq/03YLdWOD9K6F47biCV5AlBBtnoE091CuVErgFJ0te2BKHZEs8lsn3kIUCUwunOubvJIFgBNQ7y/7Q==; 5:fPKVtlwu3l4Cfr8Zw/0+bl1BJ73qscLTfKtpz3pb05/+hUdca44IE3fD9bRirpt/eVLuMWSjAhCnCLwgqG84Thxal1vBgbzejxPgIXIRxECaySs4fxIUPWqr3PDVln97+xXjpHQf7rS6SWN+nhQwJOxu27K3ONoSymY0Ops3jbI=; 24:x4yVJwm4ADVXG0tSIuezOAMylTDOFPADgBD9hqkO4SoBFpgroKIZRNVzbB+R3KUrPFZ+uhSwF0Ze4sk5qYvHjMCSGGWCiQltM9/sOFoCVzk= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; VI1PR0501MB2464; 7:9cN6YSqv5gJlbowSul/zGiDIAAAAmjSgiHC65KVpTJR7hLkoh+wG4ysdQBHnQjgyP5nMmATmH4vRPtbNY/3FMn0TdvXHxGe5JHbj6XDK1Slybk3IKFM7EO1R+BgBWoFoN1Dv6jiWrOdb++6es0hIy/t/p83YXOHSQ3CaQbDcDPglott1c3wusCTT47POnwTrBkvPFPnfkgmFX6s4SzS4XYw6Et5dmuqAwsVSqRFdRn4aLjZh4w2t6X5y3g8Zki3zwS9WXLdd3Hs6lyhO3jSwsynf00hjck4rdE1L5DD7lmDgpN5yICwtnX7HFFYw//OzBVEuUv+0neimqUnZkdt2o43ld3USS9rsFlNCCilIKPExe3aK8s7tKf4YI4EyucFfIQffC2KY+VXc+FPEGyLLaOUHber4V2b/w9gSTJvjYNonRcyFSFDnPkf9IuXAFkDBW3/nP40UCeW97bFjzDW3OQ== X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jan 2017 19:45:51.7467 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0501MB2464 Subject: [dpdk-stable] [PATCH] net/mlx5: fix updating total length of multi-packet send X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Jan 2017 19:45:56 -0000 The total length field in descriptor of inlined multi-packet send must be updated before closing a seesion. There's possibility of updating it afterward. This bug might cause one packet out of MLX5_MPW_DSEG_MAX gets silently dropped by HW and impact performance, escpecially lossless test.. Fixes: 230189d9ff22 ("net/mlx5: support multi-packet send") CC: stable@dpdk.org Signed-off-by: Yongseok Koh --- drivers/net/mlx5/mlx5_rxtx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c index 89b1300e6..a5b492dcc 100644 --- a/drivers/net/mlx5/mlx5_rxtx.c +++ b/drivers/net/mlx5/mlx5_rxtx.c @@ -1179,6 +1179,7 @@ mlx5_tx_burst_mpw_inline(void *dpdk_txq, struct rte_mbuf **pkts, mpw.data.raw += length; } ++mpw.pkts_n; + mpw.total_len += length; ++j; if (mpw.pkts_n == MLX5_MPW_DSEG_MAX) { mlx5_mpw_inline_close(txq, &mpw); @@ -1188,7 +1189,6 @@ mlx5_tx_burst_mpw_inline(void *dpdk_txq, struct rte_mbuf **pkts, inline_room -= length; } } - mpw.total_len += length; elts_head = elts_head_next; #ifdef MLX5_PMD_SOFT_COUNTERS /* Increment sent bytes counter. */ -- 2.11.0