From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id CAB262BA7; Fri, 20 Jan 2017 08:56:40 +0100 (CET) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga104.jf.intel.com with ESMTP; 19 Jan 2017 23:56:39 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,257,1477983600"; d="scan'208";a="1115381707" Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.67.162]) by fmsmga002.fm.intel.com with ESMTP; 19 Jan 2017 23:56:38 -0800 Date: Fri, 20 Jan 2017 15:58:50 +0800 From: Yuanhan Liu To: Ferruh Yigit Cc: dev@dpdk.org, stable@dpdk.org, Thomas Monjalon , Bruce Richardson , Jan Blunck Message-ID: <20170120075850.GU10293@yliu-dev.sh.intel.com> References: <1483697780-12088-2-git-send-email-yuanhan.liu@linux.intel.com> <1483948259-8652-1-git-send-email-yuanhan.liu@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-stable] [PATCH v4] ethdev: fix port data mismatched in multiple process model X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Jan 2017 07:56:41 -0000 On Thu, Jan 19, 2017 at 06:39:13PM +0000, Ferruh Yigit wrote: > > struct rte_eth_dev * > > rte_eth_dev_allocate(const char *name) > > { > > @@ -210,13 +223,41 @@ struct rte_eth_dev * > > return NULL; > > } > > > > - eth_dev = &rte_eth_devices[port_id]; > > - eth_dev->data = &rte_eth_dev_data[port_id]; > > + eth_dev = eth_dev_get(port_id); > > There can be a merge issue here, please help me understand. > > In repo, different from seen here, this patch does this here: > - eth_dev = &rte_eth_devices[port_id]; > - eth_dev->data = &rte_eth_dev_data[port_id]; > - memset(eth_dev->data, 0, sizeof(*eth_dev->data)); > + memset(&rte_eth_devices[port_id], 0, sizeof(*eth_dev->data)); > + eth_dev = eth_dev_get(port_id); > > Which no more resets the eth_dev->data, but rte_eth_devices[port_id] > (with sizeof(*eth_dev->data)) Nice catch! Sorry, it's a silly error by auto-complete :/ As you said, it should be: memset(&rte_eth_dev_data[port_id], 0, sizeof(struct rte_eth_dev_data)); Will make a patch soon. Thanks. --yliu > > memset(eth_dev->data) added by Jan Blunck on comment: > 7f95f78a8aea ("ethdev: clear data when allocating device") > > most probably it should stay as "memset(eth_dev->data)", but if not, > please aware that commit 7f95f78a8aea removed some assignment from > drivers relying this memset, they needs to be added back.