From: John Daley <johndale@cisco.com>
To: ferruh.yigit@intel.com
Cc: dev@dpdk.org, John Daley <johndale@cisco.com>, stable@dpdk.org
Subject: [dpdk-stable] [PATCH 2/2] net/enic: fix flow director IPv6 traffic class specification
Date: Fri, 3 Feb 2017 01:54:46 -0800 [thread overview]
Message-ID: <20170203095446.4614-2-johndale@cisco.com> (raw)
In-Reply-To: <20170203095446.4614-1-johndale@cisco.com>
The wrong offset was being used to specify the mask and value for the IPv6
traffic class field for fdir. Also, since the 1 byte field is not byte
aligned in the header, do the shifting in big endian and then convert the
32-bit vtc_flow to little endian as expected by the adapter.
Fixes: dfbd6a9cb504 ("net/enic: extend flow director support for 1300 series")
Cc: stable@dpdk.org
Signed-off-by: John Daley <johndale@cisco.com>
---
drivers/net/enic/enic_clsf.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/net/enic/enic_clsf.c b/drivers/net/enic/enic_clsf.c
index c2218fe..2665b6e 100644
--- a/drivers/net/enic/enic_clsf.c
+++ b/drivers/net/enic/enic_clsf.c
@@ -315,8 +315,10 @@ copy_fltr_v2(struct filter_v2 *fltr, struct rte_eth_fdir_input *input,
input->flow.ipv6_flow.dst_ip[i];
}
if (input->flow.ipv6_flow.tc) {
- ipv6_mask.vtc_flow = masks->ipv6_mask.tc << 16);
- ipv6_val.vtc_flow = input->flow.ipv6_flow.tc << 16;
+ ipv6_mask.vtc_flow = rte_be_to_cpu_32((uint32_t)
+ masks->ipv6_mask.tc << 20);
+ ipv6_val.vtc_flow = rte_be_to_cpu_32((uint32_t)
+ input->flow.ipv6_flow.tc << 20);
}
if (input->flow.ipv6_flow.hop_limits) {
ipv6_mask.hop_limits = masks->ipv6_mask.hop_limits;
--
2.10.0
next prev parent reply other threads:[~2017-02-03 9:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-03 9:54 [dpdk-stable] [PATCH 1/2] net/enic: fix hardcoding of some flow director masks John Daley
2017-02-03 9:54 ` John Daley [this message]
2017-02-03 22:54 ` Ferruh Yigit
[not found] ` <20170209003130.17245-1-johndale@cisco.com>
2017-02-09 0:31 ` [dpdk-stable] [PATCH v2] " John Daley
[not found] ` <20170209004009.26242-1-johndale@cisco.com>
2017-02-09 0:40 ` John Daley
2017-02-09 10:16 ` Ferruh Yigit
2017-02-09 17:43 ` John Daley (johndale)
2017-02-09 17:58 ` Ferruh Yigit
2017-02-09 12:21 ` Ferruh Yigit
-- strict thread matches above, loose matches on Subject: below --
2017-02-03 9:52 [dpdk-stable] [PATCH 1/2] " John Daley
2017-02-03 9:52 ` [dpdk-stable] [PATCH 2/2] net/enic: fix flow director IPv6 traffic class specification John Daley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170203095446.4614-2-johndale@cisco.com \
--to=johndale@cisco.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).