From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id C759211D4 for ; Tue, 14 Feb 2017 03:39:33 +0100 (CET) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Feb 2017 18:39:32 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,159,1484035200"; d="scan'208";a="1126225482" Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.67.162]) by fmsmga002.fm.intel.com with ESMTP; 13 Feb 2017 18:39:31 -0800 Date: Tue, 14 Feb 2017 10:41:47 +0800 From: Yuanhan Liu To: Robert Wojciechowicz Cc: stable@dpdk.org, "Mcnamara, John" , "Gray, Mark D" , "Devlin, Michelle" , "Weglicki, MichalX" , Thomas Monjalon Message-ID: <20170214024147.GQ20916@yliu-dev.sh.intel.com> References: <20170209125628.GA10377@debian> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170209125628.GA10377@debian> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-stable] vhost: many vhost user ports (backporting to v16.11) X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Feb 2017 02:39:34 -0000 On Thu, Feb 09, 2017 at 07:56:29AM -0500, Robert Wojciechowicz wrote: > Hi, > > in DPDK v17.02-rc2 there is available following patch: > > commit: 59317cef249c0b23098543df527b3e360ce9764f > > """ > vhost: allow many vhost-user ports > Currently select() is used to monitor file descriptors for vhostuser > ports. This limits the number of ports possible to create since the > fd number is used as index in the fd_set and we have seen fds > 1023. > This patch changes select() to poll(). This way we can keep an > packed (pollfd) array for the fds, e.g. as many fds as the size of > the array. > Also see: > http://dpdk.org/ml/archives/dev/2016-April/037024.html > Reported-by: Patrik Andersson > Signed-off-by: Jan Wickbom > Signed-off-by: Yuanhan Liu > """ > > I tested this feature with OVS and DPDK v17.02-rc2. > I applied also this patch to DPDK v16.11 without any issues > and performed the same tests as for v17.02-rc2. > It solves the problem with connecting many VMs to one vSwitch > instance (in my tests 70 VMs) with vhost user ports. > > Is it possible to backport this feature to DPDK v16.11? As a vhost maintainer, I think this patch could be backported to v16.11: it resolves an issue you met. Just let me know if anyone has objections. > It is also worth pointing out that OVS 2.7 will use 16.11 One question though: will they use v16.11.1 or something like that? --yliu > which means we will have this bug for the next 6 months at least > unless we can backport. > > What's your opinion? > > Br, > Robert