* Re: [dpdk-stable] [dpdk-dev] [PATCH 1/3] net/cxgbe: init data value before reading seeprom [not found] ` <1d9bd589-e104-314c-ad07-ae98b8f5bda0@intel.com> @ 2017-01-26 11:06 ` Ferruh Yigit 0 siblings, 0 replies; 2+ messages in thread From: Ferruh Yigit @ 2017-01-26 11:06 UTC (permalink / raw) To: Emmanuel Roullit, rahul.lakkireddy; +Cc: dev, dpdk stable On 1/25/2017 12:12 PM, Ferruh Yigit wrote: > On 1/24/2017 8:48 PM, Emmanuel Roullit wrote: >> data value could have been garbage if VPD access timed out for VPD read >> request could not been issued. >> >> Found with clang static analysis: >> drivers/net/cxgbe/base/t4_hw.c:1577:22: >> warning: The left operand of '&' is a garbage value >> } while ((stats_reg & 0x1) && --max_poll); >> ~~~~~~~~~ ^ >> >> Fixes: 17ba077c5c54 ("net/cxgbe: support register dump") >> >> Signed-off-by: Emmanuel Roullit <emmanuel.roullit@gmail.com> > > Applied to dpdk-next-net/master, thanks. > Fixes: fe0bd9ee5da3 ("net/cxgbe: support EEPROM access") Cc: stable@dpdk.org ^ permalink raw reply [flat|nested] 2+ messages in thread
[parent not found: <20170124204859.8998-2-emmanuel.roullit@gmail.com>]
[parent not found: <4742eebd-1712-db20-26b0-d2a8e1f9aaf8@intel.com>]
[parent not found: <20170126044123.GA6590@chelsio.com>]
[parent not found: <8812ea01-9e01-217c-6440-adc3360e6c75@intel.com>]
* Re: [dpdk-stable] [dpdk-dev] [PATCH 2/3] net/cxgbe: remove unused variable usage [not found] ` <8812ea01-9e01-217c-6440-adc3360e6c75@intel.com> @ 2017-02-14 6:10 ` Yuanhan Liu 0 siblings, 0 replies; 2+ messages in thread From: Yuanhan Liu @ 2017-02-14 6:10 UTC (permalink / raw) To: Ferruh Yigit Cc: Rahul Lakkireddy, Emmanuel Roullit, dev, Kumar Sanghvi, Nirranjan Kirubaharan, stable On Thu, Jan 26, 2017 at 11:05:22AM +0000, Ferruh Yigit wrote: > On 1/26/2017 4:41 AM, Rahul Lakkireddy wrote: > > On Wednesday, January 01/25/17, 2017 at 17:43:57 +0530, Ferruh Yigit wrote: > >> On 1/24/2017 8:48 PM, Emmanuel Roullit wrote: > >>> Found with clang static analysis: > >>> drivers/net/cxgbe/sge.c:900:3: warning: > >>> Value stored to 'in_use' is never read > >>> in_use += q->size; > >>> ^ ~~~~~~~ > >>> > >>> Fixes: c167acb61278 ("net/cxgbe: use I/O device memory read/write API") > > > > This fixes line seems to be wrong. Should be: > > > > > > >>> > >>> Signed-off-by: Emmanuel Roullit <emmanuel.roullit@gmail.com> > > > Fixes: 4a01078b4fd1 ("cxgbe: add Tx support") > Cc: stable@dpdk.org I doubt the necessary of picking it to a stable release: it doesn't fix a real bug after all. Therefore, I will drop it for v16.11.1. --yliu > > Acked-by: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com> > > > Applied to dpdk-next-net/master, thanks. > > (patch 2/3 and 3/3 merged) ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-02-14 6:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20170124204859.8998-1-emmanuel.roullit@gmail.com>
[not found] ` <1d9bd589-e104-314c-ad07-ae98b8f5bda0@intel.com>
2017-01-26 11:06 ` [dpdk-stable] [dpdk-dev] [PATCH 1/3] net/cxgbe: init data value before reading seeprom Ferruh Yigit
[not found] ` <20170124204859.8998-2-emmanuel.roullit@gmail.com>
[not found] ` <4742eebd-1712-db20-26b0-d2a8e1f9aaf8@intel.com>
[not found] ` <20170126044123.GA6590@chelsio.com>
[not found] ` <8812ea01-9e01-217c-6440-adc3360e6c75@intel.com>
2017-02-14 6:10 ` [dpdk-stable] [dpdk-dev] [PATCH 2/3] net/cxgbe: remove unused variable usage Yuanhan Liu
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).