From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 3DD5C2B8E for ; Thu, 16 Feb 2017 06:00:49 +0100 (CET) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Feb 2017 21:00:49 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,167,1484035200"; d="scan'208";a="1108584881" Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.67.162]) by fmsmga001.fm.intel.com with ESMTP; 15 Feb 2017 21:00:48 -0800 Date: Thu, 16 Feb 2017 13:03:03 +0800 From: Yuanhan Liu To: =?iso-8859-1?Q?N=E9lio?= Laranjeiro Cc: stable@dpdk.org, Thomas Monjalon Message-ID: <20170216050303.GA20916@yliu-dev.sh.intel.com> References: <20170215102345.GU23344@autoinstall.dev.6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170215102345.GU23344@autoinstall.dev.6wind.com> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-stable] What kind of commits can be backported to help the process X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Feb 2017 05:00:50 -0000 On Wed, Feb 15, 2017 at 11:23:45AM +0100, Nélio Laranjeiro wrote: > Hi stable mailing list, > > As written in the subject, it is not fully clear on what kind of patches > can enter this branch. > > Some fixes apply easily on top of other ones which may not be related, > the question is on those "unrelated" patches. Is it acceptable to > backport them, and if yes at what point is it acceptable depending on > the nature of the patch: > > 1. Re-work: just a refactor of some structure, clean-up, ... > 2. Behavior: it change the behavior of a part of the code, ... > 3. Performances: it impacts performances (positively or negatively). > 4. None, the patch must apply by itself. > 5. ... > > What is the expectation for this branch? Here is the typical flow I took to pick commits to a specific stable branch: - firstly, I will get a list of bug fixing commits, with the help of devtools/git-log-fixes.sh (as well as the "cc: stable@dpdk.org" tag inside the commit log). Those commits fix some bugs in a former releases, thus they will be applied to a specific stable branch. - Some of them could be applied cleanly. I will then drop a note to all related people (the author, the reviewer, etc) and stable list, to inform that this commit will be in a specific stable release. - And some of them could not be applied cleanly, when conflicts happens (code base could be changed). When that happens, I will try to backport it by myself if the commit is simple enough (say, just few lines of code and the conflicts could be easily fixed). If not, I will stop (to not mess something up because I'm not familar with the code), instead I will then ask the author (and even, the maintainer) to do the backport. And that's how the 'request-backport' email comes. So to answer your question. The backport should be easy (when one guy knows the code enough). If it invovles re-work and changes the behavior the commit doesn't have, it basically means it's done wrongly. That helps? --yliu