From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: "Nélio Laranjeiro" <nelio.laranjeiro@6wind.com>
Cc: stable@dpdk.org, Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [dpdk-stable] What kind of commits can be backported to help the process
Date: Thu, 16 Feb 2017 16:42:37 +0800 [thread overview]
Message-ID: <20170216084237.GD20916@yliu-dev.sh.intel.com> (raw)
In-Reply-To: <20170216082128.GA23344@autoinstall.dev.6wind.com>
On Thu, Feb 16, 2017 at 09:21:28AM +0100, Nélio Laranjeiro wrote:
> > So to answer your question. The backport should be easy (when one guy
> > knows the code enough). If it invovles re-work and changes the behavior
> > the commit doesn't have, it basically means it's done wrongly.
> >
> > That helps?
>
> Not really, the issue is more related to fixes which have been published
> after a re-work of the code,
Yes, that may happen.
> this re-work may have changed internal
> API/ABI,
No API/ABI changes are allowed for a stable release. But as far as the
fix doesn't offend API/ABI, it's __possible__ to backport.
> structures, ... Backporting it becomes like fixing the issue
> on totally different code inducing several days of work, tests and
> validation.
>
> Should those fixes be backported?
My understanding is, that may depend. If it fixed a fatal bug (say,
crash, misfunction, etc), the extra several days of work/validation
may be worthwhile. If not, we may skip it.
And I think it's only the author (and maintainer) could answer the
question whether it's fatal or not.
--yliu
prev parent reply other threads:[~2017-02-16 8:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-15 10:23 Nélio Laranjeiro
2017-02-16 5:03 ` Yuanhan Liu
2017-02-16 8:21 ` Nélio Laranjeiro
2017-02-16 8:42 ` Yuanhan Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170216084237.GD20916@yliu-dev.sh.intel.com \
--to=yuanhan.liu@linux.intel.com \
--cc=nelio.laranjeiro@6wind.com \
--cc=stable@dpdk.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).