From: Olivier Matz <olivier.matz@6wind.com>
To: "Dai, Wei" <wei.dai@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Zhang, Helin" <helin.zhang@intel.com>,
"Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
Guo Fengtian <fengtian.guo@6wind.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] net/ixgbevf: fix stats update after a PF reset
Date: Thu, 16 Feb 2017 17:49:22 +0100 [thread overview]
Message-ID: <20170216174922.720f83b9@platinum> (raw)
In-Reply-To: <49759EB36A64CF4892C1AFEC9231E8D63A3598F0@PGSMSX106.gar.corp.intel.com>
Hi Wei,
On Thu, 9 Feb 2017 14:50:05 +0000, "Dai, Wei" <wei.dai@intel.com> wrote:
> > -----Original Message-----
> > From: Dai, Wei
> > Sent: Thursday, February 9, 2017 10:38 PM
> > To: 'Olivier Matz' <olivier.matz@6wind.com>; dev@dpdk.org; Zhang,
> > Helin <helin.zhang@intel.com>; Ananyev, Konstantin
> > <konstantin.ananyev@intel.com>
> > Cc: Guo Fengtian <fengtian.guo@6wind.com>; stable@dpdk.org
> > Subject: RE: [dpdk-dev] [PATCH] net/ixgbevf: fix stats update after
> > a PF reset
> >
> > The stats register can rewind to zero when the port is running for
> > a long period. So I am afraid that this check is not always correct.
> > Why not introduce a variable to directly indicate whether the
> > resulted stats should be updated or not.
>
> Another way is to clear
> hw_stats->last_vfgprc/last_vfgorc/last_vfgptc/last_vfmprc at the same
> time PF is set down.
>
Can we know easily in VF if the PF was set down?
Thanks,
Olivier
next prev parent reply other threads:[~2017-02-16 16:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-11 17:04 [dpdk-stable] " Olivier Matz
2017-02-06 13:58 ` [dpdk-stable] [dpdk-dev] " Olivier Matz
2017-02-09 14:37 ` Dai, Wei
2017-02-09 14:50 ` Dai, Wei
2017-02-16 16:49 ` Olivier Matz [this message]
2017-03-14 9:46 ` Olivier Matz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170216174922.720f83b9@platinum \
--to=olivier.matz@6wind.com \
--cc=dev@dpdk.org \
--cc=fengtian.guo@6wind.com \
--cc=helin.zhang@intel.com \
--cc=konstantin.ananyev@intel.com \
--cc=stable@dpdk.org \
--cc=wei.dai@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).