From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 6B516952 for ; Fri, 17 Feb 2017 08:41:59 +0100 (CET) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Feb 2017 23:41:57 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,171,1484035200"; d="scan'208";a="934964387" Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.67.162]) by orsmga003.jf.intel.com with ESMTP; 16 Feb 2017 23:41:55 -0800 Date: Fri, 17 Feb 2017 15:44:10 +0800 From: Yuanhan Liu To: "De Lara Guarch, Pablo" Cc: "Zhang, Roy Fan" , dpdk stable , Thomas Monjalon Message-ID: <20170217074410.GE20916@yliu-dev.sh.intel.com> References: <1487140012-13314-1-git-send-email-yuanhan.liu@linux.intel.com> <1487140012-13314-28-git-send-email-yuanhan.liu@linux.intel.com> <20170216080138.GC20916@yliu-dev.sh.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-stable] patch 'examples/l2fwd-crypto: fix padding' has been queued to stable release 16.11.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Feb 2017 07:41:59 -0000 On Thu, Feb 16, 2017 at 09:10:16AM +0000, De Lara Guarch, Pablo wrote: > Hi Yuanhan, > > > > -----Original Message----- > > From: Yuanhan Liu [mailto:yuanhan.liu@linux.intel.com] > > Sent: Thursday, February 16, 2017 8:02 AM > > To: De Lara Guarch, Pablo > > Cc: Zhang, Roy Fan; dpdk stable > > Subject: Re: patch 'examples/l2fwd-crypto: fix padding' has been queued to > > stable release 16.11.1 > > > > It introduced a build error. I will drop it. If you think this patch > > is still needed, please do the backport. > > > > examples/l2fwd-crypto/main.c: In function > > ‘l2fwd_simple_crypto_enqueue’: > > examples/l2fwd-crypto/main.c:467:8: error: > > ‘RTE_CRYPTO_CIPHER_DES_CBC’ undeclared (first use in this function) > > case RTE_CRYPTO_CIPHER_DES_CBC: > > ^ > > compilation terminated due to -Wfatal-errors. > > This is why I didn't push it to the stable branch. I see. > I thought that fixes to sample apps were not needed. I and Thomas had a such converstion before, and seems we both agree that it's necessary to backport fixes for samples, for the reason the user may still try with them. > DES-CBC was introduced in 17.02, that's why there is a compilation issue. > > So, if this kind of fix can be pushed to the stable branch, > I will do the backport (all that is required is removing that line). If you, as the crypto maintainer, think it's needed, then I think you could go for the backport :) --yliu