From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <yuanhan.liu@linux.intel.com> Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 3B55A2A5E; Thu, 2 Mar 2017 09:13:34 +0100 (CET) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Mar 2017 00:13:33 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,230,1484035200"; d="scan'208";a="71878072" Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.67.162]) by fmsmga006.fm.intel.com with ESMTP; 02 Mar 2017 00:13:32 -0800 Date: Thu, 2 Mar 2017 16:12:25 +0800 From: Yuanhan Liu <yuanhan.liu@linux.intel.com> To: Ami Sabo <amis@radware.com> Cc: thomas.monjalon@6wind.com, dev@dpdk.org, stable@dpdk.org Message-ID: <20170302081225.GR18844@yliu-dev.sh.intel.com> References: <1488102926-24158-2-git-send-email-amis@radware.com> <1488441084-6039-1-git-send-email-amis@radware.com> <1488441084-6039-4-git-send-email-amis@radware.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1488441084-6039-4-git-send-email-amis@radware.com> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-stable] [PATCH v2 3/3] lib/librte_ether: fix code style issues X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches <stable.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/stable>, <mailto:stable-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/stable/> List-Post: <mailto:stable@dpdk.org> List-Help: <mailto:stable-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/stable>, <mailto:stable-request@dpdk.org?subject=subscribe> X-List-Received-Date: Thu, 02 Mar 2017 08:13:35 -0000 On Thu, Mar 02, 2017 at 09:51:24AM +0200, Ami Sabo wrote: > Fixed code style issues following Yuanhan Liu's review. Patch 1 is not merged yet. You should squash this fix into patch 1, instead of sending another patch. Meanwhile, when you do so, you should add version log, and put it at .....> > > Signed-off-by: Ami Sabo <amis@radware.com> > --- ... here (right below the ---). It could be something like: - v2: fix coding style issues (Yuanhan Liu) If you are still unsure, just find some examples from the mailing list. --yliu