From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 930D736E; Thu, 16 Mar 2017 09:18:54 +0100 (CET) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga104.jf.intel.com with ESMTP; 16 Mar 2017 01:18:53 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,170,1486454400"; d="scan'208";a="67915368" Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.67.162]) by orsmga004.jf.intel.com with ESMTP; 16 Mar 2017 01:18:52 -0700 Date: Thu, 16 Mar 2017 16:17:10 +0800 From: Yuanhan Liu To: Allain Legacy Cc: maxime.coquelin@redhat.com, dev@dpdk.org, matt.peters@windriver.com, stable@dpdk.org Message-ID: <20170316081710.GU18844@yliu-dev.sh.intel.com> References: <1489091282-195702-1-git-send-email-allain.legacy@windriver.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1489091282-195702-1-git-send-email-allain.legacy@windriver.com> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-stable] [PATCH] net/virtio: disable LSC interrupt if MSIX not enabled X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Mar 2017 08:18:55 -0000 On Thu, Mar 09, 2017 at 03:28:02PM -0500, Allain Legacy wrote: > From: Matt Peters > > The link state change interrupt can only be configured if the virtio device > supports MSIX. Prior to this change the writing of the vector to the PCI > config space was causing it to overwrite the initial part of the MAC > address since the MSIX vector is not in the config space and is occupied by > the MAC address. > > This has been reproduced in Virtual Box (v5.0.30.r112061) in Windows 7 > Fixes: 954ea11540b6 ("virtio: do not report link state feature unless available") Cc: stable@dpdk.org Applied to dpdk-next-virtio. Thanks! --yliu > Signed-off-by: Matt Peters > Signed-off-by: Allain Legacy