From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f51.google.com (mail-wm0-f51.google.com [74.125.82.51]) by dpdk.org (Postfix) with ESMTP id C4016D018 for ; Fri, 24 Mar 2017 09:25:41 +0100 (CET) Received: by mail-wm0-f51.google.com with SMTP id u132so6927351wmg.0 for ; Fri, 24 Mar 2017 01:25:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=sEX1jjfrqHI04d5E9AnI/2STNwaLFpm6Vd2fNsoKoLc=; b=r04KYIpaong2jUjmsf+ES9+nsUhzCFE/7w64QNMxZgeMUTM7fpGy8MNTr/DAUBfy6P FybQHuBr3mdT2Dn+1p+nl82oUAvD7QbR4XkP4GQOk66qvxe14rpBmhQjZrQ6MciViX8a UnE7DKJETnDWRQG39T5JLVyNofFSvoG9eM2orcZloPIAVAF64bcf9YOR7WfiTeOhMhLQ yzUhhH8Ryo3QUn/k8gaLzli0jS8nwf9Z41PDvUfujw0dfrwDis83nkPMYGglb0iMo7dA xMXKz97j/gkMQI81uXBbuJHk13m62VYQ8GtlVNhhU+zkFczo8XAmuIb/I1Zv/pJkgW1Q Kk/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=sEX1jjfrqHI04d5E9AnI/2STNwaLFpm6Vd2fNsoKoLc=; b=b1ePiBgmILWZFFptNf/cNaGY/9Z3obiKdS4873qWazYQnYEkuKQbGSXtsSZTaWzb4e NJnqDfuDZVavQuv0GxjVmtU9zZUlFZiR2nOzMvnp3289Icgs9SHGmxgDAH34UZ6liXZs mfGuYnLpkQhWFku1nqnNjB+d/hfEEAf5TP0TpdnWHQ8NsnxqQQOIS3Rh0zcqSWq5PUEr RW3rUD96YHXpBQNZJnFDAEyKBJAvEdcJCy3MRE3Ywn8ZWfkdzt/BVjwzVc5KXv5Dmt7m AvQJ037MhEw/aTy93ombGgiH4ym4FJ+iiPCm+pwN1eXPVOnIj2hIf1jHcu55i2/i8sn8 GqKg== X-Gm-Message-State: AFeK/H3i6iFHs00Wt0AIIe+F0b39u2XmYR0M3mqslPRpCvBQ4hpPYoSAEjdW2im2zaE33eOG X-Received: by 10.28.180.195 with SMTP id d186mr1704696wmf.112.1490343941450; Fri, 24 Mar 2017 01:25:41 -0700 (PDT) Received: from autoinstall.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id u145sm1508472wmu.1.2017.03.24.01.25.40 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 24 Mar 2017 01:25:41 -0700 (PDT) Date: Fri, 24 Mar 2017 09:25:32 +0100 From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro To: Shahaf Shuler Cc: adrien.mazarguil@6wind.com, dev@dpdk.org, stable@dpdk.org Message-ID: <20170324082532.GX12013@autoinstall.dev.6wind.com> References: <1490272931-145077-1-git-send-email-shahafs@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1490272931-145077-1-git-send-email-shahafs@mellanox.com> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-stable] [PATCH] net/mlx5: fix TSO header size in case of VLAN insertion X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Mar 2017 08:25:41 -0000 On Thu, Mar 23, 2017 at 02:42:11PM +0200, Shahaf Shuler wrote: > When VLAN insertion is requested the vlan size must be added to the > calculation of the TSO header size, as it is not embedded within the > mbuf l2 length. > > Fixes: 98083fd482a2 ("net/mlx5: add hardware TSO support") > Cc: stable@dpdk.org > > Signed-off-by: Shahaf Shuler > --- > drivers/net/mlx5/mlx5_rxtx.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c > index 823aac8..9e8c6d0 100644 > --- a/drivers/net/mlx5/mlx5_rxtx.c > +++ b/drivers/net/mlx5/mlx5_rxtx.c > @@ -548,10 +548,11 @@ > buf->ol_flags & > (PKT_TX_TUNNEL_GRE | > PKT_TX_TUNNEL_VXLAN); > + uint8_t vlan_sz = (buf->ol_flags & > + PKT_TX_VLAN_PKT) ? 4 : 0; > > - tso_header_sz = buf->l2_len + buf->l3_len + > - buf->l4_len; > - > + tso_header_sz = buf->l2_len + vlan_sz + > + buf->l3_len + buf->l4_len; > if (is_tunneled && txq->tunnel_en) { > tso_header_sz += buf->outer_l2_len + > buf->outer_l3_len; > -- > 1.8.3.1 > Acked-by: Nelio Laranjeiro -- Nélio Laranjeiro 6WIND