From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id E01682BAE; Wed, 19 Apr 2017 08:27:11 +0200 (CEST) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Apr 2017 23:27:10 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,219,1488873600"; d="scan'208";a="89581347" Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.67.162]) by orsmga005.jf.intel.com with ESMTP; 18 Apr 2017 23:27:09 -0700 Date: Wed, 19 Apr 2017 14:24:03 +0800 From: Yuanhan Liu To: "Tan, Jianfeng" Cc: "dev@dpdk.org" , "olivier.matz@6wind.com" , "stable@dpdk.org" Message-ID: <20170419062403.GC31523@yliu-dev.sh.intel.com> References: <1492092776-57008-1-git-send-email-jianfeng.tan@intel.com> <1492569033-140348-1-git-send-email-jianfeng.tan@intel.com> <20170419055349.GA31523@yliu-dev.sh.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-stable] [PATCH v2] net/virtio-user: fix not working on 32-bit system X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Apr 2017 06:27:12 -0000 On Wed, Apr 19, 2017 at 06:21:59AM +0000, Tan, Jianfeng wrote: > > > > I've expected it to be plain english, something like following: > > > > /* > > * Return the physical address (or virtual address in case of > > * virtio-user) of mbuf data buffer. > > * > > * The address is firstly casted to the word size (sizeof(uintptr_t)) > > * before casting it to uint64_t. This is to make it work with different > > * combination of word size (64 bit and 32 bit) and virtio device > > * (virtio-pci and virtio-user). > > */ > > > > Okay to you? > > Yep, sounds better. Thanks! Good. Applied to dpdk-next-virtio, with above change. Thanks. --yliu