From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: Beilei Xing <beilei.xing@intel.com>
Cc: stable@dpdk.org
Subject: Re: [dpdk-stable] [PATCH] net/i40e: fix compile error
Date: Tue, 16 May 2017 18:16:23 +0800 [thread overview]
Message-ID: <20170516101623.GG3102@yliu-dev.sh.intel.com> (raw)
In-Reply-To: <1494916332-44423-1-git-send-email-beilei.xing@intel.com>
On Tue, May 16, 2017 at 02:32:12PM +0800, Beilei Xing wrote:
> [ backported from upstream commit c00f307f850a888f887688e88cb13be7e6964bd7 ]
Hmm, not quite sure why you have changed the title. The title was
"net/i40e: fix setup when bulk is disabled".
Applied to dpdk-stable, with the title changed back.
Thanks.
--yliu
>
> Testpmd failed to start when CONFIG_RTE_LIBRTE_I40E_RX_ALLOW_BULK_ALLOC
> is disabled, the root cause is the length of sw_ring and queue are
> incorrect with the above configuration.
>
> Fixes: 0be295312966 ("net/i40e: fix compile error")
>
> Signed-off-by: Beilei Xing <beilei.xing@intel.com>
> ---
> drivers/net/i40e/i40e_rxtx.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c
> index 1a007d6..602e40c 100644
> --- a/drivers/net/i40e/i40e_rxtx.c
> +++ b/drivers/net/i40e/i40e_rxtx.c
> @@ -1728,11 +1728,7 @@ i40e_dev_rx_queue_setup(struct rte_eth_dev *dev,
> rxq->rx_ring_phys_addr = rte_mem_phy2mch(rz->memseg_id, rz->phys_addr);
> rxq->rx_ring = (union i40e_rx_desc *)rz->addr;
>
> -#ifdef RTE_LIBRTE_I40E_RX_ALLOW_BULK_ALLOC
> len = (uint16_t)(nb_desc + RTE_PMD_I40E_RX_MAX_BURST);
> -#else
> - len = nb_desc;
> -#endif
>
> /* Allocate the software ring. */
> rxq->sw_ring =
> --
> 2.5.5
next prev parent reply other threads:[~2017-05-16 10:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-16 6:32 Beilei Xing
2017-05-16 10:16 ` Yuanhan Liu [this message]
2017-05-16 10:28 ` Xing, Beilei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170516101623.GG3102@yliu-dev.sh.intel.com \
--to=yuanhan.liu@linux.intel.com \
--cc=beilei.xing@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).