From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 146DF2901 for ; Tue, 16 May 2017 12:20:57 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 May 2017 03:20:56 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.38,349,1491289200"; d="scan'208";a="1130946202" Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.67.162]) by orsmga001.jf.intel.com with ESMTP; 16 May 2017 03:20:42 -0700 Date: Tue, 16 May 2017 18:16:23 +0800 From: Yuanhan Liu To: Beilei Xing Cc: stable@dpdk.org Message-ID: <20170516101623.GG3102@yliu-dev.sh.intel.com> References: <1494916332-44423-1-git-send-email-beilei.xing@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1494916332-44423-1-git-send-email-beilei.xing@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-stable] [PATCH] net/i40e: fix compile error X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 May 2017 10:20:58 -0000 On Tue, May 16, 2017 at 02:32:12PM +0800, Beilei Xing wrote: > [ backported from upstream commit c00f307f850a888f887688e88cb13be7e6964bd7 ] Hmm, not quite sure why you have changed the title. The title was "net/i40e: fix setup when bulk is disabled". Applied to dpdk-stable, with the title changed back. Thanks. --yliu > > Testpmd failed to start when CONFIG_RTE_LIBRTE_I40E_RX_ALLOW_BULK_ALLOC > is disabled, the root cause is the length of sw_ring and queue are > incorrect with the above configuration. > > Fixes: 0be295312966 ("net/i40e: fix compile error") > > Signed-off-by: Beilei Xing > --- > drivers/net/i40e/i40e_rxtx.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c > index 1a007d6..602e40c 100644 > --- a/drivers/net/i40e/i40e_rxtx.c > +++ b/drivers/net/i40e/i40e_rxtx.c > @@ -1728,11 +1728,7 @@ i40e_dev_rx_queue_setup(struct rte_eth_dev *dev, > rxq->rx_ring_phys_addr = rte_mem_phy2mch(rz->memseg_id, rz->phys_addr); > rxq->rx_ring = (union i40e_rx_desc *)rz->addr; > > -#ifdef RTE_LIBRTE_I40E_RX_ALLOW_BULK_ALLOC > len = (uint16_t)(nb_desc + RTE_PMD_I40E_RX_MAX_BURST); > -#else > - len = nb_desc; > -#endif > > /* Allocate the software ring. */ > rxq->sw_ring = > -- > 2.5.5