* [dpdk-stable] [dpdk-dev] [PATCH] event/octeontx: fix missing enqueue smp barrier
@ 2017-06-09 13:16 Jerin Jacob
2017-06-13 23:06 ` Eads, Gage
0 siblings, 1 reply; 3+ messages in thread
From: Jerin Jacob @ 2017-06-09 13:16 UTC (permalink / raw)
To: dev; +Cc: hemant.agrawal, gage.eads, harry.van.haaren, Jerin Jacob, stable
Typically RTE_EVENT_OP_NEW issued by the producer
lcore. To reflect the write changes issued by the
producer lcore on worker lcore, an SMP write barrier
is required on producer enqueue. Fixing the missing
rte_smp_wmb() on enqueue with RTE_EVENT_OP_NEW.
CC: stable@dpdk.org
Fixes: f10d322eff76 ("event/octeontx: support worker enqueue")
Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
---
drivers/event/octeontx/ssovf_worker.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/event/octeontx/ssovf_worker.c b/drivers/event/octeontx/ssovf_worker.c
index ad3fe684d..74e89015d 100644
--- a/drivers/event/octeontx/ssovf_worker.c
+++ b/drivers/event/octeontx/ssovf_worker.c
@@ -179,6 +179,7 @@ ssows_enq(void *port, const struct rte_event *ev)
switch (ev->op) {
case RTE_EVENT_OP_NEW:
+ rte_smp_wmb();
ssows_new_event(ws, ev);
break;
case RTE_EVENT_OP_FORWARD:
--
2.13.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-stable] [dpdk-dev] [PATCH] event/octeontx: fix missing enqueue smp barrier
2017-06-09 13:16 [dpdk-stable] [dpdk-dev] [PATCH] event/octeontx: fix missing enqueue smp barrier Jerin Jacob
@ 2017-06-13 23:06 ` Eads, Gage
2017-06-20 14:19 ` Jerin Jacob
0 siblings, 1 reply; 3+ messages in thread
From: Eads, Gage @ 2017-06-13 23:06 UTC (permalink / raw)
To: Jerin Jacob, dev; +Cc: hemant.agrawal, Van Haaren, Harry, stable
> -----Original Message-----
> From: Jerin Jacob [mailto:jerin.jacob@caviumnetworks.com]
> Sent: Friday, June 9, 2017 8:16 AM
> To: dev@dpdk.org
> Cc: hemant.agrawal@nxp.com; Eads, Gage <gage.eads@intel.com>; Van
> Haaren, Harry <harry.van.haaren@intel.com>; Jerin Jacob
> <jerin.jacob@caviumnetworks.com>; stable@dpdk.org
> Subject: [dpdk-dev] [PATCH] event/octeontx: fix missing enqueue smp barrier
>
> Typically RTE_EVENT_OP_NEW issued by the producer lcore. To reflect the
> write changes issued by the producer lcore on worker lcore, an SMP write
> barrier is required on producer enqueue. Fixing the missing
> rte_smp_wmb() on enqueue with RTE_EVENT_OP_NEW.
>
> CC: stable@dpdk.org
> Fixes: f10d322eff76 ("event/octeontx: support worker enqueue")
>
> Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Acked-by: Gage Eads <gage.eads@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-stable] [dpdk-dev] [PATCH] event/octeontx: fix missing enqueue smp barrier
2017-06-13 23:06 ` Eads, Gage
@ 2017-06-20 14:19 ` Jerin Jacob
0 siblings, 0 replies; 3+ messages in thread
From: Jerin Jacob @ 2017-06-20 14:19 UTC (permalink / raw)
To: Eads, Gage; +Cc: dev, hemant.agrawal, Van Haaren, Harry, stable
-----Original Message-----
> Date: Tue, 13 Jun 2017 23:06:54 +0000
> From: "Eads, Gage" <gage.eads@intel.com>
> To: Jerin Jacob <jerin.jacob@caviumnetworks.com>, "dev@dpdk.org"
> <dev@dpdk.org>
> CC: "hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com>, "Van Haaren, Harry"
> <harry.van.haaren@intel.com>, "stable@dpdk.org" <stable@dpdk.org>
> Subject: RE: [dpdk-dev] [PATCH] event/octeontx: fix missing enqueue smp
> barrier
>
>
>
> > -----Original Message-----
> > From: Jerin Jacob [mailto:jerin.jacob@caviumnetworks.com]
> > Sent: Friday, June 9, 2017 8:16 AM
> > To: dev@dpdk.org
> > Cc: hemant.agrawal@nxp.com; Eads, Gage <gage.eads@intel.com>; Van
> > Haaren, Harry <harry.van.haaren@intel.com>; Jerin Jacob
> > <jerin.jacob@caviumnetworks.com>; stable@dpdk.org
> > Subject: [dpdk-dev] [PATCH] event/octeontx: fix missing enqueue smp barrier
> >
> > Typically RTE_EVENT_OP_NEW issued by the producer lcore. To reflect the
> > write changes issued by the producer lcore on worker lcore, an SMP write
> > barrier is required on producer enqueue. Fixing the missing
> > rte_smp_wmb() on enqueue with RTE_EVENT_OP_NEW.
> >
> > CC: stable@dpdk.org
> > Fixes: f10d322eff76 ("event/octeontx: support worker enqueue")
> >
> > Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
>
> Acked-by: Gage Eads <gage.eads@intel.com>
Applied to dpdk-next-eventdev/master. Thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-06-20 14:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-09 13:16 [dpdk-stable] [dpdk-dev] [PATCH] event/octeontx: fix missing enqueue smp barrier Jerin Jacob
2017-06-13 23:06 ` Eads, Gage
2017-06-20 14:19 ` Jerin Jacob
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).