patches for DPDK stable branches
 help / color / mirror / Atom feed
* [dpdk-stable] [PATCH 06/22] crypto/qat: fix auth parameters for KASUMI
       [not found] <20170621074731.45013-1-pablo.de.lara.guarch@intel.com>
@ 2017-06-21  7:47 ` Pablo de Lara
  0 siblings, 0 replies; only message in thread
From: Pablo de Lara @ 2017-06-21  7:47 UTC (permalink / raw)
  To: pablo.de.lara.guarch; +Cc: dev, stable

QAT PMD was assuming that cipher IV was always prepended,
before the input buffer, but it is not necessary to have it
there, only the auth IV and the input buffer needs to be
contiguous.

It was also assuming that the IV was starting at offset 0,
which is not always the case.

Fixes: d4f2745300e0 ("crypto/qat: add KASUMI")
CC: stable@dpdk.org

Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
---
 drivers/crypto/qat/qat_crypto.c | 11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)

diff --git a/drivers/crypto/qat/qat_crypto.c b/drivers/crypto/qat/qat_crypto.c
index 3bf3133..345fcb9 100644
--- a/drivers/crypto/qat/qat_crypto.c
+++ b/drivers/crypto/qat/qat_crypto.c
@@ -1011,14 +1011,9 @@ qat_write_hw_desc_entry(struct rte_crypto_op *op, uint8_t *out_msg,
 
 			if (ctx->qat_hash_alg ==
 					ICP_QAT_HW_AUTH_ALGO_KASUMI_F9) {
-				if (do_cipher) {
-					auth_len = auth_len + auth_ofs + 1 -
-						ICP_QAT_HW_KASUMI_BLK_SZ;
-					auth_ofs = ICP_QAT_HW_KASUMI_BLK_SZ;
-				} else {
-					auth_len = auth_len + auth_ofs + 1;
-					auth_ofs = 0;
-				}
+				/* Auth IV and message is contiguous + direction bit */
+				auth_len = auth_len + ICP_QAT_HW_KASUMI_BLK_SZ + 1;
+				auth_ofs -= ICP_QAT_HW_KASUMI_BLK_SZ;
 			}
 
 		} else if (ctx->qat_hash_alg ==
-- 
2.9.4

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2017-06-21 15:47 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20170621074731.45013-1-pablo.de.lara.guarch@intel.com>
2017-06-21  7:47 ` [dpdk-stable] [PATCH 06/22] crypto/qat: fix auth parameters for KASUMI Pablo de Lara

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).