From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f180.google.com (mail-pf0-f180.google.com [209.85.192.180]) by dpdk.org (Postfix) with ESMTP id A104D2B9D for ; Sat, 8 Jul 2017 05:12:30 +0200 (CEST) Received: by mail-pf0-f180.google.com with SMTP id q85so25168464pfq.1 for ; Fri, 07 Jul 2017 20:12:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fridaylinux-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=or31dGSn9OX7Wpea1+bUH9SpG9bVy8MktW/PLtat2mw=; b=gdK85C4Vtx/Nd5sOfMeEiVuJwbws3Kp1pidK0Oy7KhJs5Iyr6EQoNwN1JOComhSqSd RLNSMF3Tu9ZBaAJjXM2XvnvvRQ+BHLZNhnupnyP1s8iKTnPpOWbXfbDbdzFrpAZl5qTX 9d9M3YFM20HsA71CQXEA8KhF7L/H60eM/NSYkwPBFVfHyMkOSpxkq+hfQeD1mFwj/MOx v1yCHCw5dHU+qn7oH4FuCLI/+lHgh0H/UQx4SiA40fR6mpD1hS1vSsP8AvBExdTjL5P6 nFK4Dl9FR/25v2wLawIvjOoTfZxYRAXnsMX9ZlXypGzjZsBr49+7uaDi0tDfrfdcHde5 F/BQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=or31dGSn9OX7Wpea1+bUH9SpG9bVy8MktW/PLtat2mw=; b=UPsXaGselDxcARMsZkyqAvTLk8yrPyYdTOWwKRnVbjplgi/a6wOI2MfNU5evABU/p2 X2pp+cYJS11FeGRseEVkkgk2Qca+OKz4OfXLBFVOtXljYUUlYTEmxK8CGPRMzavIF1uM wUgRixFrX3HhyUiCIIsTWB/FXzk5gZujwh4vgs3zJuZBeTV3pDnRT6mxfJ0hRiSLRTer e54PXveMv1mRy07hPyu/FuxvC7Kc2qy9e7aKL09Qcc8KJ//JWbUI0P1zlmjw6NvhWbxh SEENIkHNvQXR9O5FLEJHfvKuIo3RV9cEC9Hjvx8Fe+DobzLOCZXWw/shYtBoNoQwqAcC oO/w== X-Gm-Message-State: AIVw112/VrPltiZPsCJKj68rSstvL6eACaHYgmMPHise5GYshhxMaGrS 9qisFZUMoCJWI7NI X-Received: by 10.84.177.195 with SMTP id x61mr6301555plb.44.1499483549860; Fri, 07 Jul 2017 20:12:29 -0700 (PDT) Received: from yliu-home ([45.63.61.64]) by smtp.gmail.com with ESMTPSA id h80sm10652379pfk.80.2017.07.07.20.12.27 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 07 Jul 2017 20:12:28 -0700 (PDT) Date: Sat, 8 Jul 2017 11:12:22 +0800 From: Yuanhan Liu To: Stephen Hemminger Cc: maxime.coquelin@redhat.com, dev@dpdk.org, stable@dpdk.org Message-ID: <20170708031222.GA11626@yliu-home> References: <20170707195250.22259-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170707195250.22259-1-stephen@networkplumber.org> User-Agent: Mutt/1.5.24 (2015-08-30) Subject: Re: [dpdk-stable] [PATCH 0/2] virtio fix false offload claims X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 08 Jul 2017 03:12:31 -0000 On Fri, Jul 07, 2017 at 12:52:48PM -0700, Stephen Hemminger wrote: > While doing code for Hyper-V, noticed that the virtio driver was > confused about receive versus transmit offloads. The virtio > checksum offload is L4 (TCP/UDP) only, not IPv4. Also, TSO > and LRO are not the same. > > This may break some program that was assuming it was getting offloads > that it wasn't. Applied to dpdk-next-virtio. And I think they should be backported to stable releases, thus, Cc: stable@dpdk.org Thanks. --yliu > > Stephen Hemminger (2): > virtio: don't falsely claim to do IP checksum > virtio: don't claim to support LRO > > drivers/net/virtio/virtio_ethdev.c | 30 +++++------------------------- > 1 file changed, 5 insertions(+), 25 deletions(-) > > -- > 2.11.0