From: Stephen Hemminger <stephen@networkplumber.org>
To: Qi Zhang <qi.z.zhang@intel.com>
Cc: jingjing.wu@intel.com, beilei.xing@intel.com,
ferruh.yigit@intel.com, dev@dpdk.org, helin.zhang@intel.com,
stable@dpdk.org
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] net/i40e: fix VF Tx bytes
Date: Tue, 11 Jul 2017 12:56:20 -0700 [thread overview]
Message-ID: <20170711125620.331fc19e@xeon-e3> (raw)
In-Reply-To: <1499543665-16166-1-git-send-email-qi.z.zhang@intel.com>
On Sat, 8 Jul 2017 15:54:25 -0400
Qi Zhang <qi.z.zhang@intel.com> wrote:
> CRC size on Tx path is not necessary to be excluded.
>
> Fixes: 98abce237ba7 ("net/i40e: fix VF statistics")
> Cc: stable@dpdk.org
>
> Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
> ---
> drivers/net/i40e/i40e_ethdev.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
> index 71cb7d3..0585869 100644
> --- a/drivers/net/i40e/i40e_ethdev.c
> +++ b/drivers/net/i40e/i40e_ethdev.c
> @@ -2353,9 +2353,6 @@ i40e_update_vsi_stats(struct i40e_vsi *vsi)
> i40e_stat_update_48(hw, I40E_GLV_BPTCH(idx), I40E_GLV_BPTCL(idx),
> vsi->offset_loaded, &oes->tx_broadcast,
> &nes->tx_broadcast);
> - /* exclude CRC bytes */
> - nes->tx_bytes -= (nes->tx_unicast + nes->tx_multicast +
> - nes->tx_broadcast) * ETHER_CRC_LEN;
> /* GLV_TDPC not supported */
> i40e_stat_update_32(hw, I40E_GLV_TEPC(idx), vsi->offset_loaded,
> &oes->tx_errors, &nes->tx_errors);
Whether or not CRC is included in length statistics has been an ongoing
problem in DPDK. The Linux and BSD standard is to exclude CRC from number
of bytes; Cisco includes it, and Juniper does not.
For application consistency across real and virtual devices, all
statistics for both transmit and receive in DPDK must NOT include CRC bytes.
Is this still an issue in DPDK drivers? Do I need to put it on the
TAB agenda? Is it not clear in the documentation?
next prev parent reply other threads:[~2017-07-11 19:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-08 19:54 [dpdk-stable] " Qi Zhang
2017-07-10 2:45 ` Xing, Beilei
2017-07-11 19:56 ` Stephen Hemminger [this message]
2017-07-17 9:17 ` [dpdk-stable] [dpdk-dev] " Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170711125620.331fc19e@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=helin.zhang@intel.com \
--cc=jingjing.wu@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).