From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f173.google.com (mail-pf0-f173.google.com [209.85.192.173]) by dpdk.org (Postfix) with ESMTP id 24417374C for ; Tue, 11 Jul 2017 21:56:29 +0200 (CEST) Received: by mail-pf0-f173.google.com with SMTP id q85so1195573pfq.1 for ; Tue, 11 Jul 2017 12:56:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=x8c13ANBeKvGl1eMG+qGizE/McP7WlHfaeUoCRO5OkM=; b=Tt5qZUZJ7uLTY6UJ7hGedfxhHlzd4pNo1fYECVEqV6QK5Y7L92Wb+8QaTB7iI+ZH1T JnipyE/fuBTjUyqlsHGkgAfk5WYGBeoS3OQPY68Z74FIRuaDBT5NJU8CgJtCfq/TC1/8 W1dfI6DqdNeazqj2xecpP6av+6EbRxNdo0hP6yQhLVxOUtedce3x7l+3zzjZ5r8P/FkL WNNnVMy9SAAccV+W6J0zpw/b8qeF2c4Vo5rbaqjcp+DnGFODssg3im+XPd0BtNuRlIdy AU0sdJJswosyowWSVRu/jFRcvGkDrGmmT5QYHuQq34SukKw/jRMjWyov1nFNEPyrjF5j zxWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=x8c13ANBeKvGl1eMG+qGizE/McP7WlHfaeUoCRO5OkM=; b=toJFj53HJzsgRdf4Cl9fvJOfJYJKg1ptp1DPfjUx4ooZCCdLi8RZ2MgEa6giNtwuMo L782Oj7L0Bhu7VSvjexAbEs/NR4Zkr4hvyw47mLd2/9YDyRaB2F3h5/Iz9ozHyN6+2TD B7ZtujHlMe8m1fm2K4RY8xBb2gq93NswJj+IvKt5NgJkVvqp/kcTZCKWDE3Dtdcv+yYd KGrlI58bdB3igw+6ZH3eJu5cZRwTGswOAfVIhLKqqNlF3TDdQKYAMr9IBNte3SuvsGPG yV9xoyp7Hpkg9thfvWvVL+yaQ3/TAKLG0qIxoOATHNrBlQdgNX43vW81AH4S6vhjAgee 4iag== X-Gm-Message-State: AIVw112lJ+WAv1ecSqhNB4H1QU6wRjwLVnBPsPhdMMddQbsA6XEUoIXE ZOkwgCbU6A8+0Sr3 X-Received: by 10.84.130.47 with SMTP id 44mr93793plc.192.1499802989136; Tue, 11 Jul 2017 12:56:29 -0700 (PDT) Received: from xeon-e3 (76-14-207-240.or.wavecable.com. [76.14.207.240]) by smtp.gmail.com with ESMTPSA id e77sm214610pfk.123.2017.07.11.12.56.28 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 11 Jul 2017 12:56:28 -0700 (PDT) Date: Tue, 11 Jul 2017 12:56:20 -0700 From: Stephen Hemminger To: Qi Zhang Cc: jingjing.wu@intel.com, beilei.xing@intel.com, ferruh.yigit@intel.com, dev@dpdk.org, helin.zhang@intel.com, stable@dpdk.org Message-ID: <20170711125620.331fc19e@xeon-e3> In-Reply-To: <1499543665-16166-1-git-send-email-qi.z.zhang@intel.com> References: <1499543665-16166-1-git-send-email-qi.z.zhang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] net/i40e: fix VF Tx bytes X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Jul 2017 19:56:30 -0000 On Sat, 8 Jul 2017 15:54:25 -0400 Qi Zhang wrote: > CRC size on Tx path is not necessary to be excluded. > > Fixes: 98abce237ba7 ("net/i40e: fix VF statistics") > Cc: stable@dpdk.org > > Signed-off-by: Qi Zhang > --- > drivers/net/i40e/i40e_ethdev.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c > index 71cb7d3..0585869 100644 > --- a/drivers/net/i40e/i40e_ethdev.c > +++ b/drivers/net/i40e/i40e_ethdev.c > @@ -2353,9 +2353,6 @@ i40e_update_vsi_stats(struct i40e_vsi *vsi) > i40e_stat_update_48(hw, I40E_GLV_BPTCH(idx), I40E_GLV_BPTCL(idx), > vsi->offset_loaded, &oes->tx_broadcast, > &nes->tx_broadcast); > - /* exclude CRC bytes */ > - nes->tx_bytes -= (nes->tx_unicast + nes->tx_multicast + > - nes->tx_broadcast) * ETHER_CRC_LEN; > /* GLV_TDPC not supported */ > i40e_stat_update_32(hw, I40E_GLV_TEPC(idx), vsi->offset_loaded, > &oes->tx_errors, &nes->tx_errors); Whether or not CRC is included in length statistics has been an ongoing problem in DPDK. The Linux and BSD standard is to exclude CRC from number of bytes; Cisco includes it, and Juniper does not. For application consistency across real and virtual devices, all statistics for both transmit and receive in DPDK must NOT include CRC bytes. Is this still an issue in DPDK drivers? Do I need to put it on the TAB agenda? Is it not clear in the documentation?