From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f43.google.com (mail-pg0-f43.google.com [74.125.83.43]) by dpdk.org (Postfix) with ESMTP id 73C2D11F5 for ; Tue, 29 Aug 2017 11:28:07 +0200 (CEST) Received: by mail-pg0-f43.google.com with SMTP id t3so9357165pgt.0 for ; Tue, 29 Aug 2017 02:28:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fridaylinux-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=co9QSeVovccWyDffGr1pO9kwLGf4qcbhf6JxA6sICt0=; b=nAjXHPzMHjBe39LJ7kMd1wLaEjBcB0uYuvuwccz4JSMcz3/zPECr9Uy+bag0fk5jdr fuOXIXxx0HwSLB6N/hj9CI9XVmzuVv1lC9Uyy00QXFIWgK00DL16q/twxzuz1eCD/X5+ 5zmIMvLTShNFxYlOgoI/Hwpl9+rQ+VBA94c1S+oJw0xhF9eMQIxhCnFCSTVmzeu+peGZ MYL+iAKD3ryQP2UVTujVYfczGTI7FxYYDwIE39Atpd5ucu5GoIc4hoxFiqTPGV/0Wb1b dbY8ufouwW9KTOfZgmhB5/j/xDOk/8UkwgLV8jrS4S1oaco91UIbmX8tWB5ihcIVHuhU e9Og== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=co9QSeVovccWyDffGr1pO9kwLGf4qcbhf6JxA6sICt0=; b=iDVIOVJdzyPWIAYjdyNdKXZyphFGe6QZ8XVRytOqjOYYWD4oxPdOLlBFFR7gnGj02d ccIn4sLBkn5WsI+29piNxEuprkneS/gh8pkRB68kvLcmlBZzl6h5dFd8opP8MRM8IIio qeZtxNbb58v++UQa8DZz6hWzom9N92gGLyHQZiqbmmL/DHRH3jVmU/oZ622K9DwLnYlT AUANL2tyG+ccnbxykx78t70fmoYPHZQrh/VrsR7y/879geItqhhgqGn2V8JyZbrSqmR+ PRYpbPD2p9Qj+2JKXeMA4AF7hczSHfex9FB+QpS1DfGDflZtn1Mxak9Qz/eh7KvgxQgi m+1g== X-Gm-Message-State: AHYfb5hYyHnj/yoZ8sB9L0xaIxVLEc0HfMHVew854ziJhuas+/vNeKh0 zwasJl8Op6Z5pZRE X-Received: by 10.84.131.40 with SMTP id 37mr341988pld.116.1503998886259; Tue, 29 Aug 2017 02:28:06 -0700 (PDT) Received: from yliu-home ([45.63.61.64]) by smtp.gmail.com with ESMTPSA id x4sm4094060pfx.63.2017.08.29.02.28.03 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 29 Aug 2017 02:28:05 -0700 (PDT) Date: Tue, 29 Aug 2017 17:27:57 +0800 From: Yuanhan Liu To: Stephen Hemminger Cc: dpdk stable Message-ID: <20170829092757.GC9736@yliu-home> References: <1503307878-16728-1-git-send-email-yliu@fridaylinux.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1503307878-16728-1-git-send-email-yliu@fridaylinux.org> User-Agent: Mutt/1.5.24 (2015-08-30) Subject: Re: [dpdk-stable] patch 'net/virtio: do not claim to support LRO' has been queued to stable release 17.05.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Aug 2017 09:28:07 -0000 On Mon, Aug 21, 2017 at 05:30:15PM +0800, Yuanhan Liu wrote: > Hi, > > FYI, your patch has been queued to stable release 17.05.2 > > Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. > It will be pushed if I get no objections before 08/24/17. So please > shout if anyone has objections. According to following discussions, I'd like to drop this one and another one ("net/virtio: do not falsely claim to do IP checksum"). http://dpdk.org/ml/archives/dev/2017-August/073341.html --yliu > > --- > >From 6de4d8eee1aafaf8eb8316501aa87d9874cf83bc Mon Sep 17 00:00:00 2001 > From: Stephen Hemminger > Date: Fri, 7 Jul 2017 12:52:50 -0700 > Subject: [PATCH] net/virtio: do not claim to support LRO > > [ upstream commit 701a64622c2653c0736042d2f790081db79afdc7 ] > > The current virtio supports Transmit Segmentation Offload, but > does not really support Large Receive Offload. The driver was confusing > the two offloads. > > Fixes: 86d59b21468a ("net/virtio: support LRO") > > Signed-off-by: Stephen Hemminger > Acked-by: Yuanhan Liu > --- > drivers/net/virtio/virtio_ethdev.c | 22 ++-------------------- > 1 file changed, 2 insertions(+), 20 deletions(-) > > diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c > index 1651c59..d65667c 100644 > --- a/drivers/net/virtio/virtio_ethdev.c > +++ b/drivers/net/virtio/virtio_ethdev.c > @@ -1659,11 +1659,8 @@ virtio_dev_configure(struct rte_eth_dev *dev) > { > const struct rte_eth_rxmode *rxmode = &dev->data->dev_conf.rxmode; > struct virtio_hw *hw = dev->data->dev_private; > - uint64_t req_features; > - int ret; > > PMD_INIT_LOG(DEBUG, "configure"); > - req_features = VIRTIO_PMD_DEFAULT_GUEST_FEATURES; > > /* Virtio does L4 checksum but not L3! */ > if (rxmode->hw_ip_checksum) { > @@ -1671,23 +1668,10 @@ virtio_dev_configure(struct rte_eth_dev *dev) > "virtio does not support IP checksum"); > return -ENOTSUP; > } > - if (rxmode->enable_lro) > - req_features |= > - (1ULL << VIRTIO_NET_F_GUEST_TSO4) | > - (1ULL << VIRTIO_NET_F_GUEST_TSO6); > - > - /* if request features changed, reinit the device */ > - if (req_features != hw->req_guest_features) { > - ret = virtio_init_device(dev, req_features); > - if (ret < 0) > - return ret; > - } > > - if (rxmode->enable_lro && > - (!vtpci_with_feature(hw, VIRTIO_NET_F_GUEST_TSO4) || > - !vtpci_with_feature(hw, VIRTIO_NET_F_GUEST_TSO4))) { > + if (rxmode->enable_lro) { > PMD_DRV_LOG(NOTICE, > - "lro not available on this host"); > + "virtio does not support Large Receive Offload"); > return -ENOTSUP; > } > > @@ -1913,8 +1897,6 @@ virtio_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info) > } > tso_mask = (1ULL << VIRTIO_NET_F_GUEST_TSO4) | > (1ULL << VIRTIO_NET_F_GUEST_TSO6); > - if ((host_features & tso_mask) == tso_mask) > - dev_info->rx_offload_capa |= DEV_RX_OFFLOAD_TCP_LRO; > > dev_info->tx_offload_capa = 0; > if (hw->guest_features & (1ULL << VIRTIO_NET_F_CSUM)) { > -- > 2.7.4