Re: [dpdk-stable] [PATCH 8/9] net/virtio: keep Rx handler whatever the Tx queue config

[Yuanhan Liu <yliu@fridaylinux.org>]

On Fri, Sep 01, 2017 at 11:58:07AM +0200, Olivier MATZ wrote:
> On Fri, Sep 01, 2017 at 05:25:38PM +0800, Yuanhan Liu wrote:
> > On Thu, Aug 31, 2017 at 03:40:14PM +0200, Olivier Matz wrote:
> > > Split use_simple_rxtx into use_simple_rx and use_simple_tx,
> > > and ensure that only use_simple_tx is updated when txq flags
> > > forces to use the standard Tx handler.
> > 
> > I think it's a good idea to split it.
> > 
> > > This change is also useful for next commit (disable simple Rx
> > > path when Rx checksum is requested).
> > > 
> > > Cc: stable@dpdk.org
> > 
> > But again, I don't think it's a good idea to put them (including the
> > next patch) to stable releases.
> 
> Yes, you're right this one is more an enhancement than a fix: it
> just selects a faster handler if it's possible.

Exactly.

> But next one is a fix: it must not select the simple handler if
> offload is requested.
> 
> If these commits are not pushed in stable, it's not a problem for
> me, so I let you decide. In that case, I will remove the Cc: stable
> from the last 3 commits. Do you confirm?

Yes, I think it's better to drop the cc stable tag.

> Thanks for the review.

Thanks for the work!

	--yliu