From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <nelio.laranjeiro@6wind.com>
Received: from mail-wm0-f51.google.com (mail-wm0-f51.google.com [74.125.82.51])
by dpdk.org (Postfix) with ESMTP id 384357D08
for <stable@dpdk.org>; Mon, 4 Sep 2017 16:57:51 +0200 (CEST)
Received: by mail-wm0-f51.google.com with SMTP id i145so6384061wmf.1
for <stable@dpdk.org>; Mon, 04 Sep 2017 07:57:51 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=6wind-com.20150623.gappssmtp.com; s=20150623;
h=date:from:to:cc:subject:message-id:references:mime-version
:content-disposition:content-transfer-encoding:in-reply-to
:user-agent; bh=VrPmsA5wKnaztB3MJbJZqxIMkQ9uEQw00Tb+NBO2Tzg=;
b=CrPqRi/nsykeWQhQA/7uRNKvO2QzdbfkQqpJcihe1UXlmugRFg9Fh0c3NlZ8QyCKu5
t2eSyTR22bneXBxXGdP4RXRiW5KMYIyyz/MEohK8mNU+YNaNRlN4iVzLpLBuBm9+uaFq
GZRueAn8i4BTaN43mBffEiRWqHznZv2CGcOcbw82POo22oEp7l//YJXHkDrQSZGwAiMj
N17yswZrTteaYRgeMgxtmR3NJA/+yjz8i13hBxQNqYfxYc+1dI7tnj9BPhm7YfiCdoc+
CxZ5xTS5DcWUitLhkarpjOJucVUgy/vwnYAHftUEjfgvye4qrX6wuwNAQR6YL05FnBIa
wmNQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:date:from:to:cc:subject:message-id:references
:mime-version:content-disposition:content-transfer-encoding
:in-reply-to:user-agent;
bh=VrPmsA5wKnaztB3MJbJZqxIMkQ9uEQw00Tb+NBO2Tzg=;
b=KRDqU1b561d7fkRfz1LETLRfoX8qZr/cv1Dx3e5bhhRetfkIfZxcj10w/l7tm+LYXo
Huj7xPP2J36XY4+nHULDdZEa6S5dofgh9iat+DKLDfuoLP4NbyK5W1fW0hR0ODZjKREL
DtdqqpjdngkoDPjRyUWzn9i4PmZhhiVp3XMHpRjsAd5ORsTDakMMJ59fV9pyPj4oKmKm
s02SksM4x/cCPL+prkmCaDZA7A+USFUQZujXK9q9JUcYW0gH+v96CHTW0PAD6Tuxb/4u
UfHiBKbvC2fAbfl+ecqPl11PADH8CU1tyU2gVg7WXD5nhh7BaG8Ze46p9kaSTsWS7aBV
+EhA==
X-Gm-Message-State: AHPjjUj4IC/13pgLbBNJ8DOHOFxhylG+5OpAAHcCvx3ewZwRvbp9+MKD
M151/iKJMVVJFWaw
X-Google-Smtp-Source: ADKCNb7bF67wEkdB5W598coU21qRe9ETFjq7+lUyZu2+zIqswqp93DhLzLsEehwX3Yybl572qkUFDQ==
X-Received: by 10.28.208.75 with SMTP id h72mr318568wmg.163.1504537070798;
Mon, 04 Sep 2017 07:57:50 -0700 (PDT)
Received: from localhost (lan31-h07-89-80-147-20.dsl.sta.abo.bbox.fr.
[89.80.147.20])
by smtp.gmail.com with ESMTPSA id u65sm13433131wrb.18.2017.09.04.07.57.50
(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
Mon, 04 Sep 2017 07:57:50 -0700 (PDT)
Date: Mon, 4 Sep 2017 16:57:48 +0200
From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro <nelio.laranjeiro@6wind.com>
To: Shahaf Shuler <shahafs@mellanox.com>
Cc: adrien.mazarguil@6wind.com, dev@dpdk.org, stable@dpdk.org
Message-ID: <20170904145748.fjd3mwroy2pwwdw4@localhost>
References: <20170823073358.116786-1-shahafs@mellanox.com>
<1e7320c4ee4162c9e509b7560be215077f43ca87.1504076528.git.shahafs@mellanox.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1e7320c4ee4162c9e509b7560be215077f43ca87.1504076528.git.shahafs@mellanox.com>
User-Agent: NeoMutt/20170113 (1.7.2)
Subject: Re: [dpdk-stable] [PATCH v2 1/2] net/mlx5: fix num seg assumption
on vPMD
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/stable>,
<mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/stable>,
<mailto:stable-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 04 Sep 2017 14:57:51 -0000
On Wed, Aug 30, 2017 at 10:07:07AM +0300, Shahaf Shuler wrote:
> vPMD Tx function assumes that after the scatter of the
> multi-segment packets the next packet will be a single segment packet.
>
> This is not current as the function can return due to lack of resources
> without sending all of the multi-segment mbufs sequence.
>
> Fixes: 6cb559d67b83 ("net/mlx5: add vectorized Rx/Tx burst for x86")
> Cc: stable@dpdk.org
>
> Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
> Acked-by: Yongseok Koh <yskoh@mellanox.com>
> ---
> This patch should be applied only after the series:
> http://dpdk.org/dev/patchwork/patch/27367/
>
> on v2:
> - different approach to fix the issue.
> ---
> drivers/net/mlx5/mlx5_rxtx_vec_sse.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/mlx5/mlx5_rxtx_vec_sse.c b/drivers/net/mlx5/mlx5_rxtx_vec_sse.c
> index 37854a73b..f89762ff8 100644
> --- a/drivers/net/mlx5/mlx5_rxtx_vec_sse.c
> +++ b/drivers/net/mlx5/mlx5_rxtx_vec_sse.c
> @@ -112,8 +112,7 @@ txq_wr_dseg_v(struct txq *txq, __m128i *dseg,
> }
>
> /**
> - * Count the number of continuous single segment packets. The first packet must
> - * be a single segment packet.
> + * Count the number of continuous single segment packets.
> *
> * @param pkts
> * Pointer to array of packets.
> @@ -130,9 +129,8 @@ txq_check_multiseg(struct rte_mbuf **pkts, uint16_t pkts_n)
>
> if (!pkts_n)
> return 0;
> - assert(NB_SEGS(pkts[0]) == 1);
> /* Count the number of continuous single segment packets. */
> - for (pos = 1; pos < pkts_n; ++pos)
> + for (pos = 0; pos < pkts_n; ++pos)
> if (NB_SEGS(pkts[pos]) > 1)
> break;
> return pos;
> --
> 2.12.0
Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
--
Nélio Laranjeiro
6WIND