* [dpdk-stable] [PATCH 2/3] net/mlx5: fix TSO MLNX OFED 3.3 verification
[not found] ` <bf3a648369b1b8d2023819a1372c08c6cc5f0de8.1504525643.git.shacharbe@mellanox.com>
@ 2017-09-04 11:48 ` Shachar Beiser
2017-09-04 15:15 ` Nélio Laranjeiro
2017-09-04 11:48 ` [dpdk-stable] [PATCH 3/3] net/mlx5: fix interrupt enable return value Shachar Beiser
` (2 subsequent siblings)
3 siblings, 1 reply; 14+ messages in thread
From: Shachar Beiser @ 2017-09-04 11:48 UTC (permalink / raw)
To: dev; +Cc: Shachar Beiser, Adrien Mazarguil, Nelio Laranjeiro, stable
Fixes: 3cf87e68d97b ("net/mlx5: remove old MLNX OFED 3.3 verification")
Cc: stable@dpdk.org
Signed-off-by: Shachar Beiser <shacharbe@mellanox.com>
---
drivers/net/mlx5/mlx5_prm.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/net/mlx5/mlx5_prm.h b/drivers/net/mlx5/mlx5_prm.h
index 608072f..8b82b5e 100644
--- a/drivers/net/mlx5/mlx5_prm.h
+++ b/drivers/net/mlx5/mlx5_prm.h
@@ -89,9 +89,6 @@
/* Default max packet length to be inlined. */
#define MLX5_EMPW_MAX_INLINE_LEN (4U * MLX5_WQE_SIZE)
-#ifndef HAVE_VERBS_MLX5_OPCODE_TSO
-#define MLX5_OPCODE_TSO MLX5_OPCODE_LSO_MPW /* Compat with OFED 3.3. */
-#endif
#define MLX5_OPC_MOD_ENHANCED_MPSW 0
#define MLX5_OPCODE_ENHANCED_MPSW 0x29
--
1.8.3.1
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [dpdk-stable] [PATCH 2/3] net/mlx5: fix TSO MLNX OFED 3.3 verification
2017-09-04 11:48 ` [dpdk-stable] [PATCH 2/3] net/mlx5: fix TSO MLNX OFED 3.3 verification Shachar Beiser
@ 2017-09-04 15:15 ` Nélio Laranjeiro
0 siblings, 0 replies; 14+ messages in thread
From: Nélio Laranjeiro @ 2017-09-04 15:15 UTC (permalink / raw)
To: Shachar Beiser; +Cc: dev, Adrien Mazarguil, stable
On Mon, Sep 04, 2017 at 11:48:46AM +0000, Shachar Beiser wrote:
> Fixes: 3cf87e68d97b ("net/mlx5: remove old MLNX OFED 3.3 verification")
> Cc: stable@dpdk.org
>
> Signed-off-by: Shachar Beiser <shacharbe@mellanox.com>
> ---
> drivers/net/mlx5/mlx5_prm.h | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/net/mlx5/mlx5_prm.h b/drivers/net/mlx5/mlx5_prm.h
> index 608072f..8b82b5e 100644
> --- a/drivers/net/mlx5/mlx5_prm.h
> +++ b/drivers/net/mlx5/mlx5_prm.h
> @@ -89,9 +89,6 @@
> /* Default max packet length to be inlined. */
> #define MLX5_EMPW_MAX_INLINE_LEN (4U * MLX5_WQE_SIZE)
>
> -#ifndef HAVE_VERBS_MLX5_OPCODE_TSO
> -#define MLX5_OPCODE_TSO MLX5_OPCODE_LSO_MPW /* Compat with OFED 3.3. */
> -#endif
>
> #define MLX5_OPC_MOD_ENHANCED_MPSW 0
> #define MLX5_OPCODE_ENHANCED_MPSW 0x29
> --
> 1.8.3.1
>
Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
--
Nélio Laranjeiro
6WIND
^ permalink raw reply [flat|nested] 14+ messages in thread
* [dpdk-stable] [PATCH 3/3] net/mlx5: fix interrupt enable return value
[not found] ` <bf3a648369b1b8d2023819a1372c08c6cc5f0de8.1504525643.git.shacharbe@mellanox.com>
2017-09-04 11:48 ` [dpdk-stable] [PATCH 2/3] net/mlx5: fix TSO MLNX OFED 3.3 verification Shachar Beiser
@ 2017-09-04 11:48 ` Shachar Beiser
2017-09-04 15:24 ` Nélio Laranjeiro
2017-09-05 13:04 ` [dpdk-stable] [PATCH v2 2/3] net/mlx5: fix TSO MLNX OFED 3.3 verification Shachar Beiser
2017-09-05 13:04 ` [dpdk-stable] [PATCH v2 3/3] net/mlx5: fix interrupt enable return value Shachar Beiser
3 siblings, 1 reply; 14+ messages in thread
From: Shachar Beiser @ 2017-09-04 11:48 UTC (permalink / raw)
To: dev; +Cc: Shachar Beiser, Adrien Mazarguil, Nelio Laranjeiro, stable
Fixes: 3c7d44af252a ("net/mlx5: support user space Rx interrupt event")
Cc: stable@dpdk.org
Signed-off-by: Shachar Beiser <shacharbe@mellanox.com>
---
drivers/net/mlx5/mlx5_rxq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c
index 437dc02..24887fb 100644
--- a/drivers/net/mlx5/mlx5_rxq.c
+++ b/drivers/net/mlx5/mlx5_rxq.c
@@ -1330,7 +1330,7 @@
struct priv *priv = mlx5_get_priv(dev);
struct rxq *rxq = (*priv->rxqs)[rx_queue_id];
struct rxq_ctrl *rxq_ctrl = container_of(rxq, struct rxq_ctrl, rxq);
- int ret;
+ int ret = 0;
if (!rxq || !rxq_ctrl->channel) {
ret = EINVAL;
--
1.8.3.1
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [dpdk-stable] [PATCH 3/3] net/mlx5: fix interrupt enable return value
2017-09-04 11:48 ` [dpdk-stable] [PATCH 3/3] net/mlx5: fix interrupt enable return value Shachar Beiser
@ 2017-09-04 15:24 ` Nélio Laranjeiro
2017-09-05 9:04 ` Shachar Beiser
0 siblings, 1 reply; 14+ messages in thread
From: Nélio Laranjeiro @ 2017-09-04 15:24 UTC (permalink / raw)
To: Shachar Beiser; +Cc: dev, Adrien Mazarguil, stable
On Mon, Sep 04, 2017 at 11:48:47AM +0000, Shachar Beiser wrote:
> Fixes: 3c7d44af252a ("net/mlx5: support user space Rx interrupt event")
It should fix commit e1016cb733 ("net/mlx5: fix Rx interrupts management")
> Cc: stable@dpdk.org
>
> Signed-off-by: Shachar Beiser <shacharbe@mellanox.com>
> ---
> drivers/net/mlx5/mlx5_rxq.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c
> index 437dc02..24887fb 100644
> --- a/drivers/net/mlx5/mlx5_rxq.c
> +++ b/drivers/net/mlx5/mlx5_rxq.c
> @@ -1330,7 +1330,7 @@
> struct priv *priv = mlx5_get_priv(dev);
> struct rxq *rxq = (*priv->rxqs)[rx_queue_id];
> struct rxq_ctrl *rxq_ctrl = container_of(rxq, struct rxq_ctrl, rxq);
> - int ret;
> + int ret = 0;
>
> if (!rxq || !rxq_ctrl->channel) {
> ret = EINVAL;
> --
> 1.8.3.1
>
--
Nélio Laranjeiro
6WIND
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [dpdk-stable] [PATCH 3/3] net/mlx5: fix interrupt enable return value
2017-09-04 15:24 ` Nélio Laranjeiro
@ 2017-09-05 9:04 ` Shachar Beiser
0 siblings, 0 replies; 14+ messages in thread
From: Shachar Beiser @ 2017-09-05 9:04 UTC (permalink / raw)
To: Nélio Laranjeiro; +Cc: dev, Adrien Mazarguil, stable
OK,
I will fix to " commit e1016cb733 ("net/mlx5: fix Rx interrupts management") "
> -----Original Message-----
> From: Nélio Laranjeiro [mailto:nelio.laranjeiro@6wind.com]
> Sent: Monday, September 4, 2017 6:24 PM
> To: Shachar Beiser <shacharbe@mellanox.com>
> Cc: dev@dpdk.org; Adrien Mazarguil <adrien.mazarguil@6wind.com>;
> stable@dpdk.org
> Subject: Re: [PATCH 3/3] net/mlx5: fix interrupt enable return value
>
> On Mon, Sep 04, 2017 at 11:48:47AM +0000, Shachar Beiser wrote:
> > Fixes: 3c7d44af252a ("net/mlx5: support user space Rx interrupt
> > event")
>
> It should fix commit e1016cb733 ("net/mlx5: fix Rx interrupts management")
>
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Shachar Beiser <shacharbe@mellanox.com>
> > ---
> > drivers/net/mlx5/mlx5_rxq.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c
> > index 437dc02..24887fb 100644
> > --- a/drivers/net/mlx5/mlx5_rxq.c
> > +++ b/drivers/net/mlx5/mlx5_rxq.c
> > @@ -1330,7 +1330,7 @@
> > struct priv *priv = mlx5_get_priv(dev);
> > struct rxq *rxq = (*priv->rxqs)[rx_queue_id];
> > struct rxq_ctrl *rxq_ctrl = container_of(rxq, struct rxq_ctrl, rxq);
> > - int ret;
> > + int ret = 0;
> >
> > if (!rxq || !rxq_ctrl->channel) {
> > ret = EINVAL;
> > --
> > 1.8.3.1
> >
>
> --
> Nélio Laranjeiro
> 6WIND
^ permalink raw reply [flat|nested] 14+ messages in thread
* [dpdk-stable] [PATCH v2 2/3] net/mlx5: fix TSO MLNX OFED 3.3 verification
[not found] ` <bf3a648369b1b8d2023819a1372c08c6cc5f0de8.1504525643.git.shacharbe@mellanox.com>
2017-09-04 11:48 ` [dpdk-stable] [PATCH 2/3] net/mlx5: fix TSO MLNX OFED 3.3 verification Shachar Beiser
2017-09-04 11:48 ` [dpdk-stable] [PATCH 3/3] net/mlx5: fix interrupt enable return value Shachar Beiser
@ 2017-09-05 13:04 ` Shachar Beiser
2017-09-05 13:41 ` Nélio Laranjeiro
2017-09-14 13:43 ` [dpdk-stable] [PATCH v3 2/2] " Shachar Beiser
2017-09-05 13:04 ` [dpdk-stable] [PATCH v2 3/3] net/mlx5: fix interrupt enable return value Shachar Beiser
3 siblings, 2 replies; 14+ messages in thread
From: Shachar Beiser @ 2017-09-05 13:04 UTC (permalink / raw)
To: dev; +Cc: Shachar Beiser, Adrien Mazarguil, Nelio Laranjeiro, stable
Fixes: 3cf87e68d97b ("net/mlx5: remove old MLNX OFED 3.3 verification")
Cc: stable@dpdk.org
Signed-off-by: Shachar Beiser <shacharbe@mellanox.com>
---
drivers/net/mlx5/mlx5_prm.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/net/mlx5/mlx5_prm.h b/drivers/net/mlx5/mlx5_prm.h
index 608072f..8b82b5e 100644
--- a/drivers/net/mlx5/mlx5_prm.h
+++ b/drivers/net/mlx5/mlx5_prm.h
@@ -89,9 +89,6 @@
/* Default max packet length to be inlined. */
#define MLX5_EMPW_MAX_INLINE_LEN (4U * MLX5_WQE_SIZE)
-#ifndef HAVE_VERBS_MLX5_OPCODE_TSO
-#define MLX5_OPCODE_TSO MLX5_OPCODE_LSO_MPW /* Compat with OFED 3.3. */
-#endif
#define MLX5_OPC_MOD_ENHANCED_MPSW 0
#define MLX5_OPCODE_ENHANCED_MPSW 0x29
--
1.8.3.1
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [dpdk-stable] [PATCH v2 2/3] net/mlx5: fix TSO MLNX OFED 3.3 verification
2017-09-05 13:04 ` [dpdk-stable] [PATCH v2 2/3] net/mlx5: fix TSO MLNX OFED 3.3 verification Shachar Beiser
@ 2017-09-05 13:41 ` Nélio Laranjeiro
2017-09-14 13:43 ` [dpdk-stable] [PATCH v3 2/2] " Shachar Beiser
1 sibling, 0 replies; 14+ messages in thread
From: Nélio Laranjeiro @ 2017-09-05 13:41 UTC (permalink / raw)
To: Shachar Beiser; +Cc: dev, Adrien Mazarguil, stable
On Tue, Sep 05, 2017 at 01:04:37PM +0000, Shachar Beiser wrote:
> Fixes: 3cf87e68d97b ("net/mlx5: remove old MLNX OFED 3.3 verification")
> Cc: stable@dpdk.org
>
> Signed-off-by: Shachar Beiser <shacharbe@mellanox.com>
> ---
> drivers/net/mlx5/mlx5_prm.h | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/net/mlx5/mlx5_prm.h b/drivers/net/mlx5/mlx5_prm.h
> index 608072f..8b82b5e 100644
> --- a/drivers/net/mlx5/mlx5_prm.h
> +++ b/drivers/net/mlx5/mlx5_prm.h
> @@ -89,9 +89,6 @@
> /* Default max packet length to be inlined. */
> #define MLX5_EMPW_MAX_INLINE_LEN (4U * MLX5_WQE_SIZE)
>
> -#ifndef HAVE_VERBS_MLX5_OPCODE_TSO
> -#define MLX5_OPCODE_TSO MLX5_OPCODE_LSO_MPW /* Compat with OFED 3.3. */
> -#endif
>
> #define MLX5_OPC_MOD_ENHANCED_MPSW 0
> #define MLX5_OPCODE_ENHANCED_MPSW 0x29
> --
> 1.8.3.1
>
Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
--
Nélio Laranjeiro
6WIND
^ permalink raw reply [flat|nested] 14+ messages in thread* [dpdk-stable] [PATCH v3 2/2] net/mlx5: fix TSO MLNX OFED 3.3 verification
2017-09-05 13:04 ` [dpdk-stable] [PATCH v2 2/3] net/mlx5: fix TSO MLNX OFED 3.3 verification Shachar Beiser
2017-09-05 13:41 ` Nélio Laranjeiro
@ 2017-09-14 13:43 ` Shachar Beiser
2017-09-17 10:42 ` [dpdk-stable] [PATCH v4 " Shachar Beiser
1 sibling, 1 reply; 14+ messages in thread
From: Shachar Beiser @ 2017-09-14 13:43 UTC (permalink / raw)
To: dev; +Cc: Shachar Beiser, Adrien Mazarguil, Nelio Laranjeiro, stable
Fixes: 3cf87e68d97b ("net/mlx5: remove old MLNX OFED 3.3 verification")
Cc: stable@dpdk.org
Signed-off-by: Shachar Beiser <shacharbe@mellanox.com>
---
There are only 2 patches left since
I have squashed :
[PATCH v2 3/3] “net/mlx5: fix interrupt enable return”
http://dpdk.org/dev/patchwork/patch/28380/
into [dpdk-dev,v5] net/mlx5: support upstream rdma-core
---
drivers/net/mlx5/mlx5_prm.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/net/mlx5/mlx5_prm.h b/drivers/net/mlx5/mlx5_prm.h
index 608072f..8b82b5e 100644
--- a/drivers/net/mlx5/mlx5_prm.h
+++ b/drivers/net/mlx5/mlx5_prm.h
@@ -89,9 +89,6 @@
/* Default max packet length to be inlined. */
#define MLX5_EMPW_MAX_INLINE_LEN (4U * MLX5_WQE_SIZE)
-#ifndef HAVE_VERBS_MLX5_OPCODE_TSO
-#define MLX5_OPCODE_TSO MLX5_OPCODE_LSO_MPW /* Compat with OFED 3.3. */
-#endif
#define MLX5_OPC_MOD_ENHANCED_MPSW 0
#define MLX5_OPCODE_ENHANCED_MPSW 0x29
--
1.8.3.1
^ permalink raw reply [flat|nested] 14+ messages in thread* [dpdk-stable] [PATCH v4 2/2] net/mlx5: fix TSO MLNX OFED 3.3 verification
2017-09-14 13:43 ` [dpdk-stable] [PATCH v3 2/2] " Shachar Beiser
@ 2017-09-17 10:42 ` Shachar Beiser
2017-09-18 17:52 ` [dpdk-stable] [dpdk-dev] " Yongseok Koh
0 siblings, 1 reply; 14+ messages in thread
From: Shachar Beiser @ 2017-09-17 10:42 UTC (permalink / raw)
To: dev; +Cc: Shachar Beiser, Adrien Mazarguil, Nelio Laranjeiro, stable
Fixes: 3cf87e68d97b ("net/mlx5: remove old MLNX OFED 3.3 verification")
Cc: stable@dpdk.org
Signed-off-by: Shachar Beiser <shacharbe@mellanox.com>
---
I have rebased last patch [PATCH v3 2/2] net/mlx5: fix TSO MLNX OFED 3.3 verification
---
drivers/net/mlx5/mlx5_prm.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/net/mlx5/mlx5_prm.h b/drivers/net/mlx5/mlx5_prm.h
index c61e4d8..e00be81 100644
--- a/drivers/net/mlx5/mlx5_prm.h
+++ b/drivers/net/mlx5/mlx5_prm.h
@@ -89,9 +89,6 @@
/* Default max packet length to be inlined. */
#define MLX5_EMPW_MAX_INLINE_LEN (4U * MLX5_WQE_SIZE)
-#ifndef HAVE_VERBS_MLX5_OPCODE_TSO
-#define MLX5_OPCODE_TSO MLX5_OPCODE_LSO_MPW /* Compat with OFED 3.3. */
-#endif
#define MLX5_OPC_MOD_ENHANCED_MPSW 0
#define MLX5_OPCODE_ENHANCED_MPSW 0x29
--
1.8.3.1
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [dpdk-stable] [dpdk-dev] [PATCH v4 2/2] net/mlx5: fix TSO MLNX OFED 3.3 verification
2017-09-17 10:42 ` [dpdk-stable] [PATCH v4 " Shachar Beiser
@ 2017-09-18 17:52 ` Yongseok Koh
2017-09-22 18:02 ` Ferruh Yigit
0 siblings, 1 reply; 14+ messages in thread
From: Yongseok Koh @ 2017-09-18 17:52 UTC (permalink / raw)
To: Shachar Beiser; +Cc: dev, Adrien Mazarguil, Nélio Laranjeiro, stable
> On Sep 17, 2017, at 3:42 AM, Shachar Beiser <shacharbe@mellanox.com> wrote:
>
> Fixes: 3cf87e68d97b ("net/mlx5: remove old MLNX OFED 3.3 verification")
> Cc: stable@dpdk.org
>
> Signed-off-by: Shachar Beiser <shacharbe@mellanox.com>
> ---
> I have rebased last patch [PATCH v3 2/2] net/mlx5: fix TSO MLNX OFED 3.3 verification
> ---
I think this patch had been acked by Nelio since v2. Then you can keep
'Acked-by' tag through updated versions unless there's any change in the patch.
Acked-by: Yongseok Koh <yskoh@mellanox.com>
Thanks
Yongseok
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [dpdk-stable] [dpdk-dev] [PATCH v4 2/2] net/mlx5: fix TSO MLNX OFED 3.3 verification
2017-09-18 17:52 ` [dpdk-stable] [dpdk-dev] " Yongseok Koh
@ 2017-09-22 18:02 ` Ferruh Yigit
0 siblings, 0 replies; 14+ messages in thread
From: Ferruh Yigit @ 2017-09-22 18:02 UTC (permalink / raw)
To: Yongseok Koh, Shachar Beiser
Cc: dev, Adrien Mazarguil, Nélio Laranjeiro, stable
On 9/18/2017 6:52 PM, Yongseok Koh wrote:
>
>> On Sep 17, 2017, at 3:42 AM, Shachar Beiser <shacharbe@mellanox.com> wrote:
>>
>> Fixes: 3cf87e68d97b ("net/mlx5: remove old MLNX OFED 3.3 verification")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Shachar Beiser <shacharbe@mellanox.com>
>> ---
>> I have rebased last patch [PATCH v3 2/2] net/mlx5: fix TSO MLNX OFED 3.3 verification
>> ---
> I think this patch had been acked by Nelio since v2. Then you can keep
> 'Acked-by' tag through updated versions unless there's any change in the patch.
>
> Acked-by: Yongseok Koh <yskoh@mellanox.com>
This commit is fixing one that is within this release, so this commit
squashed into relevant one.
>
> Thanks
> Yongseok
>
^ permalink raw reply [flat|nested] 14+ messages in thread
* [dpdk-stable] [PATCH v2 3/3] net/mlx5: fix interrupt enable return value
[not found] ` <bf3a648369b1b8d2023819a1372c08c6cc5f0de8.1504525643.git.shacharbe@mellanox.com>
` (2 preceding siblings ...)
2017-09-05 13:04 ` [dpdk-stable] [PATCH v2 2/3] net/mlx5: fix TSO MLNX OFED 3.3 verification Shachar Beiser
@ 2017-09-05 13:04 ` Shachar Beiser
2017-09-05 13:27 ` Adrien Mazarguil
3 siblings, 1 reply; 14+ messages in thread
From: Shachar Beiser @ 2017-09-05 13:04 UTC (permalink / raw)
To: dev; +Cc: Shachar Beiser, Adrien Mazarguil, Nelio Laranjeiro, stable
return value is sometimes returned uninitialized
Fixes: e1016cb73383 ("net/mlx5: fix Rx interrupts management")
Fixes: b18042fb8f49 ("net/mlx5: fix misplaced Rx interrupts functions")
Cc: adrien.mazarguil@6wind.com
Cc: stable@dpdk.org
Signed-off-by: Shachar Beiser <shacharbe@mellanox.com>
---
drivers/net/mlx5/mlx5_rxq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c
index 437dc02..24887fb 100644
--- a/drivers/net/mlx5/mlx5_rxq.c
+++ b/drivers/net/mlx5/mlx5_rxq.c
@@ -1330,7 +1330,7 @@
struct priv *priv = mlx5_get_priv(dev);
struct rxq *rxq = (*priv->rxqs)[rx_queue_id];
struct rxq_ctrl *rxq_ctrl = container_of(rxq, struct rxq_ctrl, rxq);
- int ret;
+ int ret = 0;
if (!rxq || !rxq_ctrl->channel) {
ret = EINVAL;
--
1.8.3.1
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [dpdk-stable] [PATCH v2 3/3] net/mlx5: fix interrupt enable return value
2017-09-05 13:04 ` [dpdk-stable] [PATCH v2 3/3] net/mlx5: fix interrupt enable return value Shachar Beiser
@ 2017-09-05 13:27 ` Adrien Mazarguil
2017-09-06 10:54 ` Shachar Beiser
0 siblings, 1 reply; 14+ messages in thread
From: Adrien Mazarguil @ 2017-09-05 13:27 UTC (permalink / raw)
To: Shachar Beiser; +Cc: dev, Nelio Laranjeiro, stable
Hi Shachar,
On Tue, Sep 05, 2017 at 01:04:38PM +0000, Shachar Beiser wrote:
> return value is sometimes returned uninitialized
>
> Fixes: e1016cb73383 ("net/mlx5: fix Rx interrupts management")
> Fixes: b18042fb8f49 ("net/mlx5: fix misplaced Rx interrupts functions")
>
> Cc: adrien.mazarguil@6wind.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Shachar Beiser <shacharbe@mellanox.com>
Looks like in both commits, ret is properly initialized so I'm wondering if
the fixes line is right? Did you even get a compilation error?
Otherwise, you should drop this patch from the series.
> ---
> drivers/net/mlx5/mlx5_rxq.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c
> index 437dc02..24887fb 100644
> --- a/drivers/net/mlx5/mlx5_rxq.c
> +++ b/drivers/net/mlx5/mlx5_rxq.c
> @@ -1330,7 +1330,7 @@
> struct priv *priv = mlx5_get_priv(dev);
> struct rxq *rxq = (*priv->rxqs)[rx_queue_id];
> struct rxq_ctrl *rxq_ctrl = container_of(rxq, struct rxq_ctrl, rxq);
> - int ret;
> + int ret = 0;
>
> if (!rxq || !rxq_ctrl->channel) {
> ret = EINVAL;
> --
> 1.8.3.1
>
--
Adrien Mazarguil
6WIND
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [dpdk-stable] [PATCH v2 3/3] net/mlx5: fix interrupt enable return value
2017-09-05 13:27 ` Adrien Mazarguil
@ 2017-09-06 10:54 ` Shachar Beiser
0 siblings, 0 replies; 14+ messages in thread
From: Shachar Beiser @ 2017-09-06 10:54 UTC (permalink / raw)
To: Adrien Mazarguil; +Cc: dev, Nélio Laranjeiro, stable
Hi ,
The problem was that the value ret was not set to 0.
As a result we got a warning message:
WARN("unable to arm interrupt on rx queue %d", rx_queue_id);
The fix is ret =0;
I was looking with Nelio for the right commits that this bug fixes I am
pretty sure that this ret value was not initialized.
-Shachar Beiser.
> -----Original Message-----
> From: Adrien Mazarguil [mailto:adrien.mazarguil@6wind.com]
> Sent: Tuesday, September 5, 2017 4:27 PM
> To: Shachar Beiser <shacharbe@mellanox.com>
> Cc: dev@dpdk.org; Nélio Laranjeiro <nelio.laranjeiro@6wind.com>;
> stable@dpdk.org
> Subject: Re: [PATCH v2 3/3] net/mlx5: fix interrupt enable return value
>
> Hi Shachar,
>
> On Tue, Sep 05, 2017 at 01:04:38PM +0000, Shachar Beiser wrote:
> > return value is sometimes returned uninitialized
> >
> > Fixes: e1016cb73383 ("net/mlx5: fix Rx interrupts management")
> > Fixes: b18042fb8f49 ("net/mlx5: fix misplaced Rx interrupts
> > functions")
> >
> > Cc: adrien.mazarguil@6wind.com
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Shachar Beiser <shacharbe@mellanox.com>
>
> Looks like in both commits, ret is properly initialized so I'm wondering if the
> fixes line is right? Did you even get a compilation error?
>
> Otherwise, you should drop this patch from the series.
>
> > ---
> > drivers/net/mlx5/mlx5_rxq.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c
> > index 437dc02..24887fb 100644
> > --- a/drivers/net/mlx5/mlx5_rxq.c
> > +++ b/drivers/net/mlx5/mlx5_rxq.c
> > @@ -1330,7 +1330,7 @@
> > struct priv *priv = mlx5_get_priv(dev);
> > struct rxq *rxq = (*priv->rxqs)[rx_queue_id];
> > struct rxq_ctrl *rxq_ctrl = container_of(rxq, struct rxq_ctrl, rxq);
> > - int ret;
> > + int ret = 0;
> >
> > if (!rxq || !rxq_ctrl->channel) {
> > ret = EINVAL;
> > --
> > 1.8.3.1
> >
>
> --
> Adrien Mazarguil
> 6WIND
^ permalink raw reply [flat|nested] 14+ messages in thread