From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bruce.richardson@intel.com>
Received: from mga06.intel.com (mga06.intel.com [134.134.136.31])
 by dpdk.org (Postfix) with ESMTP id 86E3E7CCD;
 Fri, 22 Sep 2017 15:46:41 +0200 (CEST)
Received: from orsmga005.jf.intel.com ([10.7.209.41])
 by orsmga104.jf.intel.com with ESMTP; 22 Sep 2017 06:46:40 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.42,427,1500966000"; d="scan'208";a="152223494"
Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.221.24])
 by orsmga005.jf.intel.com with SMTP; 22 Sep 2017 06:46:38 -0700
Received: by  (sSMTP sendmail emulation); Fri, 22 Sep 2017 14:46:37 +0100
Date: Fri, 22 Sep 2017 14:46:37 +0100
From: Bruce Richardson <bruce.richardson@intel.com>
To: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Cc: dev@dpdk.org, stable@dpdk.org
Message-ID: <20170922134637.GA21280@bricha3-MOBL3.ger.corp.intel.com>
References: <20170921124646.68253-1-pablo.de.lara.guarch@intel.com>
 <20170922042543.38362-1-pablo.de.lara.guarch@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170922042543.38362-1-pablo.de.lara.guarch@intel.com>
Organization: Intel Research and Development Ireland Ltd.
User-Agent: Mutt/1.8.3 (2017-05-23)
Subject: Re: [dpdk-stable] [PATCH v2] hash: fix incorrect eviction counter
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/stable>,
 <mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/stable>,
 <mailto:stable-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 22 Sep 2017 13:46:42 -0000

On Fri, Sep 22, 2017 at 05:25:43AM +0100, Pablo de Lara wrote:
> When adding a new entry in a hash table, there is
> a maximum number of evictions that can be
> performed. When the counter of these evictions reaches
> this maximum, the entry cannot be added, as it is considered
> that the algorithm has encountered an infinite loop.
> 
> The problem with the current implementation, is that this
> counter was declared as a static variable.
> If there are multiple threads adding entries in the same table
> or in different tables, they should access different counters,
> one per core and per table.
> 
> Therefore, the variable has been modified to be non-static.
> 
> Fixes: 243e93a5046f ("hash: fix unlimited cuckoo path")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> ---
Acked-by: Bruce Richardson <bruce.richardson@intel.com>