* [dpdk-stable] [PATCH v2 3/3] app/crypto-perf: fix packet length check [not found] ` <20170915020937.75688-1-pablo.de.lara.guarch@intel.com> @ 2017-09-15 2:09 ` Pablo de Lara 2017-09-18 11:32 ` [dpdk-stable] [dpdk-dev] " Radu Nicolau [not found] ` <20170920013704.85333-1-pablo.de.lara.guarch@intel.com> 1 sibling, 1 reply; 4+ messages in thread From: Pablo de Lara @ 2017-09-15 2:09 UTC (permalink / raw) To: declan.doherty; +Cc: dev, Pablo de Lara, stable When using DES-CBC, packet size has to be multiple of 8 bytes, but if a list of packets is provided. the check was not correct. Fixes: fc4600fb2520 ("app/crypto-perf: add extra option checks") Cc: stable@dpdk.org Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com> --- app/test-crypto-perf/cperf_options_parsing.c | 18 +++++++++++++++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git a/app/test-crypto-perf/cperf_options_parsing.c b/app/test-crypto-perf/cperf_options_parsing.c index 663f53f..3f933bc 100644 --- a/app/test-crypto-perf/cperf_options_parsing.c +++ b/app/test-crypto-perf/cperf_options_parsing.c @@ -832,14 +832,26 @@ check_cipher_buffer_length(struct cperf_options *options) if (options->cipher_algo == RTE_CRYPTO_CIPHER_DES_CBC || options->cipher_algo == RTE_CRYPTO_CIPHER_3DES_CBC || options->cipher_algo == RTE_CRYPTO_CIPHER_3DES_ECB) { - for (buffer_size = options->min_buffer_size; - buffer_size < options->max_buffer_size; - buffer_size += options->inc_buffer_size) { + if (options->inc_buffer_size != 0) + buffer_size = options->min_buffer_size; + else + buffer_size = options->buffer_size_list[0]; + + while (buffer_size <= options->max_buffer_size) { if ((buffer_size % DES_BLOCK_SIZE) != 0) { RTE_LOG(ERR, USER1, "Some of the buffer sizes are " "not suitable for the algorithm selected\n"); return -EINVAL; } + + if (options->inc_buffer_size != 0) + buffer_size += options->inc_buffer_size; + else { + if (++buffer_size_idx == options->buffer_size_count) + break; + buffer_size = options->buffer_size_list[buffer_size_idx]; + } + } } -- 2.9.4 ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-stable] [dpdk-dev] [PATCH v2 3/3] app/crypto-perf: fix packet length check 2017-09-15 2:09 ` [dpdk-stable] [PATCH v2 3/3] app/crypto-perf: fix packet length check Pablo de Lara @ 2017-09-18 11:32 ` Radu Nicolau 0 siblings, 0 replies; 4+ messages in thread From: Radu Nicolau @ 2017-09-18 11:32 UTC (permalink / raw) To: Pablo de Lara, declan.doherty; +Cc: dev, stable On 9/15/2017 3:09 AM, Pablo de Lara wrote: > When using DES-CBC, packet size has to be multiple > of 8 bytes, but if a list of packets is provided. > the check was not correct. > > Fixes: fc4600fb2520 ("app/crypto-perf: add extra option checks") > Cc: stable@dpdk.org > > Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com> > --- > Acked-by: Radu Nicolau <radu.nicolau@intel.com> ^ permalink raw reply [flat|nested] 4+ messages in thread
[parent not found: <20170920013704.85333-1-pablo.de.lara.guarch@intel.com>]
* [dpdk-stable] [PATCH v3 3/3] app/crypto-perf: fix packet length check [not found] ` <20170920013704.85333-1-pablo.de.lara.guarch@intel.com> @ 2017-09-20 1:37 ` Pablo de Lara [not found] ` <20171005052800.12922-1-pablo.de.lara.guarch@intel.com> 1 sibling, 0 replies; 4+ messages in thread From: Pablo de Lara @ 2017-09-20 1:37 UTC (permalink / raw) To: declan.doherty; +Cc: dev, Pablo de Lara, stable When using DES-CBC, packet size has to be multiple of 8 bytes, but if a list of packets is provided. the check was not correct. Fixes: fc4600fb2520 ("app/crypto-perf: add extra option checks") Cc: stable@dpdk.org Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com> Acked-by: Radu Nicolau <radu.nicolau@intel.com> --- app/test-crypto-perf/cperf_options_parsing.c | 18 +++++++++++++++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git a/app/test-crypto-perf/cperf_options_parsing.c b/app/test-crypto-perf/cperf_options_parsing.c index 663f53f..3f933bc 100644 --- a/app/test-crypto-perf/cperf_options_parsing.c +++ b/app/test-crypto-perf/cperf_options_parsing.c @@ -832,14 +832,26 @@ check_cipher_buffer_length(struct cperf_options *options) if (options->cipher_algo == RTE_CRYPTO_CIPHER_DES_CBC || options->cipher_algo == RTE_CRYPTO_CIPHER_3DES_CBC || options->cipher_algo == RTE_CRYPTO_CIPHER_3DES_ECB) { - for (buffer_size = options->min_buffer_size; - buffer_size < options->max_buffer_size; - buffer_size += options->inc_buffer_size) { + if (options->inc_buffer_size != 0) + buffer_size = options->min_buffer_size; + else + buffer_size = options->buffer_size_list[0]; + + while (buffer_size <= options->max_buffer_size) { if ((buffer_size % DES_BLOCK_SIZE) != 0) { RTE_LOG(ERR, USER1, "Some of the buffer sizes are " "not suitable for the algorithm selected\n"); return -EINVAL; } + + if (options->inc_buffer_size != 0) + buffer_size += options->inc_buffer_size; + else { + if (++buffer_size_idx == options->buffer_size_count) + break; + buffer_size = options->buffer_size_list[buffer_size_idx]; + } + } } -- 2.9.4 ^ permalink raw reply [flat|nested] 4+ messages in thread
[parent not found: <20171005052800.12922-1-pablo.de.lara.guarch@intel.com>]
* [dpdk-stable] [PATCH v4 4/4] app/crypto-perf: fix packet length check [not found] ` <20171005052800.12922-1-pablo.de.lara.guarch@intel.com> @ 2017-10-05 5:28 ` Pablo de Lara 0 siblings, 0 replies; 4+ messages in thread From: Pablo de Lara @ 2017-10-05 5:28 UTC (permalink / raw) To: declan.doherty, john.mcnamara; +Cc: dev, Pablo de Lara, stable When using DES-CBC, packet size has to be multiple of 8 bytes, but if a list of packets is provided. the check was not correct. Fixes: fc4600fb2520 ("app/crypto-perf: add extra option checks") Cc: stable@dpdk.org Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com> Acked-by: Radu Nicolau <radu.nicolau@intel.com> --- app/test-crypto-perf/cperf_options_parsing.c | 18 +++++++++++++++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git a/app/test-crypto-perf/cperf_options_parsing.c b/app/test-crypto-perf/cperf_options_parsing.c index f3508a4..af81162 100644 --- a/app/test-crypto-perf/cperf_options_parsing.c +++ b/app/test-crypto-perf/cperf_options_parsing.c @@ -876,14 +876,26 @@ check_cipher_buffer_length(struct cperf_options *options) if (options->cipher_algo == RTE_CRYPTO_CIPHER_DES_CBC || options->cipher_algo == RTE_CRYPTO_CIPHER_3DES_CBC || options->cipher_algo == RTE_CRYPTO_CIPHER_3DES_ECB) { - for (buffer_size = options->min_buffer_size; - buffer_size < options->max_buffer_size; - buffer_size += options->inc_buffer_size) { + if (options->inc_buffer_size != 0) + buffer_size = options->min_buffer_size; + else + buffer_size = options->buffer_size_list[0]; + + while (buffer_size <= options->max_buffer_size) { if ((buffer_size % DES_BLOCK_SIZE) != 0) { RTE_LOG(ERR, USER1, "Some of the buffer sizes are " "not suitable for the algorithm selected\n"); return -EINVAL; } + + if (options->inc_buffer_size != 0) + buffer_size += options->inc_buffer_size; + else { + if (++buffer_size_idx == options->buffer_size_count) + break; + buffer_size = options->buffer_size_list[buffer_size_idx]; + } + } } -- 2.9.4 ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-10-05 13:27 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20170818061753.55840-1-pablo.de.lara.guarch@intel.com>
[not found] ` <20170915020937.75688-1-pablo.de.lara.guarch@intel.com>
2017-09-15 2:09 ` [dpdk-stable] [PATCH v2 3/3] app/crypto-perf: fix packet length check Pablo de Lara
2017-09-18 11:32 ` [dpdk-stable] [dpdk-dev] " Radu Nicolau
[not found] ` <20170920013704.85333-1-pablo.de.lara.guarch@intel.com>
2017-09-20 1:37 ` [dpdk-stable] [PATCH v3 " Pablo de Lara
[not found] ` <20171005052800.12922-1-pablo.de.lara.guarch@intel.com>
2017-10-05 5:28 ` [dpdk-stable] [PATCH v4 4/4] " Pablo de Lara
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).