From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bruce.richardson@intel.com>
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 by dpdk.org (Postfix) with ESMTP id 23C721B269;
 Tue, 10 Oct 2017 10:48:12 +0200 (CEST)
Received: from orsmga001.jf.intel.com ([10.7.209.18])
 by orsmga105.jf.intel.com with ESMTP; 10 Oct 2017 01:48:11 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.42,504,1500966000"; d="scan'208";a="1180472463"
Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.221.37])
 by orsmga001.jf.intel.com with SMTP; 10 Oct 2017 01:48:09 -0700
Received: by  (sSMTP sendmail emulation); Tue, 10 Oct 2017 09:48:08 +0100
Date: Tue, 10 Oct 2017 09:48:08 +0100
From: Bruce Richardson <bruce.richardson@intel.com>
To: Qi Zhang <qi.z.zhang@intel.com>, Roger B Melton <rmelton@cisco.com>
Cc: konstantin.ananyev@intel.com, jingjing.wu@intel.com,
 beilei.xing@intel.com, dev@dpdk.org, stable@dpdk.org
Message-ID: <20171010084807.GA34984@bricha3-MOBL3.ger.corp.intel.com>
References: <20171010132205.72173-1-qi.z.zhang@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20171010132205.72173-1-qi.z.zhang@intel.com>
Organization: Intel Research and Development Ireland Ltd.
User-Agent: Mutt/1.8.3 (2017-05-23)
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] net/i40e: fix unexpected mbuf
	free in vPMD
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/stable>,
 <mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/stable>,
 <mailto:stable-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 10 Oct 2017 08:48:13 -0000

+Roger Melton

On Tue, Oct 10, 2017 at 09:22:05AM -0400, Qi Zhang wrote:
> vPMD tx does not set sw_ring's mbuf to NULL after free it.
> So to prevent same mbuf be free again, we need more carefully
> check in i40e_tx_queue_release_mbufs.
> 
> Fixes: b4669bb95038 ("i40e: add vector Tx")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
> ---
> v2:
> - fix at i40e_tx_queue_release_mbufs so no performance impact.
> 
This patch also supercedes this one, http://dpdk.org/dev/patchwork/patch/29814/
right?
Roger, can you please confirm that this alternative fix works in your
testing and that your patch is no longer necessary too.

Thanks,
/Bruce