From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <Shijith.Thotton@cavium.com>
Received: from NAM03-DM3-obe.outbound.protection.outlook.com
(mail-dm3nam03on0054.outbound.protection.outlook.com [104.47.41.54])
by dpdk.org (Postfix) with ESMTP id B92521B623;
Wed, 18 Oct 2017 08:28:08 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version;
bh=ucGhyh3ZN/mmmRo1gXhQL6QytwwtllLT7XPYqrFGM+E=;
b=VUGdxsgSrCz4YBi6xLVErfLHzJ08VurJlG4pwbcRJ79qeZaCj6kZYamysNK/cnHm5IQ3l7gWhPI+nu+nMGsj/AQAdZk59tHaJZEsTlungQu65f0TobAml34aPD4tf5x0dXwf/Yxojhi1p2aApL0yJ1heij/s+p0eWINji26qKXw=
Authentication-Results: spf=none (sender IP is )
smtp.mailfrom=Shijith.Thotton@cavium.com;
Received: from localhost.localdomain (14.140.2.178) by
DM5PR07MB3068.namprd07.prod.outlook.com (10.172.88.142) with Microsoft SMTP
Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id
15.20.77.7; Wed, 18 Oct 2017 06:28:03 +0000
Date: Wed, 18 Oct 2017 11:57:44 +0530
From: Shijith Thotton <shijith.thotton@caviumnetworks.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: Thomas Monjalon <thomas@monjalon.net>, dev@dpdk.org,
Jianfeng Tan <jianfeng.tan@intel.com>, Jingjing Wu <jingjing.wu@intel.com>,
Gregory Etelson <gregory@weka.io>, Harish Patil <harish.patil@cavium.com>,
George Prekas <george.prekas@epfl.ch>, stable@dpdk.org
Message-ID: <20171018062743.GA26930@localhost.localdomain>
References: <20171017201436.65270-1-ferruh.yigit@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20171017201436.65270-1-ferruh.yigit@intel.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-Originating-IP: [14.140.2.178]
X-ClientProxiedBy: BMXPR01CA0041.INDPRD01.PROD.OUTLOOK.COM (10.174.214.27) To
DM5PR07MB3068.namprd07.prod.outlook.com (10.172.88.142)
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: b8532dfc-0d67-4c9e-b802-08d515f164ac
X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0;
RULEID:(22001)(2017030254152)(2017052603199)(201703131423075)(201703031133081)(201702281549075);
SRVR:DM5PR07MB3068;
X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB3068;
3:ny2VOUtKl9cco5dipTkyt+vAi9kGOT4eeCbw2GpytQCQ1nVAPA2KUJ/y9yaRXDJ8BfVS1nWaV0UFRaiEBBnsjiq+vdq+IoJ7fVQ0L3NTCwKXL30HdfWkK84a94NnL2LlUwVqAybYdfoEKLR7NwDFXCkdZ+LaOOx4iIUSLQMhiuaxD5xIl4+2ZGX1UiQyjyuW8VCuKM4Fxnw1FDRlXPifWkxhje6av8UZwZ3ndw2rntqa8gr+heKQrPOZnw+OGjyo;
25:IgFIZjVm7885Ka1zb4VrRnpfFTePeo3tN45vJVqTZnLVbU8J9fkehkiwC/orKSkJGoMmDgN/BDhX3dFWUG4UtIRC0lDwBstGrMbHhTYj3BXOyB/R4SGKiJYyQn68CYrryFReyhrsMtOpewePI8lyU4NdIglcwZImChjVhJogJ1m0JyTMpYBj/TalCDO6ASo7PphW+v4WVwQ5GWw8ZPHLhNuHVQtSZe5/Qg7xf7N71xzYGrcorq0V6oPS4KFjTMu4kAjcA6mezJiDA0Z6aviW08RpufubbeORpdsQhIJeBEcHlzSOIpXlPbHaiKPGG1vjzGg5WFPWoDOJrSF0X/D0Bg==;
31:P2uhrM4SabQMtLXPlqlkDG2PcuWcWXTUNUeK44YnjVEA0OTUCPJ4XhjStemX2+0xoBKjxg8KXvMxACuImOJkPS0gjyW3INiDlagndM6PQ9/8OhnjH/pR6Te3RzafT1kzCOOLsKISqTtgFMjxi0HhUdGQhQqJ2MMRVuc21TAhd9U7W0VQJa82asgxhr3dAC9de0Fwu1DFqjKdO++waT5ZNde+ikWO1tfWZ5ewMwclKoM=
X-MS-TrafficTypeDiagnostic: DM5PR07MB3068:
X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB3068;
20:noAwwfp4RsH/Rnpxre6TtvYNEdUf1zIjpEdI/67IQE4Z1UviCZaQppCFbOu7WBgpVdzg54VDznRbRHXurMsThRiMPIZsxUmuLh3eyCJNGe62hCuUJSuFTYaQdZm3/d6HzChE9KaTr53aP9zl4df3GJvIAzd/Pw984S58cnvbqUzoiiVizf5QMgPSFmVfMkF1I9UtShlB3r5FABNNwNNXVSSJFSXeyFdovhP5/XUGNwu1w2YBM7K63lsqxQCOR55tR7IW/8ZSCfbpmxYpniS8f9v7F45F7+Uvi3LE5Eio9X2hBRE16Gje42LDHwbYAbDsus8qvf8VDrtedUP3ylGno3sZCgnTsDlMOTviRYxRUL6Np07Vs2WGbYP97misbx12GJ/qdgRq8KTQjLIoZ0fwzpU7Hc0LZQvQLUqluqulT80CI8wLherZe0zSRNpHAxF+QlmLXj55Zg9fC2+QTIEqTxgdAOAoRygyWKTPvs8mq96Qm+itG2WnmUXlPDkh/Mrivnfj+UXDsC2hn9ghIxQ9CZM2aGQKnvIxOcmBrte1RP2hEKLZ6kyaiya/MbIheLT7kg/f8ENwB+PT4lghUmAbQGkrRuM3sWNL9dBthqsGPKg=
X-Exchange-Antispam-Report-Test: UriScan:(20558992708506)(228905959029699)(17755550239193);
X-Microsoft-Antispam-PRVS: <DM5PR07MB30688520DE2D9E23D3D125C1814D0@DM5PR07MB3068.namprd07.prod.outlook.com>
X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0;
RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(93006095)(100000703101)(100105400095)(10201501046)(3002001)(6041248)(20161123555025)(20161123564025)(20161123558100)(20161123562025)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);
SRVR:DM5PR07MB3068; BCL:0; PCL:0;
RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);
SRVR:DM5PR07MB3068;
X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB3068;
4:i8AssrQvMj1FyCwbgff/xYACE6pyT3JYzaIWJTekPtaLCcbxAjQoOScUzFyKjPkGtykbcvw2vz+8mlcIj7ynonKVnZNVoJuFHL9zlSrRoA7OnJgnjSsotXiBrwba7hH0HY23jwy4dlC++Cdg0XnKXYyPuhbXlo6SQQi2yeRuTFtjVurfQN5yVvrhMNv2vB8MCfDgXodRt+x1p8A8WlE2HS0lL4Cj0sOBsziKDbuzSKXsw+IJOGOsd6CDchg054iNw85fJ2jFVZ1g7ANlQy241DBqOwo+UrWtM77yjoYD4y21VJGm0a5gSC3xoNcbvH2NswDyPADkFRcjR1gukZYO7I13kaqEYqI+CGVKfQNghGfNxo/+ZqsjpwCDi9WGArnw
X-Forefront-PRVS: 0464DBBBC4
X-Forefront-Antispam-Report: SFV:NSPM;
SFS:(10009020)(6009001)(6069001)(376002)(346002)(199003)(24454002)(189002)(23726003)(50466002)(6506006)(316002)(305945005)(16526018)(189998001)(68736007)(55016002)(9686003)(5660300001)(54906003)(6246003)(5009440100003)(58126008)(561944003)(61506002)(42882006)(16586007)(53376002)(6666003)(229853002)(6306002)(575784001)(6916009)(2950100002)(4326008)(53936002)(83506001)(81166006)(54356999)(478600001)(72206003)(966005)(66066001)(76176999)(81156014)(8676002)(7736002)(105586002)(97736004)(47776003)(6116002)(8936002)(2906002)(106356001)(25786009)(1076002)(3846002)(50986999)(33656002)(101416001)(110426004)(18370500001);
DIR:OUT; SFP:1101; SCL:1; SRVR:DM5PR07MB3068; H:localhost.localdomain; FPR:;
SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en;
Received-SPF: None (protection.outlook.com: cavium.com does not designate
permitted sender hosts)
X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DM5PR07MB3068;
23:DhtWDL6RXHPFr50O++azh8R6yA9YvR2G1uhN9Nx33?=
=?us-ascii?Q?khtG7epSDTX1LVyozY7GSpdnmGHOX0kDkkEin85KTstqPbpZgOQDXY+xSs8Q?=
=?us-ascii?Q?VUgWq1YgrbTLO5JietEha2RPkusailGrYPL8ASsbl6na+RhrSIIsf8K5Ddav?=
=?us-ascii?Q?+jCC4dIzl0CSZqRr74ZqrFe3i5rV4gZ5n7A9AT9slWE6w4pZaUC6KrkAJuFF?=
=?us-ascii?Q?DJdGMibc9JV68Q3c2NeKkx+vk8bGORJ1myaIDUrvHLus96PjJkXSiy7qQETD?=
=?us-ascii?Q?KhG1cIIxJAyDD1xwXdbe2NpOSPSgVf3eTsGaskZXGSMvrU7kSyfFuR4z8MTG?=
=?us-ascii?Q?4V22f/LID//YzTVKRiQf4Xpf3GvRODGIWOe+jOz9HTkkz+LCh5YNMBp3EHgo?=
=?us-ascii?Q?H/mmVMtgVdDouwzdPKpYRalQMM3MVV4YqvF8qzdbzilErHdJdtnuRvHSGMmK?=
=?us-ascii?Q?1k9LQ1MW/Rf+dGG6g6El0leZTiXz7SoFvDX4S0qqnHYiyhkDndkkjIMgBtVv?=
=?us-ascii?Q?r9dCBPap/Dh7cu35JJt3iElOTOkk9ukrWvwy0rHy38KC0RU6qIkFiloNjPMK?=
=?us-ascii?Q?zwQiXgOyH4WL3gkf/wPeYJlvjjTYGXU9GW/c66FPu8n7qB9o2+VGCjo9p9jN?=
=?us-ascii?Q?3YYxx7gix8sS8I0RNnIPf+yjU0zRvreMqzh1aY6x4wkWuCRBDVlfvs8r8mC2?=
=?us-ascii?Q?8YWHs45oVyLEBvqCelxDPbLLi3XW1vsmQJIJntxxxr5MBIZLU8O3WXc++QTu?=
=?us-ascii?Q?sZix9xULt5BxkWnoaUWyGYQMJ8oTs9FW1suw9Wgvg7PXDQx97Oqig4ypLKWy?=
=?us-ascii?Q?KWtK1vbXHw8HP+rp/EfuiVJwFmlUB0Xyc6ZEQeGsicnh70IvJfrCX4/LIAZL?=
=?us-ascii?Q?tuckgLEkdQkLaRCu4MiV/ovWI7VBJVh+0OAuxMR3G29LkifYaBpS/ZVniewp?=
=?us-ascii?Q?edbsvzkyWGPo73SYqddIXAvapNQvZibFEw0/iIMTH1fkvw3sl0e6EB8gwShq?=
=?us-ascii?Q?XQ4szsDpThRbnnR0EYkQnqsaArPXWlkWVYzQg0/H0JMpu7e+8e0kMrQonDHp?=
=?us-ascii?Q?JudxJLJ6JzgCdSdZiqDk7jNyPnPjPlG1ySKFpEwEe0xR2KL4rkG7lgE10hyU?=
=?us-ascii?Q?ZyQqAfjSirQGtQmDBCbMop9N4tv5lmSum/Zx9z/oSrCxFl83GYu2u6Kaeq32?=
=?us-ascii?Q?V1CSoBu86hqYihZIIwj5snCu4gHofwjCuOadZu5byZstkEB1F2VB/dl8wLmo?=
=?us-ascii?Q?Ua3Wfpl3lT9p3CMxdECGGfDsH5AVB5qRp1afrUou4VFSnpr4kk0iVne0ZlMC?=
=?us-ascii?Q?44UadgWXLPSM2y2Q6lV4aTkYI+XNvhTfSX6VK/NG95v5I6hjiOqDrRAdkhxy?=
=?us-ascii?Q?+MI1kvrARQKdKnEDmjMkj7sYZwpXtoHXuqTp7uavSs5Hf9z?=
X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB3068;
6:PAGe22lB6mL+CLJQWgN75nz3yNxS4AinU09SXEAnc4JDqN5WkchK46AtuAl6ajS7zfzRFoPwl8EHaMpbS4ZlrTo+0HvKIxwH4erlqLc88C67gW6Fc8JZ315BONmiVXWxZC/fIZeTGFz8pavy0VqWNkh79P46O+52RjrV3ai4o1A6s5t9thOmgr3xlw82aUbnBwohkwHSD67yHlgHmZ745LF26MXNA0lyzeytK6ADDn/4OUYKOB0DfHepItVMV+U42vseBG/WWchjaSzkVDBuAzQORM3NtfXM4dTYR8vCb6qXWatNzcMFyjQ6KXrkgUk91uil9iBsWWEdEcD0EYvTHg==;
5:qnATk6GkjK2DwN7fWEaWft5H9frJ95goy0qFlHrHrgwc0b/0GYw20LEg0SyZJNEypyNFEjyAEbd9ueHhTqE8jYhByS37yLW/xJGlE4CGSupOcVes40hT8CKf1uZ9ViurfPhepmKXVotC/SrY/SZZ7w==;
24:A/UmIzxfDouKwtNEDc9iLWXzje+qDkF516FJOOP+NJOm4HXZcJ7p1TT+fJdigJ8bHclOBTw3dleTa1OUXovVIQ2kLUsK/LZI4Bli85G/PXo=;
7:3rx0LIIKgwfGrxz14wwdnRSAt4xkWgZXVX19KliSnjVZPdxI9IfYFa5ygLRPFNwZjCvpLejcxNglGDc+5kgCVtZmR8FB+8SxeNV0nksfh/8kG0ExSl40q4/T07ipDW+QBAiRqc52K0e2xuzYwnkEGPqlhbm/qLHws5+wL0un0XR5G/jNXDdVNlK7jYrMubZ43GJIMjRinD72TgnbVGVVDodKs/4pKwcelA2LTiYqreQ=
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-OriginatorOrg: caviumnetworks.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2017 06:28:03.2979 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR07MB3068
Subject: Re: [dpdk-stable] [PATCH] igb_uio: revert open and release
operations
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/stable>,
<mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/stable>,
<mailto:stable-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 18 Oct 2017 06:28:09 -0000
On Tue, Oct 17, 2017 at 09:14:36PM +0100, Ferruh Yigit wrote:
> This reverts commit 6b9ed026a8704b9e5ee5da7997617ef7cc82e114.
> This reverts commit 5f6ff30dc5075c49069d684bab229aef7ff0fdc3.
> This reverts commit b58eedfc7dd57eef6d12e2c654a52c834f36084a.
>
> There were bug reports about terminated application may leave device in
> undesired state:
> http://dpdk.org/ml/archives/dev/2016-November/049745.html
> http://dpdk.org/ml/archives/dev/2016-November/050932.html
>
> And a proposal to fix:
> http://dpdk.org/ml/archives/dev/2016-December/051844.html
>
> Later another proposal triggered the discussion:
> http://dpdk.org/ml/archives/dev/2017-May/066317.html
>
> Finally a fix patch pushed into v17.08:
> Commit: b58eedfc7dd5 ("igb_uio: issue FLR during open and release of device file")
>
> Later a regression report sent related to the pushed patch:
> http://dpdk.org/ml/archives/dev/2017-September/075236.html
>
> And a fix for regression integrated into v17.11-rc1:
> http://dpdk.org/ml/archives/dev/2017-October/079166.html
> Commit: 5f6ff30dc507 ("igb_uio: fix interrupt enablement after FLR in VM")
> Commit: 6b9ed026a870 ("igb_uio: fix build with kernel <= 3.17")
>
> Even after the fix qede PMD reported to be broken:
> http://dpdk.org/ml/archives/dev/2017-October/079359.html
>
> So this patch reverts original fix and related commits. The related
> igb_uio code part turns back to v17.05 base.
>
> Cc: Jianfeng Tan <jianfeng.tan@intel.com>
> Cc: Jingjing Wu <jingjing.wu@intel.com>
> Cc: Shijith Thotton <shijith.thotton@caviumnetworks.com>
> Cc: Gregory Etelson <gregory@weka.io>
> Cc: Harish Patil <harish.patil@cavium.com>
> Cc: George Prekas <george.prekas@epfl.ch>
>
> Fixes: b58eedfc7dd5 ("igb_uio: issue FLR during open and release of device file")
> Cc: stable@dpdk.org
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
> It would be nice to solve this issue in LTS release, but being close to
> the release and the error report without details makes it hard to work
> more on this issue.
>
> Thanks everyone who spent effort for this, hopefully we can continue to
> work on next release cycle.
>
> Jingjing, there is a i40e commit, was part of igb_uio fix patchset, is
> it generic, or needs to be reverted with this patch?
> Commit: 8cacf78469a7 ("net/i40e: fix VF initialization error")
Hi Ferruh,
Please consider this patch as part of revert.
Commit: 9ed3f38770c6 ("net/liquidio: remove FLR request to PF driver")
Here I have removed extra FLR requests inside driver during init and close.
They are required now, as we remove resets in igb_uio.
Thanks,
Shijith
[...]