From: Shijith Thotton <shijith.thotton@caviumnetworks.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: Jingjing Wu <jingjing.wu@intel.com>,
Gregory Etelson <gregory@weka.io>,
Harish Patil <harish.patil@cavium.com>,
Thomas Monjalon <thomas@monjalon.net>,
dev@dpdk.org, stable@dpdk.org,
Jianfeng Tan <jianfeng.tan@intel.com>,
George Prekas <george.prekas@epfl.ch>,
Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>
Subject: Re: [dpdk-stable] [PATCH] igb_uio: remove device reset in open
Date: Tue, 24 Oct 2017 00:33:47 +0530 [thread overview]
Message-ID: <20171023190346.GA20733@localhost.localdomain> (raw)
In-Reply-To: <ef41920f-4d5e-df48-b249-d09c47280382@intel.com>
On Mon, Oct 23, 2017 at 09:36:38AM -0700, Ferruh Yigit wrote:
> On 10/23/2017 5:28 AM, Shijith Thotton wrote:
> > On Fri, Oct 20, 2017 at 09:57:38AM -0700, Ferruh Yigit wrote:
> >> On 10/20/2017 9:55 AM, Ferruh Yigit wrote:
> >>> Remove device reset during application start, the reset for application
> >>> exit still there.
> >>>
> >>> Reset in open removed because of following comments:
> >>> 1- Device reset not completed when VF driver loaded, which cause VF PMD
> >>> initialization error.
> >>> Adding delay can solve the issue but will increase driver load time.
> >>>
> >>> 2- Reset will be issues all devices unconditionally, not very efficient
> >>> way.
> >>>
> >>> Fixes: b58eedfc7dd5 ("igb_uio: issue FLR during open and release of device file")
> >>> Cc: stable@dpdk.org
> >>>
> >>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> >>
> >> Hi Jingjing, Shijith, Gregory, Harish,
> >>
> >> Can you please test this on top of current master (which has already Jingjin's
> >> fix) ?
> >
> > Hi Ferruh,
> >
> > Tested for LiquidIO cards and it works.
>
> Thanks Shijith,
>
> Is following commit needs to be reverted after pci_reset removed from open():
>
> Commit: 9ed3f38770c6 ("net/liquidio: remove FLR request to PF driver")
Not required. The commit can stay.
Thanks,
Shijith
next prev parent reply other threads:[~2017-10-23 19:03 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-17 20:14 [dpdk-stable] [PATCH] igb_uio: revert open and release operations Ferruh Yigit
2017-10-17 20:33 ` Thomas Monjalon
2017-10-18 4:50 ` Patil, Harish
2017-10-19 22:43 ` Patil, Harish
2017-10-20 1:15 ` Ferruh Yigit
2017-10-20 15:26 ` Tan, Jianfeng
2017-10-20 16:32 ` Ferruh Yigit
2017-10-20 16:55 ` [dpdk-stable] [PATCH] igb_uio: remove device reset in open Ferruh Yigit
2017-10-20 16:57 ` Ferruh Yigit
2017-10-20 19:01 ` Gregory Etelson
2017-10-20 22:18 ` Patil, Harish
2017-10-23 12:28 ` Shijith Thotton
2017-10-23 16:36 ` Ferruh Yigit
2017-10-23 19:03 ` Shijith Thotton [this message]
2017-10-24 2:45 ` Wu, Jingjing
2017-10-25 23:43 ` [dpdk-stable] [dpdk-dev] " Mody, Rasesh
2017-10-26 9:28 ` Tan, Jianfeng
2017-10-27 0:49 ` Ferruh Yigit
2017-11-01 6:58 ` Mody, Rasesh
2017-11-01 14:12 ` Stephen Hemminger
2017-11-02 8:03 ` Mody, Rasesh
2017-11-02 8:55 ` Ferruh Yigit
2017-11-02 17:34 ` Mody, Rasesh
2017-11-02 18:09 ` Ferruh Yigit
2017-11-02 18:45 ` Mody, Rasesh
2017-11-03 0:31 ` Ferruh Yigit
2017-11-03 19:18 ` Mody, Rasesh
2017-10-24 21:38 ` [dpdk-stable] " Ferruh Yigit
2017-10-18 0:14 ` [dpdk-stable] [PATCH] igb_uio: revert open and release operations Wu, Jingjing
2017-10-18 6:27 ` Shijith Thotton
2017-10-18 20:47 ` Ferruh Yigit
2017-10-24 21:32 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171023190346.GA20733@localhost.localdomain \
--to=shijith.thotton@caviumnetworks.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=george.prekas@epfl.ch \
--cc=gregory@weka.io \
--cc=harish.patil@cavium.com \
--cc=jianfeng.tan@intel.com \
--cc=jingjing.wu@intel.com \
--cc=sergio.gonzalez.monroy@intel.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).